node: Add support for node: prefix on v14 #57498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@LinusU Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PR
Code ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 57498,
"author": "LinusU",
"headCommitOid": "b7c46da667dc8d9f9942b4bda7b062f028e413a3",
"lastPushDate": "2021-12-02T12:28:36.000Z",
"lastActivityDate": "2021-12-03T12:01:42.000Z",
"mergeOfferDate": "2021-12-02T21:23:49.000Z",
"mergeRequestDate": "2021-12-03T12:01:42.000Z",
"mergeRequestUser": "LinusU",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "node",
"kind": "edit",
"files": [
{
"path": "types/node/v14/assert.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/async_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/buffer.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/child_process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/cluster.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/console.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/constants.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/crypto.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/dgram.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/dns.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/domain.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/fs.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/fs/promises.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/http.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/http2.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/https.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/index.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/inspector.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/module.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/net.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/os.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/path.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/perf_hooks.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/process.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/punycode.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/querystring.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/readline.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/repl.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/stream.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/string_decoder.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/test/assert.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/async_hooks.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/buffer.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/child_process.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/cluster.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/constants.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/crypto.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/dgram.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/dns.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/events.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/fs.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/global.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/http.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/http2.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/https.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/module.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/net.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/os.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/path.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/perf_hooks.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/process.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/querystring.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/readline.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/repl.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/stream.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/string_decoder.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/tls.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/tty.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/url.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/util.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/v8.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/vm.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/wasi.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/worker_threads.ts",
"kind": "test"
},
{
"path": "types/node/v14/test/zlib.ts",
"kind": "test"
},
{
"path": "types/node/v14/timers.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/tls.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/trace_events.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/tty.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/url.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/util.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/v8.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/vm.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/wasi.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/worker_threads.d.ts",
"kind": "definition"
},
{
"path": "types/node/v14/zlib.d.ts",
"kind": "definition"
}
],
"owners": [
"Microsoft",
"DefinitelyTyped",
"jkomyno",
"alvis",
"r3nya",
"btoueg",
"smac89",
"touffy",
"DeividasBakanas",
"eyqs",
"Hannes-Magnusson-CK",
"hoo29",
"kjin",
"ajafff",
"islishude",
"mwiktorczyk",
"mohsen1",
"n-e",
"galkin",
"parambirs",
"eps1lon",
"westy92",
"SimonSchick",
"ThomasdenH",
"WilcoBakker",
"wwwy3y3",
"samuela",
"kuehlein",
"bhongy",
"chyzwar",
"trivikr",
"yoursunny",
"qwelias",
"ExE-Boss",
"Ryan-Willpower",
"peterblazejewicz",
"addaleax",
"victorperin",
"ZYSzys",
"NodeJS",
"LinusU",
"wafuwafu13"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2021-12-02T21:23:09.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 984588690,
"ciResult": "pass"
} |
Contributor
|
🔔 @microsoft @DefinitelyTyped @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @n-e @galkin @parambirs @eps1lon @westy92 @SimonSchick @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @Ryan-Willpower @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @wafuwafu13 — please review this PR in the next few days. Be sure to explicitly select |
Contributor
|
@LinusU: Everything looks good here. I am ready to merge this PR (at b7c46da) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@microsoft, @DefinitelyTyped, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @n-e, @galkin, @parambirs, @eps1lon, @westy92, @SimonSchick, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @Ryan-Willpower, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @wafuwafu13: you can do this too.) |
Contributor
Author
|
Ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
node:‑prefixedrequire(…)calls nodejs/node#37246I've painstakingly coped each block as to exactly match what's being done in the 16.x version, so if any changes should be made we should probably make them in both.
The tests was simply switched over to use the
node:-prefix, because that's what's done in the v16.x version.