@wordpress/data-controls: Remove unneeded test. #50175
Conversation
This removes a test from `@wordpress/data-controls` that doesn't test anything useful and is broken by microsoft/TypeScript#41348 because all of the variables created are now considered "implicitly `any`".
|
@rbuckton Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 50175,
"author": "rbuckton",
"headCommitAbbrOid": "3c079a7",
"headCommitOid": "3c079a75d43e1a31207791218b6ac02ed4a605c3",
"lastPushDate": "2020-12-18T01:36:37.000Z",
"lastActivityDate": "2020-12-18T01:38:12.000Z",
"maintainerBlessed": false,
"hasMergeConflict": false,
"isFirstContribution": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "wordpress__data-controls",
"kind": "edit",
"files": [
{
"path": "types/wordpress__data-controls/wordpress__data-controls-tests.ts",
"kind": "test"
}
],
"owners": [
"dsifford"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"ciResult": "pass"
} |
|
🔔 @dsifford — please review this PR in the next few days. Be sure to explicitly select |
|
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
|
👍🏻 |
This removes a test from
@wordpress/data-controlsthat doesn't test anything useful and is broken by microsoft/TypeScript#41348 because all of the variables created are now considered "implicitlyany".All of the functions tested are covered on the lines above this removed section, and all it is verifying is that the result of
yieldisany, which isn't very useful.Please fill in this template.
npm test <package to test>.