react-redux currently relies on a TS bug (Microsoft/TypeScript#30634) to sucessfully typecheck #34335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to sucessfully typecheck, this fixes that
|
@weswigham Thank you for submitting this PR! 🔔 @tkqubo @kenzierocks @clayne11 @tansongyang @NicholasBoll @mDibyo @Kallikrein @val1984 @jrakotoharisoa @apapirovski @surgeboris @soerenbf - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
Since CI is green, I'm just going to merge this, as this shouldn't break anyone AFAIK - the constraint actually meant approximately nothing in current TS (maybe any TS?) since it was circular, so it was effectively unconstrained already. |
|
I just published |
weswigham
added a commit
that referenced
this pull request
Mar 30, 2019
weswigham
added a commit
to weswigham/react-dnd
that referenced
this pull request
Mar 30, 2019
Fixing microsoft/TypeScript#30634 will make this constraint fail to check for most users - this type seems to have been copied from (to?) `react-redux`, which has taken in a similar change on DT: DefinitelyTyped/DefinitelyTyped#34335 DefinitelyTyped/DefinitelyTyped#34339
weswigham
added a commit
that referenced
this pull request
Mar 30, 2019
darthtrevino
pushed a commit
to react-dnd/react-dnd
that referenced
this pull request
Mar 31, 2019
Fixing microsoft/TypeScript#30634 will make this constraint fail to check for most users - this type seems to have been copied from (to?) `react-redux`, which has taken in a similar change on DT: DefinitelyTyped/DefinitelyTyped#34335 DefinitelyTyped/DefinitelyTyped#34339
alesn
pushed a commit
to alesn/DefinitelyTyped
that referenced
this pull request
Apr 23, 2019
… to sucessfully typecheck, this fixes that (DefinitelyTyped#34335)
alesn
pushed a commit
to alesn/DefinitelyTyped
that referenced
this pull request
Apr 23, 2019
darthtrevino
pushed a commit
to react-dnd/react-dnd
that referenced
this pull request
Feb 3, 2022
Fixing microsoft/TypeScript#30634 will make this constraint fail to check for most users - this type seems to have been copied from (to?) `react-redux`, which has taken in a similar change on DT: DefinitelyTyped/DefinitelyTyped#34335 DefinitelyTyped/DefinitelyTyped#34339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes that. The constraint on
Shared's second type parameter's constraint seems to be completely unneeded, so I just.... removed it.