8000 Update Plotly.js Type Definition by frederikaalund · Pull Request #17974 · DefinitelyTyped/DefinitelyTyped · GitHub
[go: up one dir, main page]
Skip to content

Update Plotly.js Type Definition #17974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2017
Merged

Update Plotly.js Type Definition #17974

merged 1 commit into from
Jul 12, 2017

Conversation

frederikaalund
Copy link
@frederikaalund frederikaalund commented Jul 12, 2017 •
edited
Loading
  • Bump version to 1.28.3.
  • Add myself (Frederik Aalund) to Definitions by.
  • Add Promise<Root> to the return values of relayout and redraw (ref).
  • Add dragmode to Layout (ref).
  • Add toImage to ModeBarButtons (ref).
  • Update Config.modeBarButtons to ModeBarButtons[][] (it was incorrectly set to boolean). This was already part of the documentation in the index.d.ts file.

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@dt-bot
Copy link
Member
dt-bot commented Jul 12, 2017

types/plotly.js/index.d.ts

to authors (@chrisgervang @martinduparc). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@martinduparc
Copy link
Contributor

@frederikaalund The build failed

@frederikaalund
Copy link
Author
frederikaalund commented Jul 12, 2017 •
edited
Loading

@martinduparc Thanks for making me aware of the issue. I've removed the patch from the version string.
Edit: And changed the array definition.

@martinduparc
Copy link
Contributor

The build still seems to be failing. Have a look at the travis logs to see what the problem is.

@frederikaalund frederikaalund force-pushed the patch-1 branch 5 times, most recently from 3a88890 to 6f614c8 Compare July 12, 2017 14:05
Update Plotly.js Type Definition
ed24f70 
Bump version to 1.28.
Add myself (Frederik Aalund) to `Definitions by`.
Add `Promise<Root>` to the return values of `relayout` and `redraw`.
Add `dragmode` to `Layout`.
Add `toImage` to `ModeBarButtons`.
Update `Config.modeBarButtons` to  `ModeBarButtons[][]` (it was incorrectly set to `boolean`).
@frederikaalund
Copy link
Author

Should be fixed now. I was fighting the forced array syntax.

@typescript-bot
Copy link
Contributor

Approved by a listed author. PR appears ready to merge pending express review by a maintainer.
This message was generated by a script

@RyanCavanaugh RyanCavanaugh merged commit 77b3422 into DefinitelyTyped:master Jul 12, 2017
@gnestor gnestor mentioned this pull request Jul 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frederikaalund @dt-bot @martinduparc @typescript-bot @RyanCavanaugh
0