Close figures before plotting #3168
Open
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d plots. This commit changes behavior from only closing figures when `showfigures=False` to always closing figures before plotting. Addressing feature request DeepLabCut#3164.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the PlottingResults function to close all matplotlib figures before creating new plots, addressing feature request #3164. Previously, figures were only closed when showfigures=False; now they are always closed at the start of the function to prevent figure accumulation.
Key Changes:
- Always close figures before plotting (regardless of
showfiguresparameter) - Simplified end-of-function logic to only show figures when requested
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
@MMathisLab, this PR is a matter of design choice / preferred behavior for the
Both are valid options. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing all plots before plotting new ones. This avoids overflowing the screen with old plots.
This commit changes behavior from only closing figures when
showfigures=Falseto always closing figures before plotting. Addresses feature request #3164.