Add some padding to tray icons #261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I think it was a bit too much. Now it looks slightly too small on GNOME compared to other icons, especially with the exit node disabled. 
Edit: With a bounding box: 
|
Author
|
Right that's interesting, I think the size I picked falls in between two pixels on non high definition displays and it ends up looking smaller than expected. |
Author
|
I tried it with a standard definition VM and it does look like it lines up Gnome/Ubuntu: So I guess the issue is more than 3rd party tray icons are sometime bigger so I changed it to something in between instead, does that look ok? 1080p: 4k (150%): |
d3596a4 to
528a762
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #259, the existing tray icons lack padding which means they appear larger than the average tray icon.
This PR adds some padding. Below are some example in context.
Before:
After:
