Fix/sources yml dbt2 compatibility#816
Open
Derrick-Ryan-Giggs wants to merge 7 commits intoDataTalksClub:mainfrom
Open
Fix/sources yml dbt2 compatibility#816Derrick-Ryan-Giggs wants to merge 7 commits intoDataTalksClub:mainfrom
Derrick-Ryan-Giggs wants to merge 7 commits intoDataTalksClub:mainfrom
Conversation
…mpatibility fix: remove freshness and loaded_at_field from sources.yml for dbt 2.…
…ineering-zoomcamp into fix/sources-yml-dbt2-compatibility
…mpatibility Fix/sources yml dbt2 compatibility
There was a problem hiding this comment.
Pull request overview
This pull request adds support for FHV (For-Hire Vehicle) trip data and refactors the staging models' date filtering logic to align with homework requirements. The changes include modifications to data source definitions, staging SQL models, and dependency configurations.
Changes:
- Added new stg_fhv_tripdata staging model with 2019 data filtering
- Refactored date filtering in yellow and green taxi staging models from conditional (dev-only) to unconditional 2019-2020 filtering with additional dev sampling
- Removed data freshness checks and loaded_at_field configurations from sources.yml, simplified column descriptions, and added fhv_tripdata source definition
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| package-lock.yml | Alphabetically reordered package dependencies (codegen, dbt_utils) with updated hash |
| stg_yellow_tripdata.sql | Added unconditional 2019-2020 date filter with extended dev environment sampling logic |
| stg_green_tripdata.sql | Added unconditional 2019-2020 date filter with extended dev environment sampling logic |
| stg_fhv_tripdata.sql | New staging model for FHV trip data with 2019-only filtering and column transformations |
| sources.yml | Removed freshness/loaded_at_field configs, simplified descriptions, hardcoded GCP project ID, added fhv_tripdata source |
| .gitignore | Added dbt_internal_packages/ and trailing whitespace to profiles.yml |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
04-analytics-engineering/taxi_rides_ny/models/staging/stg_fhv_tripdata.sql
Show resolved
Hide resolved
04-analytics-engineering/taxi_rides_ny/models/staging/stg_fhv_tripdata.sql
Show resolved
Hide resolved
04-analytics-engineering/taxi_rides_ny/models/staging/stg_fhv_tripdata.sql
Show resolved
Hide resolved
Collaborator
|
Hi @Derrick-Ryan-Giggs, thanks for your contribution. I definitely missed that empty space and I guess sorting the dbt packages can be interesting, but there are a couple of things in there that I can't merge yet.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.