AGTMETRICS-61 Optimize utf-8 encoding of payloads #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use hand-rolled UTF-16 conversion to UTF-8. This is always faster than using CharsetEncoder. String.getBytes is even faster, but it allocates and leads to memory usage regression on the test app.
StringBuilder.append(Long) allocates a temporary string, while StringBuilder.append(long) does not and writes digits directly.
3c96651 to
3e7edf9
Compare
Closed
carlosroman
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize client UTF-8 encoding with hand-rolled conversion from UTF-16.
For pure ascii strings, this is much faster than using
CharsetEncoderthe way we were using it (A: 4.4.3, B: this PR).While the encoding routine itself is slower, overall it runs on par with
String.getBytesdue to fewer allocations and less GC pressure (A: #259, B: this PR)With a few non-ascii characters, it is a bit slower, but still outperforms
CharsetEncoder.vs String.getBytes()
