8000 [DOCS-8678] update Helm config for network path by aliciascott · Pull Request #29376 · DataDog/documentation · GitHub
[go: up one dir, main page]

Skip to content

[DOCS-8678] update Helm config for network path #29376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 19, 2025

Conversation

aliciascott
Copy link
Contributor

What does this PR do? What is the motivation?

Adds Helm instructions to the Network Path setup docs for dynamic paths, and updates links.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@aliciascott aliciascott requested a review from a team as a code owner May 15, 2025 15:28
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor
@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'm not an expert here, so I had some questions I thought a user might have too - feel free to ping me if I'm missing something :D

@aliciascott aliciascott requested a review from janine-c May 15, 2025 22:24
Copy link
Contributor
@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, Alicia!! :shipit:

Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
@aliciascott
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
dd-devflow bot commented May 19, 2025

View all feedbacks in Devflow UI.

2025-05-19 15:10:10 UTC ℹ️ Start processing command /merge


2025-05-19 15:10:24 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-19 15:32:12 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 21m (p90).


2025-05-19 15:51:25 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 449a407 into master May 19, 2025
20 of 22 checks passed
@dd-mergequeue dd-mergequeue bot deleted the aliciascott/DOCS-8678-network-path branch May 19, 2025 15:51
brantigua pushed a commit that referenced this pull request May 19, 2025
* update Helm config for network path

* fix wording

* adding Agent version

* Apply suggestions from code review

Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>

---------

Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0