8000 [DOCS-10330] Add Set up Worker in ECS Fargate by maycmlee · Pull Request #29356 · DataDog/documentation · GitHub
[go: up one dir, main page]

Skip to content

[DOCS-10330] Add Set up Worker in ECS Fargate #29356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

maycmlee
Copy link
Contributor

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@maycmlee maycmlee requested a review from a team as a code owner May 14, 2025 19:26
@github-actions github-actions bot added Architecture Everything related to the Doc backend Images Images are added/removed with this PR labels May 14, 2025
Copy link
Contributor

Preview links (active after the build_preview check completes)

New or renamed files

@maycmlee maycmlee added the WORK IN PROGRESS No review needed, it's a wip ;) label May 14, 2025
@maycmlee maycmlee removed the WORK IN PROGRESS No review needed, it's a wip ;) label May 15, 2025
Copy link
Contributor
@ckelner ckelner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!


[Create a task definition][1]. The task definition describes which containers to run, the configuration (such as the environment variables and ports), and the CPU and memory resources allocated for the task.

Set the `DD_OP_SOURCE_*` environment variable according to the configuration of the pipeline and port mappings. `DD_OP_API_ENABLED` and `DD_OP_API_ADDRESS` are used to allow the load balancer to do health checks on the routing targets. The CPU and memory resources should be increased for the production usage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we consider:
DD_OP_API_ENABLED and DD_OP_API_ADDRESS allow the load balancer to perform health checks on the routing targets.

Additionally, What are routing targets? Can we simplify?

"The CPU and memory resources should be increased for the production usage." -> to what?

Copy link
Contributor Author
@maycmlee maycmlee May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, What are routing targets? Can we simplify?

"The CPU and memory resources should be increased for the production usage." -> to what?

@kennonkwok could you take a look?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re "routing targets, we can simplify that by calling them "workers" instead.

@ckelner can you advise on the resources?

Copy link
Contributor Author
@maycmlee maycmlee May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re "routing targets, we can simplify that by calling them "workers" instead.

@kennonkwok Just want to confirm that "workers" are OP Workers?

Edit: NVM, reread and it's OP Workers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kennonkwok @ckelner was chatting with Pratik and we decided to just put xxxx for CPU and memory in the task definition, so users will know to change that. And we'll remove the line:

The CPU and memory resources should be increased for the production usage.


[Create a task definition][1]. The task definition describes which containers to run, the configuration (such as the environment variables and ports), and the CPU and memory resources allocated for the task.

Set the `DD_OP_SOURCE_*` environment variable according to the configuration of the pipeline and port mappings. `DD_OP_API_ENABLED` and `DD_OP_API_ADDRESS` are used to allow the load balancer to do health checks on the routing targets. The CPU and memory resources should be increased for the production usage.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Set the `DD_OP_SOURCE_*` environment variable according to the configuration of the pipeline and port mappings. `DD_OP_API_ENABLED` and `DD_OP_API_ADDRESS` are used to allow the load balancer to do health checks on the routing targets. The CPU and memory resources should be increased for the production usage.
Set the `DD_OP_SOURCE_*` environment variable according to the configuration of the pipeline and port mappings. `DD_OP_API_ENABLED` and `DD_OP_API_ADDRESS` allow the load balancer to do health checks on the routing targets. The CPU and memory resources should be increased for the production usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architecture Everything related to the Doc backend Images Images are added/removed with this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0