-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Synthetics Private locations: restructure install collapse section into tabs #29327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview links (active after the
|
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
deforest.richards@datadoghq.com cancelled this merge request build |
/merge -c |
View all feedbacks in Devflow UI.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. There's just one tab that's missing the destination link.
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
Gitlab pipeline didn't start on its own and we were unable to create it... Please retry. Error: POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/documentation/pipeline: 400 {message: {base: [Reference not found]}} (type: ErrorResponse, retryable: true) |
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
What does this PR do? What is the motivation?
This PR migrates the Install collapse section which was quite large, back into tabs format to take advantage of the new tab cdocs layout for large sets of tabs.
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes