8000 Synthetics Private locations: restructure install collapse section into tabs by aliciascott · Pull Request #29327 · DataDog/documentation · GitHub
[go: up one dir, main page]

Skip to content

Synthetics Private locations: restructure install collapse section into tabs #29327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2025

Conversation

aliciascott
Copy link
Contributor

What does this PR do? What is the motivation?

This PR migrates the Install collapse section which was quite large, back into tabs format to take advantage of the new tab cdocs layout for large sets of tabs.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@aliciascott aliciascott requested a review from a team as a code owner May 13, 2025 21:20
Copy link 8000
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@drichards-87
Copy link
Contributor

/merge

@dd-devflow
Copy link
dd-devflow bot commented May 13, 2025

View all feedbacks in Devflow UI.

2025-05-13 21:50:12 UTC ℹ️ Start processing command /merge


2025-05-13 21:50:16 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-05-13 21:50:59 UTC ⚠️ MergeQueue: This merge request build was cancelled

deforest.richards@datadoghq.com cancelled this merge request build

@drichards-87
Copy link
Contributor

/merge -c

@dd-devflow
Copy link
dd-devflow bot commented May 13, 2025

View all feedbacks in Devflow UI.

2025-05-13 21:50:53 UTC ℹ️ Start processing command /merge -c

Copy link
Contributor
@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. There's just one tab that's missing the destination link.

Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
@drichards-87
Copy link
Contributor

/merge

@dd-devflow
Copy link
dd-devflow bot commented May 13, 2025

View all feedbacks in Devflow UI.

2025-05-13 23:25:21 UTC ℹ️ Start processing command /merge


2025-05-13 23:25:24 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-05-13 23:28:00 UTC 🚨 MergeQueue: This merge request is in error because of GitLab

Gitlab pipeline didn't start on its own and we were unable to create it... Please retry.

Error: POST https://gitlab.ddbuild.io/api/v4/projects/DataDog/documentation/pipeline: 400 {message: {base: [Reference not found]}} (type: ErrorResponse, retryable: true)

@aliciascott
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
dd-devflow bot commented May 14, 2025

View all feedbacks in Devflow UI.

2025-05-14 14:38:09 UTC ℹ️ Start processing command /merge


2025-05-14 14:38:26 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 20m (p90).


2025-05-14 14:57:37 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 37f0a57 into master May 14, 2025
26 of 34 checks passed
@dd-mergequeue dd-mergequeue bot deleted the aliciascott/fix-tabs-private-locations branch May 14, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0