8000 Update is_match behaviour with empty string by SimoneT-DD · Pull Request #29309 · DataDog/documentation · GitHub
[go: up one dir, main page]
Skip to content

Update is_match behaviour with empty string #29309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 19, 2025
Merged

Update is_match behaviour with empty string #29309

merged 5 commits into from
May 19, 2025

Conversation

SimoneT-DD
Copy link
Contributor

What does this PR do? What is the motivation?

Update is_match behaviour with empty string

Merge instructions

Merge readiness:

  • Ready for merge

@SimoneT-DD SimoneT-DD requested a review from a team as a code owner May 13, 2025 14:13
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

drichards-87
drichards-87 requested changes May 13, 2025
View reviewed changes
Copy link
Contributor
@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of very minor suggestions.

SimoneT-DD and others added 2 commits May 14, 2025 10:51
@SimoneT-DD @drichards-87
Apply suggestions from code review
787746a 
Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
@SimoneT-DD
update is match section
ea50308
@SimoneT-DD SimoneT-DD requested a review from drichards-87 May 14, 2025 09:25
drichards-87
drichards-87 approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor
@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to add this to the merge queue when ready.

@SimoneT-DD
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
dd-devflow bot commented May 19, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-05-19 12:41:37 UTC ℹ️ Start processing command /merge

2025-05-19 12:41:43 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 21m (p90).

2025-05-19 12:59:34 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 7c0385b into master May 19, 2025
20 of 22 checks passed
@dd-mergequeue dd-mergequeue bot deleted the SimoneT-DD/is_match_update_empty_string branch May 19, 2025 12:59
brantigua pushed a commit that referenced this pull request May 19, 2025
@SimoneT-DD @drichards-87
Update is_match behaviour with empty string (#29309)
9e73a3f 
* Update is_match behaviour with empty string

* update is_exact_match

* update fallback documentation

* Apply suggestions from code review

Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>

* update is match section

---------

Co-authored-by: DeForest Richards <56796055+drichards-87@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lee-see lee-see lee-see approved these changes

@drichards-87 drichards-87 drichards-87 approved these changes

Assignees
No one assigned
Labels
mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimoneT-DD @lee-see @drichards-87
0