8000 Teddy.gesbert/doc dora by Tecoddy · Pull Request #29305 · DataDog/documentation · GitHub
[go: up one dir, main page]

Skip to content

Teddy.gesbert/doc dora #29305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
May 15, 2025
Merged

Teddy.gesbert/doc dora #29305

merged 35 commits into from
May 15, 2025

Conversation

Tecoddy
Copy link
Contributor
@Tecoddy Tecoddy commented May 13, 2025

What does this PR do? What is the motivation?

Removing the Preview alert for the GA of DORA Metrics and adding two small changes related to definitions.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

Tecoddy and others added 30 commits March 17, 2025 18:43
Co-authored-by: Jorge Calvar <138497895+calvarjorge@users.noreply.github.com>
Change deployment.merge_time to Merge Time (i.e. metric to field) to avoid any confusion with previous Metrics type
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
- Added consistency between data sources requirements.
- Remove /dora_metrics/failures/datadog_incidents alias as not needed.
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Added backfill documentation for retrieving past incidents using Incident Management as a DORA failure source.
Co-authored-by: May Lee <may.lee@datadoghq.com>
Co-authored-by: May Lee <may.lee@datadoghq.com>
Co-authored-by: May Lee <may.lee@datadoghq.com>
Tecoddy added 2 commits April 25, 2025 10:05
Removing Preview alert + 2 small changes on definitions
@Tecoddy Tecoddy requested review from a team as code owners May 13, 2025 09:44
@datadog-datadog-prod-us1
Copy link

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies


Was this helpful? Give us feedback!

@drichards-87
Copy link
Contributor

Hi @Tecoddy. It looks like your PR has a merge conflict. Could you resolve that, and then I'll take a look at the PR. Thanks!

@drichards-87 drichards-87 self-assigned this May 13, 2025
@Tecoddy
Copy link
Contributor Author
Tecoddy commented May 13, 2025

Hi @drichards-87. Thanks for spotting this, it's already resolved.

Copy link
Contributor
@drichards-87 drichards-87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Feel free to add this to the merge queue when you're ready to merge it.

@Tecoddy
Copy link
Contributor Author
Tecoddy commented May 15, 2025

/merge

@dd-devflow
Copy link
dd-devflow bot commented May 15, 2025

View all feedbacks in Devflow UI.

2025-05-15 15:40:42 UTC ℹ️ Start processing command /merge


2025-05-15 15:40:57 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-15 16:11:17 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 21m (p90).


2025-05-15 16:27:11 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet 41D4
Development

Successfully merging this pull request may close these issues.

2 participants
0