-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Teddy.gesbert/doc dora #29305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teddy.gesbert/doc dora #29305
Conversation
Co-authored-by: Jorge Calvar <138497895+calvarjorge@users.noreply.github.com>
Change deployment.merge_time to Merge Time (i.e. metric to field) to avoid any confusion with previous Metrics type
…tion into teddy.gesbert/doc-dora
Applied suggestions from Joe Peeples
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
- Added consistency between data sources requirements. - Remove /dora_metrics/failures/datadog_incidents alias as not needed.
Co-authored-by: Alicia Scott <aliciascott@users.noreply.github.com>
Added backfill documentation for retrieving past incidents using Incident Management as a DORA failure source.
Co-authored-by: May Lee <may.lee@datadoghq.com>
Co-authored-by: May Lee <may.lee@datadoghq.com>
Co-authored-by: May Lee <may.lee@datadoghq.com>
Removing Preview alert + 2 small changes on definitions
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Was this helpful? Give us feedback! |
Hi @Tecoddy. It looks like your PR has a merge conflict. Could you resolve that, and then I'll take a look at the PR. Thanks! |
Hi @drichards-87. Thanks for spotting this, it's already resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Feel free to add this to the merge queue when you're ready to merge it.
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
What does this PR do? What is the motivation?
Removing the Preview alert for the GA of DORA Metrics and adding two small changes related to definitions.
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes