-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Cdocs pilot page #2 (Proxy RUM browser data) #29246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cdocs pilot page #2 (Proxy RUM browser data) #29246
Conversation
Preview links (active after the
|
default: true | ||
- id: socks | ||
|
||
rum_browser_sdk_source_options: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one to the end of the file are the new option groups, the other two just got reorganized.
@@ -0,0 +1,35 @@ | |||
traits: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file just got renamed, it actually only has one change, flagged below.
label: "OS" | ||
internal_notes: Mobile operating system, such as Android. | ||
|
||
- id: lib_src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change is that I renamed this from pkg_mgr
to allow for a broader range of logical values.
@@ -0,0 +1,5 @@ | |||
traits: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content of this file is new.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a small nit, but this is looking good to me, so I'm going to approve to unblock. This is a great page to demo how powerful cdocs is. It shows you how much we've been relying on the user to figure out which sections of a doc apply to them. Renaming that "Alternate setup" section was also a nice touch.
|
||
Your Datadog intake URL should have the format `<INTAKE_ORIGIN>/<PATH><PARAMETERS>` (for example, `https://browser-intake-datadoghq.eu/api/v2/rum?ddsource=browser&...`). | ||
|
||
{% table %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: We should investigate getting Vale to ignore markdoc partial syntax
Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
jen.gilbert@datadoghq.com unqueued this merge request |
/remove |
View all feedbacks in Devflow UI.
|
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
What does this PR do? What is the motivation?
This adds the second Cdocs pilot page to the docs site, and bumps the Cdocs integration to the latest version. I'm adding these in the same PR because the pilot page demonstrates many of the integration changes that would otherwise be difficult to test.
Notes for all reviewers
Links to specific headers don't work. This is a known issue that's already fixed in a subsequent release of Cdocs (which will be QA'd with the next pilot page, along with other bug fixes).
Notes for Heston
>=5.4.0
vs>=4.34.0
)customization_config
directory to keep any version-specific stuff out of the way. I imagine those could add a lot of clutter otherwise.Notes for the websites team
Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes