8000 Cdocs pilot page #2 (Proxy RUM browser data) by jhgilbert · Pull Request #29246 · DataDog/documentation · GitHub
[go: up one dir, main page]

Skip to content

Cdocs pilot page #2 (Proxy RUM browser data) #29246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 19, 2025

Conversation

jhgilbert
Copy link
Contributor
@jhgilbert jhgilbert commented May 8, 2025

What does this PR do? What is the motivation?

This adds the second Cdocs pilot page to the docs site, and bumps the Cdocs integration to the latest version. I'm adding these in the same PR because the pilot page demonstrates many of the integration changes that would otherwise be difficult to test.

Notes for all reviewers

Links to specific headers don't work. This is a known issue that's already fixed in a subsequent release of Cdocs (which will be QA'd with the next pilot page, along with other bug fixes).

Notes for Heston

  • This page shows two new (to prod, at least) features:
    • Use of DD site based customization
    • A different TOC for different filter choices (>=5.4.0 vs >=4.34.0)
  • I reworked this content a little more than I normally would, because I wanted to test a few Markdoc things. The original content was SME-submitted and then edited by me, so I don't think anyone would object.
  • I reorganized the customization_config directory to keep any version-specific stuff out of the way. I imagine those could add a lot of clutter otherwise.
  • I've QA'd the new docs page according to the Cdocs QA checklist. Let me know if I should add anything to that list.

Notes for the websites team

  • I've QA'd the integration changes according to the Cdocs QA checklist. Let me know if I should add anything to that list.
  • I added a changelog to the Cdocs integration to make it easy to review any relevant releases, please refer to that for more details on the differences between the current version on the docs site and the target version.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@jhgilbert jhgilbert added the WORK IN PROGRESS No review needed, it's a wip ;) label May 8, 2025
@github-actions github-actions bot added the Guide Content impacting a guide label May 8, 2025
Copy link
Contributor
github-actions bot commented May 8, 2025

@jhgilbert jhgilbert added editorial review Waiting on a more in-depth review and removed WORK IN PROGRESS No review needed, it's a wip ;) labels May 8, 2025
@jhgilbert jhgilbert marked this pull request as ready for review May 8, 2025 22:53
@jhgilbert jhgilbert requested review from a team as code owners May 8, 2025 22:53
default: true
- id: socks

rum_browser_sdk_source_options:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one to the end of the file are the new option groups, the other two just got reorganized.

@@ -0,0 +1,35 @@
traits:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file just got renamed, it actually only has one change, flagged below.

label: "OS"
internal_notes: Mobile operating system, such as Android.

- id: lib_src
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only change is that I renamed this from pkg_mgr to allow for a broader range of logical values.

@@ -0,0 +1,5 @@
traits:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of this file is new.

Copy link
Contributor
@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small nit, but this is looking good to me, so I'm going to approve to unblock. This is a great page to demo how powerful cdocs is. It shows you how much we've been relying on the user to figure out which sections of a doc apply to them. Renaming that "Alternate setup" section was also a nice touch.


Your Datadog intake URL should have the format `<INTAKE_ORIGIN>/<PATH><PARAMETERS>` (for example, `https://browser-intake-datadoghq.eu/api/v2/rum?ddsource=browser&...`).

{% table %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: We should investigate getting Vale to ignore markdoc partial syntax

Co-authored-by: Heston Hoffman <heston.hoffman@datadoghq.com>
@jhgilbert
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
dd-devflow bot commented May 19, 2025

View all feedbacks in Devflow UI.

2025-05-19 18:57:21 UTC ℹ️ Start processing command /merge


2025-05-19 18:57:30 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-19 18:59:14 UTC ⚠️ MergeQueue: This merge request was unqueued

jen.gilbert@datadoghq.com unqueued this merge request

@jhgilbert
Copy link
Contributor Author

/remove

@dd-devflow
Copy link
dd-devflow bot commented May 19, 2025

View all feedbacks in Devflow UI.

2025-05-19 18:59:08 UTC ℹ️ Start processing command /remove


2025-05-19 18:59:11 UTC ℹ️ Devflow: /remove

@jhgilbert
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
dd-devflow bot commented May 19, 2025

View all feedbacks in Devflow UI.

2025-05-19 18:59:23 UTC ℹ️ Start processing command /merge


2025-05-19 18:59:34 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-19 19:06:20 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 21m (p90).


2025-05-19 19:25:16 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review Guide Content impacting a guide mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0