8000 Adds new specifications for 'Events with Email' documentation by pablo-encinas · Pull Request #29203 · DataDog/documentation · GitHub
[go: up one dir, main page]

Skip to content

Adds new specifications for 'Events with Email' documentation #29203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already 10000 on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 13, 2025

Conversation

pablo-encinas
Copy link
Contributor
@pablo-encinas pablo-encinas commented May 7, 2025

What does this PR do? What is the motivation?

Adds new specifications for 'Events with Email' documentation to reflect the new usages we have developed.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

Added new documentation
Copy link
Contributor
github-actions bot commented May 7, 2025

Preview links (active after the build_preview check completes)

Modified Files

@pablo-encinas pablo-encinas marked this pull request as ready for review May 7, 2025 12:58
@pablo-encinas pablo-encinas requested a review from a team as a code owner May 7, 2025 12:58
@pablo-encinas
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
dd-devflow bot commented May 7, 2025

View all feedbacks in Devflow UI.

2025-05-07 12:59:15 UTC ℹ️ Start processing command /merge


2025-05-07 12:59:21 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-05-07 15:20:29 UTC ⚠️ MergeQueue: This merge request was unqueued

pablo.encinas@datadoghq.com unqueued this merge request

@pablo-encinas pablo-encinas changed the title Update email.md Adds new specifications for 'Events with Email' documentation May 7, 2025
@pablo-encinas
Copy link
Contributor Author

/merge -c

@dd-devflow
Copy link
dd-devflow bot commented May 7, 2025

View all feedbacks in Devflow UI.

2025-05-07 15:20:24 UTC ℹ️ Start processing command /merge -c

@buraizu buraizu self-assigned this May 7, 2025
@buraizu buraizu added the editorial review Waiting on a more in-depth review label May 7, 2025
@buraizu
Copy link
Contributor
buraizu commented May 7, 2025

Created DOCS-10835 to review

Copy link
Contributor
@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I've left some suggested edits. Let me know if you have any questions or feedback.

pablo-encinas and others added 10 commits May 9, 2025 09:56
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
@pablo-encinas
Copy link
Contributor Author

Thanks @buraizu for those useful comments! I think I did all requested changes

@datadog-datadog-prod-us1
Copy link

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies


Was this helpful? Give us feedback!

@pablo-encinas
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
dd-devflow bot commented May 13, 2025

View all feedbacks in Devflow UI.

2025-05-13 07:30:06 UTC ℹ️ Start processing command /merge


2025-05-13 07:30:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 21m (p90).


2025-05-13 07:47:57 UTC ℹ️ MergeQueue: This merge request was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial review Waiting on a more in-depth review mergequeue-status: done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0