8000 [RUM] Update geo IP address images by rtrieu · Pull Request #28917 · DataDog/documentation · GitHub
[go: up one dir, main page]
Skip to content

[RUM] Update geo IP address images #28917

< 8000 summary id="button-b0544af398f88e4c" class="btn btn-sm btn-primary m-0 ml-0 ml-md-2" > New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 23, 2025
Merged

[RUM] Update geo IP address images #28917

merged 5 commits into from
Apr 23, 2025

Conversation

rtrieu
Copy link
Contributor
@rtrieu rtrieu commented Apr 22, 2025 •
edited
Loading

What does this PR do? What is the motivation?

  • Received internal feedback that the screenshot of the UI to update the geo IP address is outdated, so this PR addresses that
  • Also updated some of the language to comply with Vale

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@rtrieu rtrieu requested a review from a team as a code owner April 22, 2025 20:44
@github-actions github-actions bot added the Images Images are added/removed with this PR label Apr 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

buraizu
buraizu reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor
@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one suggestion based on a new Vale warning. Also, just wanted to confirm if it's expected for someone's name to be displayed in the new image.

rtrieu and others added 3 commits April 23, 2025 07:11
@rtrieu @buraizu
Update content/en/data_security/real_user_monitoring.md
9baec4f 
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
@rtrieu
Blur name in image
d031683
@rtrieu
Merge branch 'rtrieu/docs-10671-update-geo-ip-address-images-rum' of …
7751cf8 
…github.com:DataDog/documentation into rtrieu/docs-10671-update-geo-ip-address-images-rum
@rtrieu
Copy link
Contributor Author
rtrieu commented Apr 23, 2025

Thanks @buraizu, good call - updated the screenshot with the name blurred.

@rtrieu rtrieu requested a review from buraizu April 23, 2025 14:21
@buraizu
Copy link
Contributor
buraizu commented Apr 23, 2025

/merge

@dd-devflow
Copy link
dd-devflow bot commented Apr 23, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-23 21:34:30 UTC ℹ️ Start processing command /merge

2025-04-23 21:34:34 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 18m (p90).

2025-04-23 21:51:26 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 4545dac into master Apr 23, 2025
20 of 22 checks passed
@dd-mergequeue dd-mergequeue bot deleted the rtrieu/docs-10671-update-geo-ip-address-images-rum branch April 23, 2025 21:51
estherk15 pushed a commit t 80BE hat referenced this pull request May 8, 2025
@rtrieu @buraizu @estherk15
[RUM] Update geo IP address images (#28917)
5b7282f 
* [rum] Update geo IP screenshot and some text

* refine

* Update content/en/data_security/real_user_monitoring.md

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>

* Blur name in image

---------

Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buraizu buraizu buraizu approved these changes

Assignees
No one assigned
Labels
Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rtrieu @buraizu
0