10000 Add more info on correlating trace and container metrics by brett0000FF · Pull Request #28870 · DataDog/documentation · GitHub
[go: up one dir, main page]

Skip to content

Add more info on correlating trace and container metrics #28870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 23, 2025

Conversation

brett0000FF
Copy link
Contributor
@brett0000FF brett0000FF commented Apr 18, 2025

What does this PR do? What is the motivation?

  • Clarify what values should be set for these resource attributes.
  • Note that container metric views aren't available unless container.id is set.
  • Add example.

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@brett0000FF brett0000FF requested a review from a team as a code owner April 18, 2025 20:33
@brett0000FF brett0000FF requested a review from liustanley April 18, 2025 20:33
@brett0000FF
Copy link
Contributor Author

@liustanley - Hey! I think we chatted about this a while back. Could you please help me verify the technical accuracy of this content I added? Thanks!

Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor
@iadjivon iadjivon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Brett,
I added a small edit, but otherwise, all set to merge :)

Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com>
Copy link
Contributor
@liustanley liustanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I might not have the latest context on this so it might be worth asking the USM team to confirm.

[7]: /tracing/trace_explorer/trace_view/
[8]: https://github.com/DataDog/opentelemetry-examples/blob/main/apps/rest-services/golang/calendar/main.go#L133
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line changed since we last updated this example, I'd recommend to use a pinned version of the repo when linking lines of code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for taking a look!

@brett0000FF brett0000FF requested a review from a team April 21, 2025 19:52
@brett0000FF
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
dd-devflow bot commented Apr 23, 2025

View all feedbacks in Devflow UI.

2025-04-23 22:28:24 UTC ℹ️ Start processing command /merge


2025-04-23 22:28:28 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 19m (p90).


2025-04-23 22:45:13 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 3326ae1 into master Apr 23, 2025
14 of 16 checks passed
@dd-mergequeue dd-mergequeue bot deleted the brett.blue/DOCS-8146 branch April 23, 2025 22:45
estherk15 pushed a commit that referenced this pull request May 8, 2025
* Add more info for correlating trace and container metrics.

* Update content/en/opentelemetry/integrations/docker_metrics.md

Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com>

* Remove link to specific line.

* Rework this to remove USM.

* Add back mention of UST.

---------

Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0