-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add more info on correlating trace and container metrics #28870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@liustanley - Hey! I think we chatted about this a while back. Could you please help me verify the technical accuracy of this content I added? Thanks! |
Preview links (active after the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Brett,
I added a small edit, but otherwise, all set to merge :)
Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I might not have the latest context on this so it might be worth asking the USM team to confirm.
[7]: /tracing/trace_explorer/trace_view/ | ||
[8]: https://github.com/DataDog/opentelemetry-examples/blob/main/apps/rest-services/golang/calendar/main.go#L133 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line changed since we last updated this example, I'd recommend to use a pinned version of the repo when linking lines of code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thanks for taking a look!
…on into brett.blue/DOCS-8146
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
* Add more info for correlating trace and container metrics. * Update content/en/opentelemetry/integrations/docker_metrics.md Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com> * Remove link to specific line. * Rework this to remove USM. * Add back mention of UST. --------- Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com>
What does this PR do? What is the motivation?
container.id
is set.Merge instructions
Merge readiness:
For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the
<name>/<description>
convention and include the forward slash (/
). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
To have your PR automatically merged after it receives the required reviews, add the following PR comment:
Additional notes