8000 Update otel.md by mtoffl01 · Pull Request #28857 · DataDog/documentation · GitHub
[go: up one dir, main page]
Skip to content

Update otel.md #28857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2025
Merged

Update otel.md #28857

merged 2 commits into from
Apr 24, 2025

Conversation

mtoffl01
Copy link
Contributor

What does this PR do? What is the motivation?

Updates Go code snippet to a working example

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@mtoffl01 mtoffl01 requested a review from a team as a code owner April 18, 2025 14:14
iadjivon
iadjivon approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor
@iadjivon iadjivon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtoffl01
Copy link
Contributor Author

Thanks @iadjivon , are you able to merge on my behalf?

@iadjivon
Copy link
Contributor

/merge

@dd-devflow
Copy link
dd-devflow bot commented Apr 18, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-18 22:53:21 UTC ℹ️ Start processing command /merge

2025-04-18 22:53:26 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-04-19 02:54:04 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@iadjivon
Copy link
Contributor

/merge

@dd-devflow
Copy link
dd-devflow bot commented Apr 23, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-23 16:14:19 UTC ℹ️ Start processing command /merge

2025-04-23 16:14:25 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-04-23 20:15:09 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@iadjivon iadjivon self-requested a review April 23, 2025 16:20
@buraizu
Copy link
Contributor
buraizu commented Apr 24, 2025

Hi @iadjivon and @mtoffl01, this PR will never merge via the merge queue because the branch name doesn't follow the required naming convention mentioned here:
https://github.com/DataDog/documentation?tab=readme-ov-file#datadog-staff

I'll go ahead and merge this manually, since the merge queue is quiet now, but let me know if you have any questions!

@buraizu buraizu merged commit cbfc401 into master Apr 24, 2025
20 of 25 checks passed
@buraizu buraizu deleted the mtoffl01-patch-2 branch April 24, 2025 02:23
estherk15 pushed a commit that referenced this pull request May 8, 2025
@mtoffl01 @estherk15
Update otel.md (#28857)
4ccfe0a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iadjivon iadjivon iadjivon approved these changes

Assignees
No one assigned
Labels
mergequeue-status: removed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtoffl01 @iadjivon @buraizu
0