-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[error-tracking] Apply general doc update #28724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[error-tracking] Apply general doc update #28724
Conversation
- rule 3 (this rule is disabled): team:security | ||
- rule 4: service:foo | ||
|
||
The processing flow is as follows: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The processing flow is as follows: | |
The processing flow is as follows: |
In this section, it might be helpful to explain the result of the example given. In essence describe the diagram in words. (i.e. what is happening as the flow progresses and what is the end result for this specific event?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do that! I thought it's pretty clear, we used to have nothing.
Also do we need a proper designer to work on this schematic? I've heard from @meghanlo someone made the diagram we have in issue states.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I see! Think that the image and steps are wonderful additions. I think an explanation around it might help when users need to create their own steps to satisfy their use cases. Sort of like this explanation for workflows ( but less in-depth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Guillaume, thanks for these changes. I have made some small changes. Let me know what you think and if you have any questions.
Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com>
Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com>
Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com>
Co-authored-by: Ida Adjivon <65119712+iadjivon@users.noreply.github.com>
…modified the evaluation order content
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
/merge |
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
devflow unqueued this merge request: It did not become mergeable within the expected time |
Display only issues that have an AI generated fix available to quickly remediate problems. | ||
|
||
#### Teams filters | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also mention service owners here?
@@ -64,21 +100,19 @@ The lower part of the issue panel gives you the ability to navigate error sample | |||
|
|||
## Get alerted on new errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Get alerted on new errors | |
## Get alerted on new or impactful errors |
/merge |
View all feedbacks in Devflow UI.
The expected merge time in
|
Co-authored-by: iadjivon <65119712+iadjivon@users.noreply.github.com>
Miscellaneous doc updates of some Error Tracking pages:
📝 See gdoc for tracking