8000 Update GCP Service Extensions documentation by e-n-0 · Pull Request #28511 · DataDog/documentation · GitHub
[go: up one dir, main page]
Skip to content

Update GCP Service Extensions documentation #28511

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 24, 2025
Merged

Update GCP Service Extensions documentation #28511

merged 12 commits into from
Apr 24, 2025

Conversation

e-n-0
Copy link
Member
@e-n-0 e-n-0 commented Apr 1, 2025 •
edited
Loading

What does this PR do? What is the motivation?

  • Add a new tab for installation with Terraform scripts
  • Rework categories (specially environment variable configuration)
  • Reword for better understandability
  • Add a note about opened ports

Merge instructions

Merge readiness:

  • Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Apr 1, 2025

Preview links (active after the build_preview check completes)

Modified Files

@e-n-0 e-n-0 force-pushed the flavien/gcp-se-terraform-doc branch 3 times, most recently from 93dc471 to 9a44642 Compare April 3, 2025 11:45
@e-n-0 e-n-0 marked this pull request as ready for review April 3, 2025 12:02
@e-n-0 e-n-0 requested a review from a team as a code owner April 3, 2025 12:02
@estherk15 estherk15 added the editorial review Waiting on a more in-depth review label Apr 3, 2025
@estherk15
Copy link
Contributor

Created an Editorial Review card for documentation! https://datadoghq.atlassian.net/browse/DOCS-10554

domalessi
domalessi reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor
@domalessi domalessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@e-n-0 Did a first pass and left come feedback and suggestions. Give that a read-through and let me know if you have any questions. Also let me know when you'd like me to take a second look!

@e-n-0 e-n-0 requested a review from domalessi April 11, 2025 13:09
domalessi
domalessi reviewed Apr 11, 2025
View reviewed changes
Copy link
Contributor
@domalessi domalessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions and comments!

Most of the suggestions are just nit-picky things -- hopefully easy to review and commit if you're in agreement.

Biggest thing is some feedback on tweaking the Terraform instructions. I removed most of the headers and added numbered steps. I think this will be easier for users to follow. If you're in line, we'll just need to indent the code blocks so that they're properly justified with the numbered steps.

@e-n-0 e-n-0 force-pushed the flavien/gcp-se-terraform-doc branch from c8c6ecb to b1ca9e1 Compare April 23, 2025 15:31
@github-actions github-actions bot added the Architecture Everything related to the Doc backend label Apr 23, 2025
@e-n-0
Copy link
Member Author
67E6 e-n-0 commented Apr 24, 2025

/merge

@dd-devflow
Copy link
dd-devflow bot commented Apr 24, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-24 09:29:40 UTC ℹ️ Start processing command /merge

2025-04-24 09:29:44 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 19m (p90).

2025-04-24 09:48:31 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit bd488d8 into master Apr 24, 2025
16 of 18 checks passed
@dd-mergequeue dd-mergequeue bot deleted the flavien/gcp-se-terraform-doc branch April 24, 2025 09:48
@e-n-0 e-n-0 mentioned this pull request May 7, 2025
Merged
1 task
estherk15 pushed a commit that referenced this pull request May 8, 2025
@e-n-0 @domalessi @estherk15
Update GCP Service Extensions documentation (#28511)
c8b57ec 
Co-authored-by: domalessi <dominique.alessi@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domalessi domalessi domalessi approved these changes

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e-n-0 @estherk15 @domalessi
0