8000 Create new Code Origins doc page by sstonehill12 · Pull Request #28056 · DataDog/documentation · GitHub
[go: up one dir, main page]
Skip to content

Create new Code Origins doc page #28056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Apr 24, 2025
Merged

Create new Code Origins doc page #28056

merged 32 commits into from
Apr 24, 2025

Conversation

sstonehill12
Copy link
Contributor
@sstonehill12 sstonehill12 commented Mar 10, 2025 •
edited by tylfin
Loading

What does this PR do? What is the motivation?

Add new public docs page for Code Origins feature, and associated images.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@github-actions github-actions bot added the Guide Content impacting a guide label Mar 10, 2025
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Mar 10, 2025 •
edited
Loading

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

@sstonehill12 sstonehill12 added the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 10, 2025
@github-actions github-actions bot added the Images Images are added/removed with this PR label Mar 24, 2025
@sstonehill12 sstonehill12 removed the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 24, 2025
evanchooly
evanchooly requested changes Mar 25, 2025
View reviewed changes
@sstonehill12 sstonehill12 requested review from tylfin and shatzi March 25, 2025 14:01
tylfin
tylfin reviewed Mar 25, 2025
View reviewed changes
tylfin
tylfin reviewed Mar 25, 2025
View reviewed changes
tylfin
tylfin reviewed Mar 25, 2025
View reviewed changes
tylfin
tylfin reviewed Mar 25, 2025
View reviewed changes
tylfin
tylfin reviewed Mar 25, 2025
View reviewed changes
@tylfin
Copy link
Contributor
tylfin commented Mar 25, 2025

I generated some language suggestions feeding your changes with the RFC and CONTRIBUTING guide through an LLM. I thought these were generally good, but feel free to disregard them.

Also, the build preview is giving a 4xx because the CI is failing, but locally it runs just fine. I would try pulling the latest changes from the main branch and see if that helps 🤷

sstonehill12 and others added 7 commits March 25, 2025 15:02
@sstonehill12 @tylfin
Update content/en/tracing/guide/code_origins.md
e087ff8 
Update span type descriptions

Co-authored-by: Tyler Finethy <tyler.finethy@datadoghq.com>
@sstonehill12 @tylfin
Update overview content
7f80b92 
Co-authored-by: Tyler Finethy <tyler.finethy@datadoghq.com>
@sstonehill12 @tylfin
Update prerequisites section
fcb467c 
Co-authored-by: Tyler Finethy <tyler.finethy@datadoghq.com>
@sstonehill12 @tylfin
Update enable section
871b176 
Co-authored-by: Tyler Finethy <tyler.finethy@datadoghq.com>
@sstonehill12 @tylfin
Update troubleshooting section
c6fb954 
Co-authored-by: Tyler Finethy <tyler.finethy@datadoghq.com&g
10000
t;
@sstonehill12
Removed tracing library specific instructions, kept env variable inst…
b914636 
…ructions only
@sstonehill12
Merge branch 'master' into sarah.stonehill/code-origin-new-doc
f7ea517
OmerRaviv
OmerRaviv reviewed Apr 22, 2025
View reviewed changes
OmerRaviv
OmerRaviv reviewed Apr 22, 2025
View reviewed changes
OmerRaviv
OmerRaviv reviewed Apr 22, 2025
View reviewed changes
OmerRaviv
OmerRaviv approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor
@OmerRaviv OmerRaviv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few comments

sstonehill12
sstonehill12 commented Apr 22, 2025
View reviewed changes
sstonehill12 and others added 2 commits April 22, 2025 15:19
@sstonehill12 @OmerRaviv
Apply suggestions from code review
efe26e0 
Co-authored-by: Omer Raviv <omer.raviv@datadoghq.com>
@sstonehill12
Removed all exit span references, removed How it works and Impact on …
935e096 
…pricing and performance sections, added back IDE support references.
@sstonehill12
Copy link
Contributor Author

@domalessi Ready for a final look-through! Biggest changes to note:

  • Removed all mention of support for Exit Spans (we are still evaluating whether we will support this feature long-term).
  • Removed the "How it works" and "Impact on performance and pricing" sections (will add back after decision on exit spans).

sstonehill12
sstonehill12 commented Apr 22, 2025
View reviewed changes
@sstonehill12 sstonehill12 removed the WORK IN PROGRESS No review needed, it's a wip ;) label Apr 24, 2025
sstonehill12
sstonehill12 commented Apr 24, 2025
View reviewed changes
sstonehill12
sstonehill12 commented Apr 24, 2025
View reviewed changes
@sstonehill12
Copy link
Contributor Author

/merge

@dd-devflow
Copy link
dd-devflow bot commented Apr 24, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-04-24 03:05:41 UTC ℹ️ Start processing command /merge

2025-04-24 03:05:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-04-24 03:10:09 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in master is approximately 19m (p90).

2025-04-24 03:26:51 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 8b92d52 into master Apr 24, 2025
17 of 19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the sarah.stonehill/code-origin-new-doc branch April 24, 2025 03:26
estherk15 pushed a commit that referenced this pull request May 8, 2025
@sstonehill12 @tylfin @estherk15
Create new Code Origins doc page (#28056)
78488ac 
Co-authored-by: tylfin <tyler.finethy@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanchooly evanchooly evanchooly approved these changes

@OmerRaviv OmerRaviv OmerRaviv approved these changes

@tylfin tylfin tylfin approved these changes

@duviduduvid duviduduvid duviduduvid approved these changes

@domalessi domalessi domalessi approved these changes

@watson watson Awaiting requested review from watson

@P403n1x87 P403n1x87 Awaiting requested review from P403n1x87

@shatzi shatzi Awaiting requested review from shatzi

Assignees
No one assigned
Labels
Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review Guide Content impacting a guide Images Images are added/removed with this PR mergequeue-status: done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sstonehill12 @tylfin @cswatt @evanchooly @OmerRaviv @duviduduvid @domalessi
0