8000 Update Logs <> Traces correlation documentation for Opentelemetry by mtoffl01 · Pull Request #27884 · DataDog/documentation · GitHub
[go: up one dir, main page]
Skip to content

Update Logs <> Traces correlation documentation for Opentelemetry #27884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Update Logs <> Traces correlation documentation for Opentelemetry #27884

wants to merge 6 commits into from

Conversation

mtoffl01
Copy link
Contributor

What does this PR do? What is the motivation?

This PR removes any reference to mapping 128bit Otel trace IDs to Datadog 64bit trace IDs, while still maintaining instructions for mapping Otel span IDs to Datadog span IDs.
This documentation is outdated, as 128bit trace IDs have been supported in the Datadog logs backend [for correlating logs and traces] for quite some time.

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@mtoffl01 mtoffl01 requested a review from zacharycmontoya March 3, 2025 17:05
mabdinur
mabdinur approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor
@mabdinur mabdinur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a fix for python and a suggestion

@mtoffl01 mtoffl01 closed this Mar 19, 2025
@mtoffl01 mtoffl01 reopened this Mar 19, 2025
mhlidd
mhlidd approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor
@mhlidd mhlidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't able to replicate existing code... but I left a working way to inject the information

zacharycmontoya
zacharycmontoya approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor
@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for .NET

@mtoffl01 @mhlidd
Update content/en/tracing/other_telemetry/connect_logs_and_traces/ope…
6168724 
…ntelemetry.md

Co-authored-by: mhlidd <matthew.li@datadoghq.com>
@mtoffl01 mtoffl01 marked this pull request as ready for review April 17, 2025 17:59
@mtoffl01 mtoffl01 requested a review from a team as a code owner April 17, 2025 17:59
janine-c
janine-c requested changes Apr 17, 2025
View reviewed changes
Copy link
Contributor
@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Mikayla 👋🏻 We have some branch naming conventions that we need for our CI to ensure that your content is building properly. Could you please close this PR, rename your branch so it contains that weirdly load-bearing slash, and then create a new PR with that branch? That's usually the easiest way to kick off the automations that we need, and then we can approve and get this merged in for you.

Hope that makes sense, and apologies for the inconvenience!

@mtoffl01 mtoffl01 closed this Apr 25, 2025
@mtoffl01
Copy link
Contributor Author

Hey @janine-c , thanks for the feedback. new PR is up here: #28984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdinur mabdinur mabdinur approved these changes

@janine-c janine-c janine-c requested changes

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

@mhlidd mhlidd mhlidd approved these changes

@link04 link04 Awaiting requested review from link04

@khanayan123 khanayan123 Awaiting requested review from khanayan123

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mtoffl01 @zacharycmontoya @mabdinur @janine-c @mhlidd
0