10000 Andrew.rodriguez/dd service mapping by zARODz11z · Pull Request #18144 · DataDog/documentation · GitHub
[go: up one dir, main page]
Skip to content

Andrew.rodriguez/dd service mapping #18144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Jun 22, 2023
Merged

Andrew.rodriguez/dd service mapping #18144

merged 31 commits into from
Jun 22, 2023

Conversation

zARODz11z
Copy link
Contributor
@zARODz11z zARODz11z commented May 15, 2023 •
edited
Loading

What does this PR do?

Documents DD_SERVICE_MAPPING logic

Motivation

SLS-3501

Additional Notes

Reviewer checklist

  • Review the changed files.
  • Review the URLs listed in the Preview section.
  • Check images for PII
  • Review any mentions of "Contact Datadog support" for internal support documentation.

@zARODz11z zARODz11z requested review from a team as code owners May 15, 2023 21:45
@github-actions
Copy link
Contributor
github-actions bot commented May 15, 2023 •
edited
Loading

Preview links (active after the build_preview check completes)

Modified Files

@zARODz11z zARODz11z mentioned this pull request May 15, 2023
Merged
11 tasks
hestonhoffman
hestonhoffman reviewed May 15, 2023
View reviewed changes
@tianchu
Copy link
Contributor
tianchu commented May 16, 2023

@zARODz11z how about making DD_SERVICE_MAPPING a subsection of "collect traces from non-lambda resources"?

@zARODz11z zARODz11z mentioned this pull request May 16, 2023
Merged
11 tasks
@zARODz11z
Copy link
Contributor Author

how about making DD_SERVICE_MAPPING a subsection of "collect traces from non-lambda resources"?

@tianchu sounds good, if I understand correctly this just means appending another # to the section titles. Added in the new commit!

hestonhoffman
hestonhoffman approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor
@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zARODz11z
Copy link
Contributor Author

LGTM!

@hestonhoffman great let's hold off merging it for now until my other related prs are merged. I'll reach out if I need someone to hit the button for me.

@hestonhoffman
Copy link
Contributor

@zARODz11z No probs! Just give us a shout in #documentation when it's ready to merge.

@zARODz11z zARODz11z mentioned this pull request May 18, 2023
Merged
10 tasks
@zARODz11z zARODz11z requested review from duncanista and removed request for tianchu May 31, 2023 00:02
@cswatt cswatt merged commit c726c79 into master Jun 22, 2023
@cswatt cswatt deleted the andrew.rodriguez/DD_SERVICE_MAPPING branch June 22, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianchu tianchu tianchu approved these changes

@hestonhoffman hestonhoffman hestonhoffman approved these changes

@duncanista duncanista Awaiting requested review from duncanista

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zARODz11z @tianchu @hestonhoffman @cswatt
0