8000 Schema extraction with DD_APM_TRACING_ENABLED=false by estringana · Pull Request #3269 · DataDog/dd-trace-php · GitHub
[go: up one dir, main page]
Skip to content

Schema extraction with DD_APM_TRACING_ENABLED=false #3269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its m 8000 aintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 19, 2025
Merged

Schema extraction with DD_APM_TRACING_ENABLED=false #3269

merged 10 commits into from
Jun 19, 2025

Conversation

estringana
Copy link
Contributor
@estringana estringana commented May 27, 2025 •
edited by jira bot
Loading

Description

Generate schemas when the request has been picked by the sample even when standalone mode is on

[APPSEC-57339]

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link
codecov-commenter commented May 27, 8000 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.20%. Comparing base (7954d35) to head (d0a87b0).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
appsec/src/extension/commands_helpers.c 33.33% 2 Missing and 2 partials ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (7954d35) and HEAD (d0a87b0). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (7954d35) HEAD (d0a87b0)
tracer-php 24 11
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3269      +/-   ##
============================================
- Coverage     79.23%   73.20%   -6.04%     
  Complexity     2969     2969              
============================================
  Files           119      146      +27     
  Lines         11685    16126    +4441     
  Branches          0     1110    +1110     
============================================
+ Hits           9259    11805    +2546     
- Misses         2426     3744    +1318     
- Partials          0      577     +577
Flag Coverage Δ
appsec-extension 68.43% <33.33%> (?)
tracer-php 75.01% <ø> (-4.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appsec/src/extension/tags.c 80.45% <ø> (ø)
appsec/src/extension/commands_helpers.c 68.11% <33.33%> (ø)

... and 31 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7954d35...d0a87b0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
pr-commenter bot commented May 27, 2025 •
edited
Loading

Benchmarks [ appsec ]

Benchmark execution time: 2025-06-17 11:28:24

Comparing candidate commit 14964ea in PR branch estringana/standalone-schemas with baseline commit d8c3bb8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

@estringana estringana force-pushed the estringana/standalone-schemas branch from eec6696 to a0c2924 Compare May 28, 2025 13:39
@pr-commenter
Copy link
pr-commenter bot commented May 29, 2025 •
edited
Loading

Benchmarks [ tracer ]

Benchmark execution time: 2025-06-17 11:15:43

Comparing candidate commit 14964ea in PR branch estringana/standalone-schemas with baseline commit d8c3bb8 in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:BM_TeaSapiSpinup

  • 🟥 execution_time [+59.576µs; +141.485µs] or [+4.219%; +10.018%]

scenario:TraceFlushBench/benchFlushTrace

  • 🟥 execution_time [+1000.000ns; +1000.000ns] or [+100.000%; +100.000%]

@estringana estringana force-pushed the estringana/standalone-schemas branch from 631e75c to d61dea6 Compare May 29, 2025 10:50
@estringana estringana marked this pull request as ready for review May 30, 2025 14:53
@estringana estringana requested a review from a team as a code owner May 30, 2025 14:53
@estringana estringana force-pushed the estringana/standalone-schemas branch from f2a8e10 to d2f0df4 Compare May 30, 2025 15:10
Anilm3
Anilm3 reviewed Jun 5, 2025
View reviewed changes
Anilm3
Anilm3 reviewed Jun 5, 2025
View reviewed changes
cataphract
cataphract reviewed Jun 6, 2025
View reviewed changes
@estringana estringana requested a review from a team as a code owner June 13, 2025 08:45
Anilm3
Anilm3 reviewed Jun 16, 2025
View reviewed changes
@estringana estringana force-pushed the estringana/standalone-schemas branch from d0a87b0 to 54c0a9a Compare June 17, 2025 08:26
@estringana estringana merged commit aa58a2b into master Jun 19, 2025
1660 of 1768 checks passed
@estringana estringana deleted the estringana/standalone-schemas branch June 19, 2025 10:08
@github-actions github-actions bot added this to the 1.11.0 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cataphract cataphract cataphract left review comments

@daniel-romano-DD daniel-romano-DD daniel-romano-DD left review comments

@Anilm3 Anilm3 Anilm3 approved these changes

Assignees
No one assigned
Labels
area:asm tracing
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@estringana @codecov-commenter @cataphract @Anilm3 @daniel-romano-DD
0