Report config_id for Hands Off Config files#9299
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 04eca28 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.52.0-SNAPSHOT~04eca28ea7, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.051 s) : 0, 1051071
Total [baseline] (10.77 s) : 0, 10770011
Agent [candidate] (1.042 s) : 0, 1041992
Total [candidate] (7.526 s) : 0, 7525737
section appsec
Agent [baseline] (1.225 s) : 0, 1224584
Total [baseline] (10.782 s) : 0, 10782008
Agent [candidate] (1.243 s) : 0, 1242894
Total [candidate] (10.837 s) : 0, 10836830
section iast
Agent [baseline] (1.179 s) : 0, 1178742
Total [baseline] (10.93 s) : 0, 10930187
Agent [candidate] (1.186 s) : 0, 1185703
Total [candidate] (11.041 s) : 0, 11041406
section profiling
Agent [baseline] (1.199 s) : 0, 1198788
Total [baseline] (10.977 s) : 0, 10976546
Agent [candidate] (1.204 s) : 0, 1203633
Total [candidate] (10.989 s) : 0, 10989116
gantt
title petclinic - break down per module: candidate=1.52.0-SNAPSHOT~04eca28ea7, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (734.096 ms) : 0, 734096
BytebuddyAgent [candidate] (728.87 ms) : 0, 728870
GlobalTracer [baseline] (243.595 ms) : 0, 243595
GlobalTracer [candidate] (241.993 ms) : 0, 241993
AppSec [baseline] (30.165 ms) : 0, 30165
AppSec [candidate] (30.039 ms) : 0, 30039
Debugger [baseline] (6.057 ms) : 0, 6057
Debugger [candidate] (6.021 ms) : 0, 6021
Remote Config [baseline] (669.942 µs) : 0, 670
Remote Config [candidate] (654.617 µs) : 0, 655
Telemetry [baseline] (13.88 ms) : 0, 13880
Telemetry [candidate] (11.974 ms) : 0, 11974
section appsec
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (756.162 ms) : 0, 756162
BytebuddyAgent [candidate] (767.73 ms) : 0, 767730
GlobalTracer [baseline] (235.701 ms) : 0, 235701
GlobalTracer [candidate] (239.456 ms) : 0, 239456
IAST [baseline] (23.521 ms) : 0, 23521
IAST [candidate] (24.112 ms) : 0, 24112
AppSec [baseline] (169.515 ms) : 0, 169515
AppSec [candidate] (172.744 ms) : 0, 172744
Debugger [baseline] (6.495 ms) : 0, 6495
Debugger [candidate] (5.871 ms) : 0, 5871
Remote Config [baseline] (634.368 µs) : 0, 634
Remote Config [candidate] (671.114 µs) : 0, 671
Telemetry [baseline] (9.926 ms) : 0, 9926
Telemetry [candidate] (9.332 ms) : 0, 9332
section iast
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (850.587 ms) : 0, 850587
BytebuddyAgent [candidate] (854.964 ms) : 0, 854964
GlobalTracer [baseline] (233.326 ms) : 0, 233326
GlobalTracer [candidate] (234.841 ms) : 0, 234841
IAST [baseline] (31.914 ms) : 0, 31914
IAST [candidate] (30.607 ms) : 0, 30607
AppSec [baseline] (25.806 ms) : 0, 25806
AppSec [candidate] (26.935 ms) : 0, 26935
Debugger [baseline] (5.736 ms) : 0, 5736
Debugger [candidate] (6.649 ms) : 0, 6649
Remote Config [baseline] (594.975 µs) : 0, 595
Remote Config [candidate] (613.715 µs) : 0, 614
Telemetry [baseline] (8.265 ms) : 0, 8265
Telemetry [candidate] (8.342 ms) : 0, 8342
section profiling
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.434 ms) : 0, 1434
BytebuddyAgent [baseline] (763.777 ms) : 0, 763777
BytebuddyAgent [candidate] (766.398 ms) : 0, 766398
GlobalTracer [baseline] (222.284 ms) : 0, 222284
GlobalTracer [candidate] (223.504 ms) : 0, 223504
AppSec [baseline] (30.107 ms) : 0, 30107
AppSec [candidate] (30.146 ms) : 0, 30146
Debugger [baseline] (6.267 ms) : 0, 6267
Debugger [candidate] (6.344 ms) : 0, 6344
Remote Config [baseline] (766.427 µs) : 0, 766
Remote Config [candidate] (737.162 µs) : 0, 737
Telemetry [baseline] (16.377 ms) : 0, 16377
Telemetry [candidate] (16.342 ms) : 0, 16342
ProfilingAgent [baseline] (107.974 ms) : 0, 107974
ProfilingAgent [candidate] (108.771 ms) : 0, 108771
Profiling [baseline] (108.637 ms) : 0, 108637
Profiling [candidate] (109.431 ms) : 0, 109431
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.52.0-SNAPSHOT~04eca28ea7, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050182
Total [baseline] (8.621 s) : 0, 8620534
Agent [candidate] (1.048 s) : 0, 1048462
Total [candidate] (8.618 s) : 0, 8617898
section iast
Agent [baseline] (1.191 s) : 0, 1190672
Total [baseline] (9.354 s) : 0, 9354251
Agent [candidate] (1.189 s) : 0, 1188717
Total [candidate] (9.347 s) : 0, 9346779
gantt
title insecure-bank - break down per module: candidate=1.52.0-SNAPSHOT~04eca28ea7, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (734.421 ms) : 0, 734421
BytebuddyAgent [candidate] (733.662 ms) : 0, 733662
GlobalTracer [baseline] (243.151 ms) : 0, 243151
GlobalTracer [candidate] (243.025 ms) : 0, 243025
AppSec [baseline] (30.138 ms) : 0, 30138
AppSec [candidate] (30.207 ms) : 0, 30207
Debugger [baseline] (6.114 ms) : 0, 6114
Debugger [candidate] (6.079 ms) : 0, 6079
Remote Config [baseline] (676.908 µs) : 0, 677
Remote Config [candidate] (681.122 µs) : 0, 681
Telemetry [baseline] (13.171 ms) : 0, 13171
Telemetry [candidate] (12.311 ms) : 0, 12311
section iast
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (858.26 ms) : 0, 858260
BytebuddyAgent [candidate] (857.857 ms) : 0, 857857
GlobalTracer [baseline] (235.692 ms) : 0, 235692
GlobalTracer [candidate] (235.715 ms) : 0, 235715
AppSec [baseline] (29.883 ms) : 0, 29883
AppSec [candidate] (27.885 ms) : 0, 27885
Debugger [baseline] (5.893 ms) : 0, 5893
Debugger [candidate] (7.433 ms) : 0, 7433
Remote Config [baseline] (614.597 µs) : 0, 615
Remote Config [candidate] (604.806 µs) : 0, 605
Telemetry [baseline] (8.546 ms) : 0, 8546
Telemetry [candidate] (8.354 ms) : 0, 8354
IAST [baseline] (29.015 ms) : 0, 29015
IAST [candidate] (28.23 ms) : 0, 28230
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~04eca28ea7, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section baseline
no_agent (4.342 ms) : 4292, 4393
. : milestone, 4342,
iast (9.036 ms) : 8888, 9183
. : milestone, 9036,
iast_FULL (13.915 ms) : 13645, 14185
. : milestone, 13915,
iast_GLOBAL (10.096 ms) : 9922, 10270
. : milestone, 10096,
profiling (8.742 ms) : 8595, 8889
. : milestone, 8742,
tracing (7.953 ms) : 7842, 8065
. : milestone, 7953,
section candidate
no_agent (4.289 ms) : 4240, 4338
. : milestone, 4289,
iast (9.264 ms) : 9111, 9417
. : milestone, 9264,
iast_FULL (14.158 ms) : 13875, 14442
. : milestone, 14158,
iast_GLOBAL (10.429 ms) : 10245, 10613
. : milestone, 10429,
profiling (8.808 ms) : 8670, 8946
. : milestone, 8808,
tracing (7.757 ms) : 7647, 7867
. : milestone, 7757,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.52.0-SNAPSHOT~04eca28ea7, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section baseline
no_agent (37.11 ms) : 36812, 37408
. : milestone, 37110,
appsec (48.058 ms) : 47612, 48503
. : milestone, 48058,
code_origins (44.851 ms) : 44462, 45240
. : milestone, 44851,
iast (44.537 ms) : 44150, 44923
. : milestone, 44537,
profiling (47.897 ms) : 47412, 48382
. : milestone, 47897,
tracing (45.49 ms) : 45116, 45864
. : milestone, 45490,
section candidate
no_agent (36.555 ms) : 36259, 36851
. : milestone, 36555,
appsec (47.882 ms) : 47456, 48308
. : milestone, 47882,
code_origins (45.389 ms) : 44997, 45781
. : milestone, 45389,
iast (44.219 ms) : 43838, 44600
. : milestone, 44219,
profiling (50.3 ms) : 49842, 50759
. : milestone, 50300,
tracing (42.299 ms) : 41939, 42659
. : milestone, 42299,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~04eca28ea7, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.61 ms) : 3396, 3823
. : milestone, 3610,
iast (2.209 ms) : 2146, 2273
. : milestone, 2209,
iast_GLOBAL (2.252 ms) : 2188, 2316
. : milestone, 2252,
profiling (2.501 ms) : 2332, 2670
. : milestone, 2501,
tracing (2.032 ms) : 1983, 2082
. : milestone, 2032,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.664 ms) : 3446, 3882
. : milestone, 3664,
iast (2.216 ms) : 2153, 2280
. : milestone, 2216,
iast_GLOBAL (2.252 ms) : 2188, 2315
. : milestone, 2252,
profiling (2.056 ms) : 2004, 2107
. : milestone, 2056,
tracing (2.036 ms) : 1986, 2086
. : milestone, 2036,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.52.0-SNAPSHOT~04eca28ea7, baseline=1.53.0-SNAPSHOT~9aad75597f
dateFormat X
axisFormat %s
section baseline
no_agent (15.074 s) : 15074000, 15074000
. : milestone, 15074000,
appsec (14.978 s) : 14978000, 14978000
. : milestone, 14978000,
iast (18.102 s) : 18102000, 18102000
. : milestone, 18102000,
iast_GLOBAL (18.148 s) : 18148000, 18148000
. : milestone, 18148000,
profiling (16.004 s) : 16004000, 16004000
. : milestone, 16004000,
tracing (14.911 s) : 14911000, 14911000
. : milestone, 14911000,
section candidate
no_agent (15.724 s) : 15724000, 15724000
. : milestone, 15724000,
appsec (14.903 s) : 14903000, 14903000
. : milestone, 14903000,
iast (18.419 s) : 18419000, 18419000
. : milestone, 18419000,
iast_GLOBAL (18.006 s) : 18006000, 18006000
. : milestone, 18006000,
profiling (15.941 s) : 15941000, 15941000
. : milestone, 15941000,
tracing (15.114 s) : 15114000, 15114000
. : milestone, 15114000,
|
…va into mtoff/scfg_config-id
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
There was a problem hiding this comment.
Started reviewing because I thought this PR was related to Config sources... but had a question regardless
internal-api/src/main/java/datadog/trace/bootstrap/config/provider/ConfigProvider.java
Outdated
Show resolved
Hide resolved
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.52.1` -> `1.53.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.53.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.53.0): 1.53.0 ### Components #### Application Security Management (WAF) - 🐛 Fix NullPointerException log in AppSec ([#​9355](DataDog/dd-trace-java#9355) - [@​jandro996](https://github.com/jandro996)) - ✨ Add Forwarded header as a source to client IP resolution ([#​9310](DataDog/dd-trace-java#9310) - [@​jandro996](https://github.com/jandro996)) #### Build & Tooling - 📖 Update CODEOWNERS ([#​9294](DataDog/dd-trace-java#9294) - [@​mhlidd](https://github.com/mhlidd)) - ✨ Add dependency on Maven Central deployment to OCI publish jobs ([#​9204](DataDog/dd-trace-java#9204) - [@​sarahchen6](https://github.com/sarahchen6)) #### Continuous Integration Visibility - ✨ Upload code coverage reports to Datadog ([#​9425](DataDog/dd-trace-java#9425) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Do not follow symlinks by default when building repository index ([#​9318](DataDog/dd-trace-java#9318) - [@​nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Improve tag propagation between test event levels ([#​9278](DataDog/dd-trace-java#9278) - [@​daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - ✨ Create container hash tags propagation ([#​9282](DataDog/dd-trace-java#9282) - [@​ygree](https://github.com/ygree)) #### Database Monitoring - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#​9321](DataDog/dd-trace-java#9321) - [@​na-ji](https://github.com/na-ji)) - ✨ Create container hash tags propagation ([#​9282](DataDog/dd-trace-java#9282) - [@​ygree](https://github.com/ygree)) #### GraalVM native-image - 🐛 Update GraalVM config to reflect TempLocationManager's new package ([#​9337](DataDog/dd-trace-java#9337) - [@​luneo7](https://github.com/luneo7) - thanks for the contribution!) #### Metrics - 🐛 Add reflect config for CSS and graalvm ([#​9449](DataDog/dd-trace-java#9449) - [@​amarziali](https://github.com/amarziali)) - ✨ Align CSS health metrics ([#​9444](DataDog/dd-trace-java#9444) - [@​amarziali](https://github.com/amarziali)) - ✨ Aggregate peer tags for consumer span kind ([#​9442](DataDog/dd-trace-java#9442) - [@​amarziali](https://github.com/amarziali)) - ✨ Implement health metrics for client stats ([#​9377](DataDog/dd-trace-java#9377) - [@​amarziali](https://github.com/amarziali)) - ✨ Add peer tags, span kind and trace root flag to MetricKey bucket ([#​9178](DataDog/dd-trace-java#9178) - [@​bric3](https://github.com/bric3)) #### Profiling - ✨ Create a profile flare reporter (requires tracing or CI vis to be enabled) ([#​9433](DataDog/dd-trace-java#9433) - [@​MattAlp](https://github.com/MattAlp)) - 🐛 Properly fall-back on UDS profiling URL ([#​9401](DataDog/dd-trace-java#9401) - [@​jbachorik](https://github.com/jbachorik)) - 🐛 Properly handle trace agent IPv6 URL in profiling ([#​9334](DataDog/dd-trace-java#9334) - [@​jbachorik](https://github.com/jbachorik)) #### Realtime User Monitoring - 🐛 Avoid multiple injections on dispatch on jboss ([#​9392](DataDog/dd-trace-java#9392) - [@​amarziali](https://github.com/amarziali)) - ✨ Support async servlet for RUM injection ([#​9333](DataDog/dd-trace-java#9333) - [@​amarziali](https://github.com/amarziali)) - 🐛 Improve RUM injection matching and avoid truncating responses ([#​9323](DataDog/dd-trace-java#9323) - [@​amarziali](https://github.com/amarziali)) - 💡 Add telemetry for the RUM injector ([#​9267](DataDog/dd-trace-java#9267) - [@​sarahchen6](https://github.com/sarahchen6)) - ✨ Make rum injector stream/writer more resilient to errors ([#​9184](DataDog/dd-trace-java#9184) - [@​amarziali](https://github.com/amarziali)) #### Telemetry - 🐛 Remediate error logs ([#​9459](DataDog/dd-trace-java#9459) - [@​ygree](https://github.com/ygree)) - ✨ Report config\_id for Hands Off Config files ([#​9299](DataDog/dd-trace-java#9299) - [@​mtoffl01](https://github.com/mtoffl01)) - ✨ Adding Config Inversion Telemetry component ([#​9244](DataDog/dd-trace-java#9244) - [@​mhlidd](https://github.com/mhlidd)) #### Trace context propagation - 🧹 Migrate instrumentations to Context API ([#​9384](DataDog/dd-trace-java#9384), [#​9378](DataDog/dd-trace-java#9378), [#​9358](DataDog/dd-trace-java#9358) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🔍 Add baggage propagation telemetry ([#​9289](DataDog/dd-trace-java#9289) - [@​rachelyangdog](https://github.com/rachelyangdog)) - 🧹 Improve Instrumenter API to use Context instead of Span ([#​9211](DataDog/dd-trace-java#9211) - [@​PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - 💡:test\_tube: Enable process level tags for java 21 applications ([#​9458](DataDog/dd-trace-java#9458) - [@​amarziali](https://github.com/amarziali)) - ✨ Move base and peer service adder before span is published ([#​9408](DataDog/dd-trace-java#9408) - [@​amarziali](https://github.com/amarziali)) - ✨ Add ErrorPriorities level for manual instrumentation ([#​9387](DataDog/dd-trace-java#9387) - [@​cecile75](https://github.com/cecile75)) - ✨ Throw InvalidBooleanValueException in ConfigConverter.booleanValueOf ([#​9370](DataDog/dd-trace-java#9370) - [@​mtoffl01](https://github.com/mtoffl01)) - 🐛 Avoid NPE on featureDiscovery creation ([#​9353](DataDog/dd-trace-java#9353) - [@​amarziali](https://github.com/amarziali)) - ✨ Stable Config improvements ([#​9259](DataDog/dd-trace-java#9259) - [@​mtoffl01](https://github.com/mtoffl01)) ### Instrumentations #### gRPC instrumentation - 🐛 Changing GRPC instrumentation codes from `status.code` to `grpc.status.code` ([#​9367](DataDog/dd-trace-java#9367) - [@​mhlidd](https://github.com/mhlidd)) #### JDBC instrumentation - 🐛 Prevent crash in SQL Server's JDBC when tracing execute methods with generated keys ([#​9321](DataDog/dd-trace-java#9321) - [@​na-ji](https://github.com/na-ji)) #### Kotlin instrumentation - 🐛 Take defensive copy of original scope stack when restoring on different thread ([#​9403](DataDog/dd-trace-java#9403) - [@​mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Fix using SpanAttribute annotation on multiple parameters ([#​9412](DataDog/dd-trace-java#9412) - [@​cecile75](https://github.com/cecile75)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e23ec866cef91afc6b5226d5f0dc7da538d947e8
What Does This Do
Reports config_id in configuration telemetry payloads when the origin is a stable config file.
Passing system tests: DataDog/system-tests#5062
Motivation
https://datadoghq.atlassian.net/browse/APMAPI-1354
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]