8000 Ignore mise and asdf configuration files by bric3 · Pull Request #9108 · DataDog/dd-trace-java · GitHub
[go: up one dir, main page]
Skip to content

Ignore mise and asdf configuration files#9108

Merged
bric3 merged 1 commit intomasterfrom
bdu/ignore-asdf-mise
Jul 8, 2025
Merged

Ignore mise and asdf configuration files#9108
bric3 merged 1 commit intomasterfrom
bdu/ignore-asdf-mise

Conversation

@bric3
Copy link
Contributor
@bric3 bric3 commented Jul 4, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@bric3 bric3 requested a review from a team as a code owner July 4, 2025 16:10
@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jul 4, 2025
@bric3 bric3 requested a review from amarziali July 4, 2025 16:10
@pr-commenter
Copy link
pr-commenter bot commented Jul 4, 2025 •
edited
Loading

Benchmarks

Startup

Parameters
Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bdu/ignore-asdf-mise
git_commit_date 1751890694 1751895237
git_commit_sha 796bf33 14ccb1a
release_version 1.51.0-SNAPSHOT~796bf33ae2 1.51.0-SNAPSHOT~14ccb1acc1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1751897170 1751897170
ci_job_id 1016001982 1016001982
ci_pipeline_id 69775078 69775078
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-wfzxntpz 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-wfzxntpz 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 45 metrics, 8 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (997.21 ms) : 0, 997210
Total [baseline] (10.77 s) : 0, 10769928
Agent [candidate] (995.075 ms) : 0, 995075
Total [candidate] (10.731 s) : 0, 10731288
section appsec
Agent [baseline] (1.171 s) : 0, 1171350
Total [baseline] (10.738 s) : 0, 10737599
Agent [candidate] (1.175 s) : 0, 1174529
Total [candidate] (10.748 s) : 0, 10748259
section iast
Agent [baseline] (1.134 s) : 0, 1133978
Total [baseline] (10.913 s) : 0, 10912705
Agent [candidate] (1.134 s) : 0, 1134388
Total [candidate] (10.843 s) : 0, 10843286
section profiling
Agent [baseline] (1.245 s) : 0, 1244727
Total [baseline] (10.918 s) : 0, 10918159
Agent [candidate] (1.245 s) : 0, 1244852
Total [candidate] (10.91 s) : 0, 10910156
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 997.21 ms -
Agent appsec 1.171 s 174.14 ms (17.5%)
Agent iast 1.134 s 136.769 ms (13.7%)
Agent profiling 1.245 s 247.517 ms (24.8%)
Total tracing 10.77 s -
Total appsec 10.738 s -32.329 ms (-0.3%)
Total iast 10.913 s 142.777 ms (1.3%)
Total profiling 10.918 s 148.231 ms (1.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 995.075 ms -
Agent appsec 1.175 s 179.455 ms (18.0%)
Agent iast 1.134 s 139.314 ms (14.0%)
Agent profiling 1.245 s 249.777 ms (25.1%)
Total tracing 10.731 s -
Total appsec 10.748 s 16.971 ms (0.2%)
Total iast 10.843 s 111.998 ms (1.0%)
Total profiling 10.91 s 178.868 ms (1.7%) 
gantt
    title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.418 ms) : 0, 687418
BytebuddyAgent [candidate] (686.531 ms) : 0, 686531
GlobalTracer [baseline] (243.474 ms) : 0, 243474
GlobalTracer [candidate] (242.544 ms) : 0, 242544
AppSec [baseline] (30.495 ms) : 0, 30495
AppSec [candidate] (30.305 ms) : 0, 30305
Debugger [baseline] (6.11 ms) : 0, 6110
Debugger [candidate] (6.035 ms) : 0, 6035
Remote Config [baseline] (685.412 µs) : 0, 685
Remote Config [candidate] (681.036 µs) : 0, 681
Telemetry [baseline] (8.248 ms) : 0, 8248
Telemetry [candidate] (8.191 ms) : 0, 8191
section appsec
BytebuddyAgent [baseline] (708.428 ms) : 0, 708428
BytebuddyAgent [candidate] (709.888 ms) : 0, 709888
GlobalTracer [baseline] (234.753 ms) : 0, 234753
GlobalTracer [candidate] (235.334 ms) : 0, 235334
AppSec [baseline] (169.897 ms) : 0, 169897
AppSec [candidate] (170.809 ms) : 0, 170809
Debugger [baseline] (5.752 ms) : 0, 5752
Debugger [candidate] (5.752 ms) : 0, 5752
Remote Config [baseline] (609.044 µs) : 0, 609
Remote Config [candidate] (605.718 µs) : 0, 606
Telemetry [baseline] (8.044 ms) : 0, 8044
Telemetry [candidate] (8.027 ms) : 0, 8027
IAST [baseline] (23.059 ms) : 0, 23059
IAST [candidate] (23.241 ms) : 0, 23241
section iast
BytebuddyAgent [baseline] (807.681 ms) : 0, 807681
BytebuddyAgent [candidate] (808.397 ms) : 0, 808397
GlobalTracer [baseline] (232.997 ms) : 0, 232997
GlobalTracer [candidate] (233.615 ms) : 0, 233615
AppSec [baseline] (29.282 ms) : 0, 29282
AppSec [candidate] (27.769 ms) : 0, 27769
Debugger [baseline] (6.69 ms) : 0, 6690
Debugger [candidate] (5.861 ms) : 0, 5861
Remote Config [baseline] (594.127 µs) : 0, 594
Remote Config [candidate] (594.654 µs) : 0, 595
Telemetry [baseline] (8.114 ms) : 0, 8114
Telemetry [candidate] (8.024 ms) : 0, 8024
IAST [baseline] (27.85 ms) : 0, 27850
IAST [candidate] (29.354 ms) : 0, 29354
section profiling
ProfilingAgent [baseline] (103.228 ms) : 0, 103228
ProfilingAgent [candidate] (103.533 ms) : 0, 103533
BytebuddyAgent [baseline] (677.825 ms) : 0, 677825
BytebuddyAgent [candidate] (677.615 ms) : 0, 677615
GlobalTracer [baseline] (361.961 ms) : 0, 361961
GlobalTracer [candidate] (361.693 ms) : 0, 361693
AppSec [baseline] (30.991 ms) : 0, 30991
AppSec [candidate] (31.75 ms) : 0, 31750
Debugger [baseline] (13.602 ms) : 0, 13602
Debugger [candidate] (12.367 ms) : 0, 12367
Remote Config [baseline] (656.201 µs) : 0, 656
Remote Config [candidate] (665.54 µs) : 0, 666
Telemetry [baseline] (8.046 ms) : 0, 8046
Telemetry [candidate] (8.771 ms) : 0, 8771
Profiling [baseline] (103.252 ms) : 0, 103252
Profiling [candidate] (103.557 ms) : 0, 103557
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (998.526 ms) : 0, 998526
Total [baseline] (8.656 s) : 0, 8655590
Agent [candidate] (990.592 ms) : 0, 990592
Total [candidate] (8.576 s) : 0, 8576305
section iast
Agent [baseline] (1.131 s) : 0, 1131268
Total [baseline] (9.271 s) : 0, 9270951
Agent [candidate] (1.132 s) : 0, 1132311
Total [candidate] (9.261 s) : 0, 9260765
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 998.526 ms -
Agent iast 1.131 s 132.743 ms (13.3%)
Total tracing 8.656 s -
Total iast 9.271 s 615.36 ms (7.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 990.592 ms -
Agent iast 1.132 s 141.719 ms (14.3%)
Total tracing 8.576 s -
Total iast 9.261 s 684.46 ms (8.0%) 
gantt
    title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (690.875 ms) : 0, 690875
BytebuddyAgent [candidate] (684.104 ms) : 0, 684104
GlobalTracer [baseline] (241.681 ms) : 0, 241681
GlobalTracer [candidate] (240.619 ms) : 0, 240619
AppSec [baseline] (30.196 ms) : 0, 30196
AppSec [candidate] (30.117 ms) : 0, 30117
Debugger [baseline] (6.099 ms) : 0, 6099
Debugger [candidate] (6.005 ms) : 0, 6005
Remote Config [baseline] (675.694 µs) : 0, 676
Remote Config [candidate] (679.802 µs) : 0, 680
Telemetry [baseline] (8.158 ms) : 0, 8158
Telemetry [candidate] (8.261 ms) : 0, 8261
section iast
BytebuddyAgent [baseline] (806.578 ms) : 0, 806578
BytebuddyAgent [candidate] (806.701 ms) : 0, 806701
GlobalTracer [baseline] (232.486 ms) : 0, 232486
GlobalTracer [candidate] (232.762 ms) : 0, 232762
AppSec [baseline] (28.487 ms) : 0, 28487
AppSec [candidate] (29.663 ms) : 0, 29663
Debugger [baseline] (5.854 ms) : 0, 5854
Debugger [candidate] (5.81 ms) : 0, 5810
Remote Config [baseline] (586.984 µs) : 0, 587
Remote Config [candidate] (581.484 µs) : 0, 581
Telemetry [baseline] (7.984 ms) : 0, 7984
Telemetry [candidate] (7.971 ms) : 0, 7971
IAST [baseline] (28.473 ms) : 0, 28473
IAST [candidate] (28.042 ms) : 0, 28042
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bdu/ignore-asdf-mise
git_commit_date 1751890694 1751895237
git_commit_sha 796bf33 14ccb1a
release_version 1.51.0-SNAPSHOT~796bf33ae2 1.51.0-SNAPSHOT~14ccb1acc1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1751896723 1751896723
ci_job_id 1016001984 1016001984
ci_pipeline_id 69775078 69775078
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-zi2fp7sk 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-zi2fp7sk 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 5 performance improvements and 1 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:iast:high_load better
[-558.474µs; -223.446µs] or [-5.778%; -2.312%]		 unstable
[-40.612op/s; +80.924op/s] or [-8.453%; +16.843%]		 9.274ms 500.625op/s 9.665ms 480.469op/s
scenario:load:insecure-bank: 8000 profiling:high_load better
[-576.195µs; -271.314µs] or [-6.499%; -3.060%]		 unstable
[-46.061op/s; +98.186op/s] or [-8.802%; +18.762%]		 8.443ms 549.375op/s 8.866ms 523.312op/s
scenario:load:insecure-bank:tracing:high_load better
[-505.246µs; -258.515µs] or [-6.353%; -3.251%]		 unstable
[-50.345op/s; +108.470op/s] or [-8.641%; +18.616%]		 7.571ms 611.719op/s 7.952ms 582.656op/s
scenario:load:petclinic:tracing:high_load better
[-2.416ms; -1.630ms] or [-5.461%; -3.683%]		 unstable
[-2.649op/s; +12.724op/s] or [-2.504%; +12.029%]		 42.224ms 110.812op/s 44.247ms 105.775op/s
scenario:load:petclinic:appsec:high_load worse
[+1.291ms; +2.221ms] or [+2.743%; +4.720%]		 unstable
[-10.572op/s; +3.447op/s] or [-10.633%; +3.467%]		 48.819ms 95.862op/s 47.063ms 99.425op/s
scenario:load:petclinic:profiling:high_load better
[-2.493ms; -1.423ms] or [-4.916%; -2.806%]		 unstable
[-3.641op/s; +11.091op/s] or [-3.945%; +12.018%]		 48.763ms 96.013op/s 50.721ms 92.287op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.565 ms) : 36268, 36862
.   : milestone, 36565,
appsec (47.063 ms) : 46646, 47480
.   : milestone, 47063,
code_origins (44.193 ms) : 43813, 44573
.   : milestone, 44193,
iast (44.374 ms) : 43980, 44768
.   : milestone, 44374,
profiling (50.721 ms) : 50201, 51241
.   : milestone, 50721,
tracing (44.247 ms) : 43872, 44621
.   : milestone, 44247,
section candidate
no_agent (36.159 ms) : 35865, 36453
.   : milestone, 36159,
appsec (48.819 ms) : 48372, 49266
.   : milestone, 48819,
code_origins (45.07 ms) : 44687, 45452
.   : milestone, 45070,
iast (44.772 ms) : 44377, 45166
.   : milestone, 44772,
profiling (48.763 ms) : 48289, 49236
.   : milestone, 48763,
tracing (42.224 ms) : 41868, 42580
.   : milestone, 42224,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.565 ms [36.268 ms, 36.862 ms] -
appsec 47.063 ms [46.646 ms, 47.48 ms] 10.498 ms (28.7%)
code_origins 44.193 ms [43.813 ms, 44.573 ms] 7.628 ms (20.9%)
iast 44.374 ms [43.98 ms, 44.768 ms] 7.809 ms (21.4%)
profiling 50.721 ms [50.201 ms, 51.241 ms] 14.156 ms (38.7%)
tracing 44.247 ms [43.872 ms, 44.621 ms] 7.682 ms (21.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.159 ms [35.865 ms, 36.453 ms] -
appsec 48.819 ms [48.372 ms, 49.266 ms] 12.66 ms (35.0%)
code_origins 45.07 ms [44.687 ms, 45.452 ms] 8.911 ms (24.6%)
iast 44.772 ms [44.377 ms, 45.166 ms] 8.613 ms (23.8%)
profiling 48.763 ms [48.289 ms, 49.236 ms] 12.604 ms (34.9%)
tracing 42.224 ms [41.868 ms, 42.58 ms] 6.065 ms (16.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.44 ms) : 4390, 4490
.   : milestone, 4440,
iast (9.665 ms) : 9504, 9826
.   : milestone, 9665,
iast_FULL (13.9 ms) : 13624, 14176
.   : milestone, 13900,
iast_GLOBAL (10.344 ms) : 10160, 10528
.   : milestone, 10344,
profiling (8.866 ms) : 8725, 9008
.   : milestone, 8866,
tracing (7.952 ms) : 7832, 8073
.   : milestone, 7952,
section candidate
no_agent (4.333 ms) : 4285, 4381
.   : milestone, 4333,
iast (9.274 ms) : 9124, 9424
.   : milestone, 9274,
iast_FULL (14.064 ms) : 13787, 14341
.   : milestone, 14064,
iast_GLOBAL (10.413 ms) : 10229, 10596
.   : milestone, 10413,
profiling (8.443 ms) : 8300, 8585
.   : milestone, 8443,
tracing (7.571 ms) : 7462, 7679
.   : milestone, 7571,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.44 ms [4.39 ms, 4.49 ms] -
iast 9.665 ms [9.504 ms, 9.826 ms] 5.226 ms (117.7%)
iast_FULL 13.9 ms [13.624 ms, 14.176 ms] 9.46 ms (213.1%)
iast_GLOBAL 10.344 ms [10.16 ms, 10.528 ms] 5.905 ms (133.0%)
profiling 8.866 ms [8.725 ms, 9.008 ms] 4.427 ms (99.7%)
tracing 7.952 ms [7.832 ms, 8.073 ms] 3.513 ms (79.1%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.333 ms [4.285 ms, 4.381 ms] -
iast 9.274 ms [9.124 ms, 9.424 ms] 4.941 ms (114.0%)
iast_FULL 14.064 ms [13.787 ms, 14.341 ms] 9.731 ms (224.6%)
iast_GLOBAL 10.413 ms [10.229 ms, 10.596 ms] 6.079 ms (140.3%)
profiling 8.443 ms [8.3 ms, 8.585 ms] 4.109 ms (94.8%)
tracing 7.571 ms [7.462 ms, 7.679 ms] 3.237 ms (74.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bdu/ignore-asdf-mise
git_commit_date 1751890694 1751895237
git_commit_sha 796bf33 14ccb1a
release_version 1.51.0-SNAPSHOT~796bf33ae2 1.51.0-SNAPSHOT~14ccb1acc1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1751897317 1751897317
ci_job_id 1016001986 1016001986
ci_pipeline_id 69775078 69775078
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-9skjgw3r 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-9skjgw3r 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.009 s) : 15009000, 15009000
.   : milestone, 15009000,
appsec (14.789 s) : 14789000, 14789000
.   : milestone, 14789000,
iast (18.18 s) : 18180000, 18180000
.   : milestone, 18180000,
iast_GLOBAL (18.196 s) : 18196000, 18196000
.   : milestone, 18196000,
profiling (15.242 s) : 15242000, 15242000
.   : milestone, 15242000,
tracing (14.85 s) : 14850000, 14850000
.   : milestone, 14850000,
section candidate
no_agent (15.457 s) : 15457000, 15457000
.   : milestone, 15457000,
appsec (14.958 s) : 14958000, 14958000
.   : milestone, 14958000,
iast (18.556 s) : 18556000, 18556000
.   : milestone, 18556000,
iast_GLOBAL (18.175 s) : 18175000, 18175000
.   : milestone, 18175000,
profiling (15.019 s) : 15019000, 15019000
.   : milestone, 15019000,
tracing (14.822 s) : 14822000, 14822000
.   : milestone, 14822000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.009 s [15.009 s, 15.009 s] -
appsec 14.789 s [14.789 s, 14.789 s] -220.0 ms (-1.5%)
iast 18.18 s [18.18 s, 18.18 s] 3.171 s (21.1%)
iast_GLOBAL 18.196 s [18.196 s, 18.196 s] 3.187 s (21.2%)
profiling 15.242 s [15.242 s, 15.242 s] 233.0 ms (1.6%)
tracing 14.85 s [14.85 s, 14.85 s] -159.0 ms (-1.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.457 s [15.457 s, 15.457 s] -
appsec 14.958 s [14.958 s, 14.958 s] -499.0 ms (-3.2%)
iast 18.556 s [18.556 s, 18.556 s] 3.099 s (20.0%)
iast_GLOBAL 18.175 s [18.175 s, 18.175 s] 2.718 s (17.6%)
profiling 15.019 s [15.019 s, 15.019 s] -438.0 ms (-2.8%)
tracing 14.822 s [14.822 s, 14.822 s] -635.0 ms (-4.1%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~14ccb1acc1, baseline=1.51.0-SNAPSHOT~796bf33ae2
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
.   : milestone, 1471,
appsec (2.393 ms) : 2344, 2442
.   : milestone, 2393,
iast (2.182 ms) : 2120, 2244
.   : milestone, 2182,
iast_GLOBAL (2.219 ms) : 2157, 2281
.   : milestone, 2219,
profiling (2.05 ms) : 1999, 2101
.   : milestone, 2050,
tracing (2.001 ms) : 1953, 2049
.   : milestone, 2001,
section candidate
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.391 ms) : 2342, 2439
.   : milestone, 2391,
iast (2.18 ms) : 2118, 2242
.   : milestone, 2180,
iast_GLOBAL (2.228 ms) : 2166, 2290
.   : milestone, 2228,
profiling (2.033 ms) : 1983, 2083
.   : milestone, 2033,
tracing (1.999 ms) : 1951, 2047
.   : milestone, 1999,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.471 ms [1.459 ms, 1.482 ms] -
appsec 2.393 ms [2.344 ms, 2.442 ms] 922.513 µs (62.7%)
iast 2.182 ms [2.12 ms, 2.244 ms] 711.771 µs (48.4%)
iast_GLOBAL 2.219 ms [2.157 ms, 2.281 ms] 748.498 µs (50.9%)
profiling 2.05 ms [1.999 ms, 2.101 ms] 579.541 µs (39.4%)
tracing 2.001 ms [1.953 ms, 2.049 ms] 530.858 µs (36.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.47 ms [1.458 ms, 1.481 ms] -
appsec 2.391 ms [2.342 ms, 2.439 ms] 921.02 µs (62.7%)
iast 2.18 ms [2.118 ms, 2.242 ms] 710.43 µs (48.3%)
iast_GLOBAL 2.228 ms [2.166 ms, 2.29 ms] 758.345 µs (51.6%)
profiling 2.033 ms [1.983 ms, 2.083 ms] 563.637 µs (38.4%)
tracing 1.999 ms [1.951 ms, 2.047 ms] 529.615 µs (36.0%)

smola
smola reviewed Jul 7, 2025
View reviewed changes
.gitignore Outdated

# JDK provisioning tools #
# mise
mise.local.toml
Copy link
Member
@smola smola Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could also provide .config/mise.toml in the repo for easier setup? Can it setup JAVA_XX_HOME env vars?

Copy link
Contributor Author
@bric3 bric3 Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I never looked into that.

Copy link
Contributor
@PerfectSlayer PerfectSlayer Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we start adding custom config tool, we will end up having support for dozen of tools and not many people to maintain it :/

I would rather add support to install JDK from the setup scripts. Windows is already supported.
Linux and MacOS still needed. The tough part is to do it the more generic way without assuming nor requiring some specific tool.

Copy link
Contributor Author
@bric3 bric3 Jul 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis is very similar to any other env tool in many other languages.

I would rather add support to install JDK from the setup scripts.

My counterpoint is that setup script don;t manage JDK install well, other tools do that much better. For example the advantage of mise or asdf is they patch the PATH in the shell to the wanted JDK.

Also I wonder if we could leverage Gradle's JDK toolchain resolver (usually the foojay one), which hopefully don't preclude, other tools like mise or sdkman ?

Can it setup JAVA_XX_HOME env vars?

I believe it's possible, however, it won't work in IntelliJ, as IJ captures environment variables produces by your ~/.zshrc. What I do have in mine is

export JAVA_8_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/corretto-8
export JAVA_11_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/corretto-11
export JAVA_17_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/corretto-17
export JAVA_21_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/corretto-21
export JAVA_GRAALVM17_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/graalvm-community-17.0.9

Does are symlinks pointing to the latest installed JDK installed my mise.

FYI the mise configuration doc

Copy link
Contributor Author
@bric3 bric3 Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the point of using .gitignore, is that it will be available for any clone, and thus avoiding accidental commit.

@bric3 bric3 enabled auto-merge (squash) July 7, 2025 07:58
@bric3 bric3 disabled auto-merge July 7, 2025 07:59
PerfectSlayer
PerfectSlayer reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor
@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May an unpopular opinion but I would rather avoid adding many custom tools to the common ignore list.
If you have some specific file to exclude related to your setup, the .git/info/exclude seems more appropriate.

.gitignore Outdated

# JDK provisioning tools #
# mise
mise.local.toml
Copy link
Contributor
@PerfectSlayer PerfectSlayer Jul 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we start adding custom config tool, we will end up having support for dozen of tools and not many people to maintain it :/

I would rather add support to install JDK from the setup scripts. Windows is already supported.
Linux and MacOS still needed. The tough part is to do it the more generic way without assuming nor requiring some specific tool.

@bric3 bric3 force-pushed the bdu/ignore-asdf-mise branch from 9897ef9 to 14ccb1a Compare July 7, 2025 13:34
@bric3
Copy link
Contributor Author
bric3 commented Jul 8, 2025

@PerfectSlayer I'd like to go ahead with the gitignore. We'll revise that if that's an issue.

@bric3 bric3 merged commit 3bc6acd into master Jul 8, 2025
508 checks passed
@bric3 bric3 deleted the bdu/ignore-asdf-mise branch July 8, 2025 10:05
@github-actions github-actions bot added this to the 1.51.0 milestone Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer left review comments

@smola smola smola approved these changes

@amarziali amarziali amarziali approved these changes

Assignees

No one assigned

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Milestone

1.51.0

Development

Successfully merging this pull request may close these issues.

4 participants

@bric3 @smola @PerfectSlayer @amarziali
0