8000 Fix integration with the Tests observability product by TovRudyy · Pull Request #9008 · DataDog/dd-trace-java · GitHub
[go: up one dir, main page]

Skip to content

Fix integration with the Tests observability product #9008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms 8000 of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

TovRudyy
Copy link
Contributor
@TovRudyy TovRudyy commented Jun 19, 2025

What Does This Do

Overwriting the git.repository_url tag in the datadog-ci junit upload command to point to the GitHub URL of the dd-trace-java repository.

Motivation

Some features of the Test Optimization product currently don't work because the repository name of dd-trace-java differs between GitLab and GitHub.

This causes requests to the GitHub API to fail because the DataDog/apm-reliability/dd-trace-java repo does not exist. As a result, some features of Test Optimization don't work such as tagging test runs with the @test.codeowners tag.

Additional Notes

⚠️ By changing the value of the repository URL that tests are reported with will cause a reset of the Tests history of the dd-trace-java repository. In other words, test runs of dd-trace-java will start being reported with a new repository ID.

I believe this breaking change is worth it for a proper integration with the Test Optimization product.

@TovRudyy TovRudyy changed the title Fix integration with the Tests observability product (Test Optimization) [NOTICKET] Fix integration with the Tests observability product (Test Optimization) Jun 19, 2025
@TovRudyy TovRudyy force-pushed the olek.rudyy/overwrite-git-repository-url branch from a0634d6 to 69c0d85 Compare June 19, 2025 08:32
@TovRudyy TovRudyy changed the title [NOTICKET] Fix integration with the Tests observability product (Test Optimization) [NOTICKET] Fix integration with the Tests observability product Jun 19, 2025
@TovRudyy TovRudyy force-pushed the olek.rudyy/overwrite-git-repository-url branch from 9e68999 to 4fd86dc Compare June 19, 2025 08:51
@pr-commenter
Copy link
pr-commenter bot commented Jun 19, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master olek.rudyy/overwrite-git-repository-url
git_commit_date 1750323428 1750330369
git_commit_sha a7ce6e7 f645ea6
release_version 1.50.0-SNAPSHOT~a7ce6e7f58 1.50.0-SNAPSHOT~f645ea6bf1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1750332127 1750332127
ci_job_id 989850012 989850012
ci_pipeline_id 68223505 68223505
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zazkytx-project-304-concurrent-0-f9mxyige 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zazkytx-project-304-concurrent-0-f9mxyige 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 12 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.027 s) : 0, 1026828
Total [baseline] (10.431 s) : 0, 10431352
Agent [candidate] (1.023 s) : 0, 1023342
Total [candidate] (10.558 s) : 0, 10557735
section appsec
Agent [baseline] (1.177 s) : 0, 1176681
Total [baseline] (10.694 s) : 0, 10693519
Agent [candidate] (1.179 s) : 0, 1179398
Total [candidate] (10.708 s) : 0, 10708297
section iast
Agent [baseline] (1.153 s) : 0, 1153064
Total [baseline] (10.849 s) : 0, 10849146
Agent [candidate] (1.153 s) : 0, 1152831
Total [candidate] (10.877 s) : 0, 10876873
section profiling
Agent [baseline] (1.264 s) : 0, 1263607
Total [baseline] (10.884 s) : 0, 10883823
Agent [candidate] (1.269 s) : 0, 1269425
Total [candidate] (10.908 s) : 0, 10908127
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.027 s -
Agent appsec 1.177 s 149.852 ms (14.6%)
Agent iast 1.153 s 126.236 ms (12.3%)
Agent profiling 1.264 s 236.778 ms (23.1%)
Total tracing 10.431 s -
Total appsec 10.694 s 262.167 ms (2.5%)
Total iast 10.849 s 417.794 ms (4.0%)
Total profiling 10.884 s 452.471 ms (4.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.023 s -
Agent appsec 1.179 s 156.057 ms (15.2%)
Agent iast 1.153 s 129.489 ms (12.7%)
Agent profiling 1.269 s 246.083 ms (24.0%)
Total tracing 10.558 s -
Total appsec 10.708 s 150.561 ms (1.4%)
Total iast 10.877 s 319.138 ms (3.0%)
Total profiling 10.908 s 350.392 ms (3.3%)
gantt
    title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.416 ms) : 0, 685416
BytebuddyAgent [candidate] (683.657 ms) : 0, 683657
GlobalTracer [baseline] (241.65 ms) : 0, 241650
GlobalTracer [candidate] (241.196 ms) : 0, 241196
AppSec [baseline] (59.899 ms) : 0, 59899
AppSec [candidate] (57.641 ms) : 0, 57641
Debugger [baseline] (6.073 ms) : 0, 6073
Debugger [candidate] (6.863 ms) : 0, 6863
Remote Config [baseline] (721.152 µs) : 0, 721
Remote Config [candidate] (725.419 µs) : 0, 725
Telemetry [baseline] (9.511 ms) : 0, 9511
Telemetry [candidate] (9.819 ms) : 0, 9819
section appsec
BytebuddyAgent [baseline] (706.163 ms) : 0, 706163
BytebuddyAgent [candidate] (707.739 ms) : 0, 707739
GlobalTracer [baseline] (235.036 ms) : 0, 235036
GlobalTracer [candidate] (235.953 ms) : 0, 235953
IAST [baseline] (21.805 ms) : 0, 21805
IAST [candidate] (21.778 ms) : 0, 21778
AppSec [baseline] (176.405 ms) : 0, 176405
AppSec [candidate] (176.51 ms) : 0, 176510
Debugger [baseline] (5.927 ms) : 0, 5927
Debugger [candidate] (5.972 ms) : 0, 5972
Remote Config [baseline] (614.765 µs) : 0, 615
Remote Config [candidate] (641.983 µs) : 0, 642
Telemetry [baseline] (7.353 ms) : 0, 7353
Telemetry [candidate] (7.328 ms) : 0, 7328
section iast
BytebuddyAgent [baseline] (804.372 ms) : 0, 804372
BytebuddyAgent [candidate] (804.408 ms) : 0, 804408
GlobalTracer [baseline] (231.071 ms) : 0, 231071
GlobalTracer [candidate] (231.659 ms) : 0, 231659
IAST [baseline] (26.415 ms) : 0, 26415
IAST [candidate] (27.57 ms) : 0, 27570
AppSec [baseline] (53.26 ms) : 0, 53260
AppSec [candidate] (50.544 ms) : 0, 50544
Debugger [baseline] (5.937 ms) : 0, 5937
Debugger [candidate] (5.95 ms) : 0, 5950
Remote Config [baseline] (613.311 µs) : 0, 613
Remote Config [candidate] (589.851 µs) : 0, 590
Telemetry [baseline] (7.911 ms) : 0, 7911
Telemetry [candidate] (7.925 ms) : 0, 7925
section profiling
BytebuddyAgent [baseline] (673.449 ms) : 0, 673449
BytebuddyAgent [candidate] (677.376 ms) : 0, 677376
GlobalTracer [baseline] (359.852 ms) : 0, 359852
GlobalTracer [candidate] (360.985 ms) : 0, 360985
AppSec [baseline] (61.886 ms) : 0, 61886
AppSec [candidate] (61.799 ms) : 0, 61799
Debugger [baseline] (6.154 ms) : 0, 6154
Debugger [candidate] (6.196 ms) : 0, 6196
Remote Config [baseline] (644.4 µs) : 0, 644
Remote Config [candidate] (656.31 µs) : 0, 656
Telemetry [baseline] (8.245 ms) : 0, 8245
Telemetry [candidate] (8.193 ms) : 0, 8193
ProfilingAgent [baseline] (102.746 ms) : 0, 102746
ProfilingAgent [candidate] (103.322 ms) : 0, 103322
Profiling [baseline] (102.77 ms) : 0, 102770
Profiling [candidate] (103.347 ms) : 0, 103347
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1024060
Total [baseline] (8.557 s) : 0, 8557320
Agent [candidate] (1.023 s) : 0, 1023369
Total [candidate] (8.553 s) : 0, 8552788
section iast
Agent [baseline] (1.151 s) : 0, 1150836
Total [baseline] (9.223 s) : 0, 9222589
Agent [candidate] (1.154 s) : 0, 1153515
Total [candidate] (9.25 s) : 0, 9250068
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.024 s -
Agent iast 1.151 s 126.776 ms (12.4%)
Total tracing 8.557 s -
Total iast 9.223 s 665.269 ms (7.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.023 s -
Agent iast 1.154 s 130.146 ms (12.7%)
Total tracing 8.553 s -
Total iast 9.25 s 697.28 ms (8.2%)
gantt
    title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.72 ms) : 0, 684720
BytebuddyAgent [candidate] (683.94 ms) : 0, 683940
GlobalTracer [baseline] (241.098 ms) : 0, 241098
GlobalTracer [candidate] (240.717 ms) : 0, 240717
AppSec [baseline] (58.242 ms) : 0, 58242
AppSec [candidate] (60.322 ms) : 0, 60322
Debugger [baseline] (6.847 ms) : 0, 6847
Debugger [candidate] (6.04 ms) : 0, 6040
Remote Config [baseline] (736.251 µs) : 0, 736
Remote Config [candidate] (732.755 µs) : 0, 733
Telemetry [baseline] (8.908 ms) : 0, 8908
Telemetry [candidate] (8.113 ms) : 0, 8113
section iast
BytebuddyAgent [baseline] (802.995 ms) : 0, 802995
BytebuddyAgent [candidate] (805.165 ms) : 0, 805165
GlobalTracer [baseline] (231.119 ms) : 0, 231119
GlobalTracer [candidate] (231.533 ms) : 0, 231533
IAST [baseline] (27.766 ms) : 0, 27766
IAST [candidate] (29.927 ms) : 0, 29927
AppSec [baseline] (51.053 ms) : 0, 51053
AppSec [candidate] (48.918 ms) : 0, 48918
Debugger [baseline] (5.94 ms) : 0, 5940
Debugger [candidate] (5.926 ms) : 0, 5926
Remote Config [baseline] (656.727 µs) : 0, 657
Remote Config [candidate] (608.289 µs) : 0, 608
Telemetry [baseline] (7.925 ms) : 0, 7925
Telemetry [candidate] (7.98 ms) : 0, 7980
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master olek.rudyy/overwrite-git-repository-url
git_commit_date 1750323428 1750330369
git_commit_sha a7ce6e7 f645ea6
release_version 1.50.0-SNAPSHOT~a7ce6e7f58 1.50.0-SNAPSHOT~f645ea6bf1
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1750331898 1750331898
ci_job_id 989850013 989850013
ci_pipeline_id 68223505 68223505
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zazkytx-project-304-concurrent-2-p3z3z6xb 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zazkytx-project-304-concurrent-2-p3z3z6xb 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:profiling:high_load worse
[+272.996µs; +570.871µs] or [+3.235%; +6.766%]
unstable
[-86.317op/s; +34.567op/s] or [-15.707%; +6.290%]
8.860ms 523.688op/s 8.438ms 549.562op/s
scenario:load:insecure-bank:tracing:high_load better
[-661.199µs; -422.852µs] or [-8.405%; -5.375%]
unstable
[-25.227op/s; +110.727op/s] or [-4.282%; +18.795%]
7.324ms 631.875op/s 7.866ms 589.125op/s
scenario:load:petclinic:no_agent:high_load worse
[+0.765ms; +1.439ms] or [+2.019%; +3.796%]
unstable
[-12.151op/s; +5.176op/s] or [-9.848%; +4.195%]
39.005ms 119.900op/s 37.903ms 123.388op/s
scenario:load:petclinic:iast:high_load better
[-3.167ms; -2.329ms] or [-6.931%; -5.097%]
unstable
[-0.988op/s; +13.963op/s] or [-0.965%; +13.633%]
42.951ms 108.912op/s 45.699ms 102.425op/s
scenario:load:petclinic:profiling:high_load better
[-2.368ms; -1.420ms] or [-4.771%; -2.861%]
unstable
[-3.365op/s; +10.840op/s] or [-3.569%; +11.498%]
47.744ms 98.013op/s 49.638ms 94.275op/s
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.458 ms) : 4403, 4513
.   : milestone, 4458,
iast (9.434 ms) : 9269, 9598
.   : milestone, 9434,
iast_FULL (13.541 ms) : 13273, 13810
.   : milestone, 13541,
iast_GLOBAL (10.049 ms) : 9873, 10225
.   : milestone, 10049,
profiling (8.438 ms) : 8299, 8576
.   : milestone, 8438,
tracing (7.866 ms) : 7752, 7980
.   : milestone, 7866,
section candidate
no_agent (4.377 ms) : 4327, 4428
.   : milestone, 4377,
iast (9.238 ms) : 9087, 9389
.   : milestone, 9238,
iast_FULL (13.922 ms) : 13646, 14198
.   : milestone, 13922,
iast_GLOBAL (10.17 ms) : 9995, 10346
.   : milestone, 10170,
profiling (8.86 ms) : 8722, 8998
.   : milestone, 8860,
tracing (7.324 ms) : 7217, 7431
.   : milestone, 7324,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.458 ms [4.403 ms, 4.513 ms] -
iast 9.434 ms [9.269 ms, 9.598 ms] 4.976 ms (111.6%)
iast_FULL 13.541 ms [13.273 ms, 13.81 ms] 9.084 ms (203.8%)
iast_GLOBAL 10.049 ms [9.873 ms, 10.225 ms] 5.591 ms (125.4%)
profiling 8.438 ms [8.299 ms, 8.576 ms] 3.98 ms (89.3%)
tracing 7.866 ms [7.752 ms, 7.98 ms] 3.409 ms (76.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.377 ms [4.327 ms, 4.428 ms] -
iast 9.238 ms [9.087 ms, 9.389 ms] 4.861 ms (111.1%)
iast_FULL 13.922 ms [13.646 ms, 14.198 ms] 9.545 ms (218.1%)
iast_GLOBAL 10.17 ms [9.995 ms, 10.346 ms] 5.793 ms (132.4%)
profiling 8.86 ms [8.722 ms, 8.998 ms] 4.483 ms (102.4%)
tracing 7.324 ms [7.217 ms, 7.431 ms] 2.947 ms (67.3%)
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.903 ms) : 37595, 38211
.   : milestone, 37903,
appsec (47.911 ms) : 47491, 48331
.   : milestone, 47911,
code_origins (44.42 ms) : 44056, 44785
.   : milestone, 44420,
iast (45.699 ms) : 45299, 46099
.   : milestone, 45699,
profiling (49.638 ms) : 49195, 50082
.   : milestone, 49638,
tracing (43.787 ms) : 43416, 44159
.   : milestone, 43787,
section candidate
no_agent (39.005 ms) : 38687, 39323
.   : milestone, 39005,
appsec (48.872 ms) : 48431, 49314
.   : milestone, 48872,
code_origins (44.322 ms) : 43969, 44675
.   : milestone, 44322,
iast (42.951 ms) : 42572, 43329
.   : milestone, 42951,
profiling (47.744 ms) : 47307, 48182
.   : milestone, 47744,
tracing (44.448 ms) : 44085, 44812
.   : milestone, 44448,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.903 ms [37.595 ms, 38.211 ms] -
appsec 47.911 ms [47.491 ms, 48.331 ms] 10.008 ms (26.4%)
code_origins 44.42 ms [44.056 ms, 44.785 ms] 6.517 ms (17.2%)
iast 45.699 ms [45.299 ms, 46.099 ms] 7.796 ms (20.6%)
profiling 49.638 ms [49.195 ms, 50.082 ms] 11.735 ms (31.0%)
tracing 43.787 ms [43.416 ms, 44.159 ms] 5.884 ms (15.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 39.005 ms [38.687 ms, 39.323 ms] -
appsec 48.872 ms [48.431 ms, 49.314 ms] 9.867 ms (25.3%)
code_origins 44.322 ms [43.969 ms, 44.675 ms] 5.317 ms (13.6%)
iast 42.951 ms [42.572 ms, 43.329 ms] 3.946 ms (10.1%)
profiling 47.744 ms [47.307 ms, 48.182 ms] 8.739 ms (22.4%)
tracing 44.448 ms [44.085 ms, 44.812 ms] 5.443 ms (14.0%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master olek.rudyy/overwrite-git-repository-url
git_commit_date 1750323428 1750330369
git_commit_sha a7ce6e7 f645ea6
release_version 1.50.0-SNAPSHOT~a7ce6e7f58 1.50.0-SNAPSHOT~f645ea6bf1
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1750332344 1750332344
ci_job_id 989850014 989850014
ci_pipeline_id 68223505 68223505
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zazkytx-project-304-concurrent-3-g3cin9f1 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zazkytx-project-304-concurrent-3-g3cin9f1 6.8.0-1029-aws #31~22.04.1-Ubuntu SMP Thu Apr 24 21:16:18 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.494 ms) : 1482, 1506
.   : milestone, 1494,
appsec (2.429 ms) : 2380, 2478
.   : milestone, 2429,
iast (2.212 ms) : 2150, 2274
.   : milestone, 2212,
iast_GLOBAL (2.255 ms) : 2192, 2317
.   : milestone, 2255,
profiling (2.078 ms) : 2027, 2129
.   : milestone, 2078,
tracing (2.017 ms) : 1970, 2065
.   : milestone, 2017,
section candidate
no_agent (1.487 ms) : 1475, 1499
.   : milestone, 1487,
appsec (2.433 ms) : 2384, 2482
.   : milestone, 2433,
iast (2.212 ms) : 2150, 2273
.   : milestone, 2212,
iast_GLOBAL (2.251 ms) : 2189, 2314
.   : milestone, 2251,
profiling (2.055 ms) : 2006, 2105
.   : milestone, 2055,
tracing (2.028 ms) : 1980, 2076
.   : milestone, 2028,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.494 ms [1.482 ms, 1.506 ms] -
appsec 2.429 ms [2.38 ms, 2.478 ms] 935.157 µs (62.6%)
iast 2.212 ms [2.15 ms, 2.274 ms] 718.485 µs (48.1%)
iast_GLOBAL 2.255 ms [2.192 ms, 2.317 ms] 760.727 µs (50.9%)
profiling 2.078 ms [2.027 ms, 2.129 ms] 584.147 µs (39.1%)
tracing 2.017 ms [1.97 ms, 2.065 ms] 523.515 µs (35.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.487 ms [1.475 ms, 1.499 ms] -
appsec 2.433 ms [2.384 ms, 2.482 ms] 946.224 µs (63.6%)
iast 2.212 ms [2.15 ms, 2.273 ms] 724.639 µs (48.7%)
iast_GLOBAL 2.251 ms [2.189 ms, 2.314 ms] 764.247 µs (51.4%)
profiling 2.055 ms [2.006 ms, 2.105 ms] 568.404 µs (38.2%)
tracing 2.028 ms [1.98 ms, 2.076 ms] 540.821 µs (36.4%)
Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~f645ea6bf1, baseline=1.50.0-SNAPSHOT~a7ce6e7f58
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.414 s) : 15414000, 15414000
.   : milestone, 15414000,
appsec (14.603 s) : 14603000, 14603000
.   : milestone, 14603000,
iast (18.888 s) : 18888000, 18888000
.   : milestone, 18888000,
iast_GLOBAL (18.036 s) : 18036000, 18036000
.   : milestone, 18036000,
profiling (15.753 s) : 15753000, 15753000
.   : milestone, 15753000,
tracing (15.022 s) : 15022000, 15022000
.   : milestone, 15022000,
section candidate
no_agent (15.22 s) : 15220000, 15220000
.   : milestone, 15220000,
appsec (14.717 s) : 14717000, 14717000
.   : milestone, 14717000,
iast (18.749 s) : 18749000, 18749000
.   : milestone, 18749000,
iast_GLOBAL (18.006 s) : 18006000, 18006000
.   : milestone, 18006000,
profiling (15.104 s) : 15104000, 15104000
.   : milestone, 15104000,
tracing (14.585 s) : 14585000, 14585000
.   : milestone, 14585000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.414 s [15.414 s, 15.414 s] -
appsec 14.603 s [14.603 s, 14.603 s] -811.0 ms (-5.3%)
iast 18.888 s [18.888 s, 18.888 s] 3.474 s (22.5%)
iast_GLOBAL 18.036 s [18.036 s, 18.036 s] 2.622 s (17.0%)
profiling 15.753 s [15.753 s, 15.753 s] 339.0 ms (2.2%)
tracing 15.022 s [15.022 s, 15.022 s] -392.0 ms (-2.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.22 s [15.22 s, 15.22 s] -
appsec 14.717 s [14.717 s, 14.717 s] -503.0 ms (-3.3%)
iast 18.749 s [18.749 s, 18.749 s] 3.529 s (23.2%)
iast_GLOBAL 18.006 s [18.006 s, 18.006 s] 2.786 s (18.3%)
profiling 15.104 s [15.104 s, 15.104 s] -116.0 ms (-0.8%)
tracing 14.585 s [14.585 s, 14.585 s] -635.0 ms (-4.2%)

@TovRudyy TovRudyy force-pushed the olek.rudyy/overwrite-git-repository-url branch from 4fd86dc to 8ec7561 Compare June 19, 2025 09:52
@TovRudyy TovRudyy force-pushed the olek.rudyy/overwrite-git-repository-url branch from 8ec7561 to f645ea6 Compare June 19, 2025 10:53
@TovRudyy TovRudyy marked this pull request as ready for review June 19, 2025 12:13
@TovRudyy TovRudyy requested a review from a team as a code owner June 19, 2025 12:13
@TovRudyy TovRudyy requested review from bric3 and removed request for a team June 19, 2025 12:13
Copy link
Contributor
github-actions bot commented Jun 19, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@PerfectSlayer PerfectSlayer changed the title [NOTICKET] Fix integration with the Tests observability product Fix integration with the Tests observability product Jun 19, 2025
@PerfectSlayer PerfectSlayer added type: bug tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jun 19, 2025
Copy link
Contributor
@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting fix indeed.

I guess this kind of change wil 8000 l also break all existing monitors and dashboard?

@TovRudyy
Copy link
Contributor Author

Interesting fix indeed.

I guess this kind of change will also break all existing monitors and dashboard?

Correct.

For monitors, I took a look and found these ones: https://app.datadoghq.com/monitors/manage?q=dd-trace-java%20type%3Aci-tests and as a fact this PR will fix them, not break, because they rely on GitHub's ID (@git.repository.id:"github.com/DataDog/dd-trace-java")

For dashboards, not sure if you have something custom set up, but if you do you will want to check if you filter by the @git.repository.id or @git.repository_url tags

@TovRudyy TovRudyy requested a review from PerfectSlayer June 19, 2025 12:50
@PerfectSlayer
Copy link
Contributor
PerfectSlayer commented Jun 19, 2025

you will want to check if you filter by the @git.repository.id or @git.repository_url tags

Oh yeah, that will definitely break most of my widgets! I will update them then.

I let the team know about it and will merge the PR later today. Thanks!

@PerfectSlayer PerfectSlayer added the tag: breaking change Breaking changes label Jun 19, 2025
@PerfectSlayer PerfectSlayer merged commit e0a1fc0 into master Jun 19, 2025
487 of 490 checks passed
@PerfectSlayer PerfectSlayer deleted the olek.rudyy/overwrite-git-repository-url branch June 19, 2025 14:15
@github-actions github-actions bot added this to the 1.50.0 milestone Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: tooling Build & Tooling tag: breaking change Breaking changes tag: no release notes Changes to exclude from release notes type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0