-
Notifications
You must be signed in to change notification settings - Fork 305
Revert "Enable API Security by default" #9006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Enable API Security by default" #9006
Conversation
This reverts commit 2885767.
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 9 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~348ff22f13, baseline=1.50.0-SNAPSHOT~712d5c320e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1023963
Total [baseline] (8.512 s) : 0, 8511755
Agent [candidate] (1.025 s) : 0, 1024893
Total [candidate] (8.515 s) : 0, 8514995
section iast
Agent [baseline] (1.155 s) : 0, 1154540
Total [baseline] (9.201 s) : 0, 9200611
Agent [candidate] (1.154 s) : 0, 1153906
Total [candidate] (9.224 s) : 0, 9223705
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~348ff22f13, baseline=1.50.0-SNAPSHOT~712d5c320e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (683.592 ms) : 0, 683592
BytebuddyAgent [candidate] (684.004 ms) : 0, 684004
GlobalTracer [baseline] (240.359 ms) : 0, 240359
GlobalTracer [candidate] (241.007 ms) : 0, 241007
AppSec [baseline] (58.421 ms) : 0, 58421
AppSec [candidate] (59.98 ms) : 0, 59980
Debugger [baseline] (6.176 ms) : 0, 6176
Debugger [candidate] (6.889 ms) : 0, 6889
Remote Config [baseline] (750.0 µs) : 0, 750
Remote Config [candidate] (717.224 µs) : 0, 717
Telemetry [baseline] (11.253 ms) : 0, 11253
Telemetry [candidate] (8.86 ms) : 0, 8860
section iast
BytebuddyAgent [baseline] (803.986 ms) : 0, 803986
BytebuddyAgent [candidate] (805.58 ms) : 0, 805580
GlobalTracer [baseline] (230.98 ms) : 0, 230980
GlobalTracer [candidate] (231.475 ms) : 0, 231475
IAST [baseline] (26.025 ms) : 0, 26025
IAST [candidate] (25.395 ms) : 0, 25395
AppSec [baseline] (55.582 ms) : 0, 55582
AppSec [candidate] (53.445 ms) : 0, 53445
Debugger [baseline] (6.034 ms) : 0, 6034
Debugger [candidate] (5.952 ms) : 0, 5952
Remote Config [baseline] (596.978 µs) : 0, 597
Remote Config [candidate] (595.947 µs) : 0, 596
Telemetry [baseline] (7.895 ms) : 0, 7895
Telemetry [candidate] (7.932 ms) : 0, 7932
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~348ff22f13, baseline=1.50.0-SNAPSHOT~712d5c320e
dateFormat
8000
X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1026305
Total [baseline] (10.619 s) : 0, 10619458
Agent [candidate] (1.027 s) : 0, 1026683
Total [candidate] (10.505 s) : 0, 10505001
section appsec
Agent [baseline] (1.178 s) : 0, 1178294
Total [baseline] (10.711 s) : 0, 10711485
Agent [candidate] (1.178 s) : 0, 1177933
Total [candidate] (10.755 s) : 0, 10755111
section iast
Agent [baseline] (1.156 s) : 0, 1156243
Total [baseline] (10.865 s) : 0, 10865271
Agent [candidate] (1.154 s) : 0, 1153731
Total [candidate] (10.939 s) : 0, 10939085
section profiling
Agent [baseline] (1.271 s) : 0, 1271280
Total [baseline] (10.947 s) : 0, 10946886
Agent [candidate] (1.27 s) : 0, 1269565
Total [candidate] (10.936 s) : 0, 10935576
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~348ff22f13, baseline=1.50.0-SNAPSHOT~712d5c320e
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (684.372 ms) : 0, 684372
BytebuddyAgent [candidate] (684.962 ms) : 0, 684962
GlobalTracer [baseline] (241.18 ms) : 0, 241180
GlobalTracer [candidate] (241.883 ms) : 0, 241883
AppSec [baseline] (59.153 ms) : 0, 59153
AppSec [candidate] (58.322 ms) : 0, 58322
Debugger [baseline] (6.142 ms) : 0, 6142
Debugger [candidate] (6.116 ms) : 0, 6116
Remote Config [baseline] (743.428 µs) : 0, 743
Remote Config [candidate] (782.904 µs) : 0, 783
Telemetry [baseline] (11.212 ms) : 0, 11212
Telemetry [candidate] (11.207 ms) : 0, 11207
section appsec
BytebuddyAgent [baseline] (706.033 ms) : 0, 706033
BytebuddyAgent [candidate] (707.151 ms) : 0, 707151
GlobalTracer [baseline] (234.862 ms) : 0, 234862
GlobalTracer [candidate] (235.731 ms) : 0, 235731
AppSec [baseline] (178.557 ms) : 0, 178557
AppSec [candidate] (175.955 ms) : 0, 175955
Debugger [baseline] (5.825 ms) : 0, 5825
Debugger [candidate] (5.955 ms) : 0, 5955
Remote Config [baseline] (616.722 µs) : 0, 617
Remote Config [candidate] (617.756 µs) : 0, 618
Telemetry [baseline] (7.233 ms) : 0, 7233
Telemetry [candidate] (7.328 ms) : 0, 7328
IAST [baseline] (21.781 ms) : 0, 21781
IAST [candidate] (21.718 ms) : 0, 21718
section iast
BytebuddyAgent [baseline] (805.071 ms) : 0, 805071
BytebuddyAgent [candidate] (804.744 ms) : 0, 804744
GlobalTracer [baseline] (231.467 ms) : 0, 231467
GlobalTracer [candidate] (231.973 ms) : 0, 231973
AppSec [baseline] (54.88 ms) : 0, 54880
AppSec [candidate] (51.362 ms) : 0, 51362
Debugger [baseline] (6.016 ms) : 0, 6016
Debugger [candidate] (5.957 ms) : 0, 5957
Remote Config [baseline] (606.922 µs) : 0, 607
Remote Config [candidate] (594.784 µs) : 0, 595
Telemetry [baseline] (7.947 ms) : 0, 7947
Telemetry [candidate] (7.942 ms) : 0, 7942
IAST [baseline] (26.829 ms) : 0, 26829
IAST [candidate] (27.676 ms) : 0, 27676
section profiling
ProfilingAgent [baseline] (105.051 ms) : 0, 105051
ProfilingAgent [candidate] (103.496 ms) : 0, 103496
BytebuddyAgent [baseline] (675.639 ms) : 0, 675639
BytebuddyAgent [candidate] (677.378 ms) : 0, 677378
GlobalTracer [baseline] (360.344 ms) : 0, 360344
GlobalTracer [candidate] (361.18 ms) : 0, 361180
AppSec [baseline] (64.707 ms) : 0, 64707
AppSec [candidate] (61.589 ms) : 0, 61589
Debugger [baseline] (6.131 ms) : 0, 6131
Debugger [candidate] (6.15 ms) : 0, 6150
Remote Config [baseline] (650.449 µs) : 0, 650
Remote Config [candidate] (659.738 µs) : 0, 660
Telemetry [baseline] (8.047 ms) : 0, 8047
Telemetry [candidate] (8.205 ms) : 0, 8205
Profiling [baseline] (105.077 ms) : 0, 105077
Profiling [candidate] (103.52 ms) : 0, 103520
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~348ff22f13, baseline=1.50.0-SNAPSHOT~712d5c320e
dateFormat X
axisFormat %s
section baseline
no_agent (36.452 ms) : 36159, 36745
. : milestone, 36452,
appsec (44.695 ms) : 44304, 45086
. : milestone, 44695,
code_origins (45.497 ms) : 45123, 45872
. : milestone, 45497,
iast (44.139 ms) : 43761, 44518
. : milestone, 44139,
profiling (48.1 ms) : 47679, 48521
. : milestone, 48100,
tracing (42.33 ms) : 41994, 42667
. : milestone, 42330,
section candidate
no_agent (36.346 ms) : 36054, 36639
. : milestone, 36346,
appsec (46.124 ms) : 45720, 46528
. : milestone, 46124,
code_origins (46.566 ms) : 46176, 46956
. : milestone, 46566,
iast (43.82 ms) : 43447, 44194
. : milestone, 43820,
profiling (48.549 ms) : 48089, 49010
. : milestone, 48549,
tracing (43.836 ms) : 43482, 44191
. : milestone, 43836,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~348ff22f13, baseline=1.50.0-SNAPSHOT~712d5c320e
dateFormat X
axisFormat %s
section baseline
no_agent (4.471 ms) : 4421, 4521
. : milestone, 4471,
iast (9.122 ms) : 8966, 9278
. : milestone, 9122,
iast_FULL (13.493 ms) : 13229, 13757
. : milestone, 13493,
iast_GLOBAL (10.195 ms) : 10017, 10373
. : milestone, 10195,
profiling (8.888 ms) : 8743, 9032
. : milestone, 8888,
tracing (7.465 ms) : 7354, 7576
. : milestone, 7465,
section candidate
no_agent (4.426 ms) : 4371, 4480
. : milestone, 4426,
iast (9.235 ms) : 9083, 9387
. : milestone, 9235,
iast_FULL (13.649 ms) : 13376, 13922
. : milestone, 13649,
iast_GLOBAL (10.11 ms) : 9922, 10298
. : milestone, 10110,
profiling (8.763 ms) : 8632, 8894
. : milestone, 8763,
tracing (7.766 ms) : 7649, 7883
. : milestone, 7766,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~348ff22f13, baseline=1.50.0-SNAPSHOT~712d5c320e
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.408 ms) : 2359, 2457
. : milestone, 2408,
iast (2.178 ms) : 2117, 2239
. : milestone, 2178,
iast_GLOBAL (2.232 ms) : 2171, 2293
. : milestone, 2232,
profiling (2.031 ms) : 1982, 2080
. : milestone, 2031,
tracing (1.997 ms) : 1950, 2045
. : milestone, 1997,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.405 ms) : 2356, 2453
. : milestone, 2405,
iast (2.187 ms) : 2125, 2249
. : milestone, 2187,
iast_GLOBAL (2.228 ms) : 2167, 2290
. : milestone, 2228,
profiling (2.482 ms) : 2308, 2657
. : milestone, 2482,
tracing (2.023 ms) : 1975, 2071
. : milestone, 2023,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~348ff22f13, baseline=1.50.0-SNAPSHOT~712d5c320e
dateFormat X
axisFormat %s
section baseline
no_agent (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
appsec (14.747 s) : 14747000, 14747000
. : milestone, 14747000,
iast (18.648 s) : 18648000, 18648000
. : milestone, 18648000,
iast_GLOBAL (18.112 s) : 18112000, 18112000
. : milestone, 18112000,
profiling (15.183 s) : 15183000, 15183000
. : milestone, 15183000,
tracing (15.18 s) : 15180000, 15180000
. : milestone, 15180000,
section candidate
no_agent (14.917 s) : 14917000, 14917000
. : milestone, 14917000,
appsec (14.865 s) : 14865000, 14865000
. : milestone, 14865000,
iast (19.051 s) : 19051000, 19051000
. : milestone, 19051000,
iast_GLOBAL (17.904 s) : 17904000, 17904000
. : milestone, 17904000,
profiling (15.797 s) : 15797000, 15797000
. : milestone, 15797000,
tracing (14.755 s) : 14755000, 14755000
. : milestone, 14755000,
|
Reverts #8511
The PR introduces a slight startup performance regression, so we will revert for the 1.50.0 release.
See BP UI ref runs 68139155 and 68120382 (candidate branch does not include this PR) vs. 68164219 and 68155119 (candidate PR does include this PR). Note that in this case,
master
/1.50.0 is the baseline and the 1.49.0 branch is the candidate, so the performance improvements/regressions are reversed.