-
Notifications
You must be signed in to change notification settings - Fork 306
Fix IAST gRPC handler with null superclass #8984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix IAST gRPC handler with null superclass #8984
Conversation
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 41 metrics, 11 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~ecbe34cef8, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1024145
Total [baseline] (8.551 s) : 0, 8550510
Agent [candidate] (1.027 s) : 0, 1026718
Total [candidate] (8.56 s) : 0, 8559698
section iast
Agent [baseline] (1.152 s) : 0, 1152480
Total [baseline] (9.242 s) : 0, 9241949
Agent [candidate] (1.158 s) : 0, 1158286
Total [candidate] (9.213 s) : 0, 9212529
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~ecbe34cef8, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (685.619 ms) : 0, 685619
BytebuddyAgent [candidate] (686.628 ms) : 0, 686628
GlobalTracer [baseline] (241.728 ms) : 0, 241728
GlobalTracer [candidate] (242.143 ms) : 0, 242143
AppSec [baseline] (57.731 ms) : 0, 57731
AppSec [candidate] (58.037 ms) : 0, 58037
Debugger [baseline] (7.764 ms) : 0, 7764
Debugger [candidate] (9.396 ms) : 0, 9396
Remote Config [baseline] (657.217 µs) : 0, 657
Remote Config [candidate] (668.723 µs) : 0, 669
Telemetry [baseline] (9.751 ms) : 0, 9751
Telemetry [candidate] (8.926 ms) : 0, 8926
section iast
BytebuddyAgent [baseline] (806.028 ms) : 0, 806028
BytebuddyAgent [candidate] (810.535 ms) : 0, 810535
GlobalTracer [baseline] (231.717 ms) : 0, 231717
GlobalTracer [candidate] (232.731 ms) : 0, 232731
IAST [baseline] (27.531 ms) : 0, 27531
IAST [candidate] (25.305 ms) : 0, 25305
AppSec [baseline] (51.709 ms) : 0, 51709
AppSec [candidate] (54.097 ms) : 0, 54097
Debugger [baseline] (5.989 ms) : 0, 5989
Debugger [candidate] (5.985 ms) : 0, 5985
Remote Config [baseline] (610.603 µs) : 0, 611
Remote Config [candidate] (619.963 µs) : 0, 620
Telemetry [baseline] (7.967 ms) : 0, 7967
Telemetry [candidate] (8.096 ms) : 0, 8096
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~ecbe34cef8, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.03 s) : 0, 1030276
Total [baseline] (10.735 s) : 0, 10734853
Agent [candidate] (1.029 s) : 0, 1028688
Total [candidate] (10.552 s) : 0, 10551571
section appsec
Agent [baseline] (1.18 s) : 0, 1179775
Total [baseline] (10.825 s) : 0, 10825175
Agent [candidate] (1.184 s) : 0, 1184376
Total [candidate] (10.771 s) : 0, 10771050
section iast
Agent [baseline] (1.153 s) : 0, 1152996
Total [baseline] (10.947 s) : 0, 10947466
Agent [candidate] (1.154 s) : 0, 1153630
Total [candidate] (10.93 s) : 0, 10930470
section profiling
Agent [baseline] (1.275 s) : 0, 1274965
Total [baseline] (11.028 s) : 0, 11028282
Agent [candidate] (1.293 s) : 0, 1292942
Total [candidate] (11.021 s) : 0, 11020689
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~ecbe34cef8, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.758 ms) : 0, 687758
BytebuddyAgent [candidate] (689.572 ms) : 0, 689572
GlobalTracer [baseline] (244.223 ms) : 0, 244223
GlobalTracer [candidate] (241.906 ms) : 0, 241906
AppSec [baseline] (58.391 ms) : 0, 58391
AppSec [candidate] (57.585 ms) : 0, 57585
Debugger [baseline] (8.51 ms) : 0, 8510
Debugger [candidate] (6.879 ms) : 0, 6879
Remote Config [baseline] (685.89 µs) : 0, 686
Remote Config [candidate] (665.049 µs) : 0, 665
Telemetry [baseline] (9.77 ms) : 0, 9770
Telemetry [candidate] (11.075 ms) : 0, 11075
section appsec
BytebuddyAgent [baseline] (709.285 ms) : 0, 709285
BytebuddyAgent [candidate] (711.153 ms) : 0, 711153
GlobalTracer [baseline] (235.421 ms) : 0, 235421
GlobalTracer [candidate] (237.187 ms) : 0, 237187
IAST [baseline] (21.82 ms) : 0, 21820
IAST [candidate] (22.081 ms) : 0, 22081
AppSec [baseline] (178.807 ms) : 0, 178807
AppSec [candidate] (179.275 ms) : 0, 179275
Debugger [baseline] (5.776 ms) : 0, 5776
Debugger [candidate] (5.823 ms) : 0, 5823
Remote Config [baseline] (602.326 µs) : 0, 602
Remote Config [candidate] (605.928 µs) : 0, 606
Telemetry [baseline] (7.224 ms) : 0, 7224
Telemetry [candidate] (7.365 ms) : 0, 7365
section iast
BytebuddyAgent [baseline] (806.017 ms) : 0, 806017
BytebuddyAgent [candidate] (807.243 ms) : 0, 807243
GlobalTracer [baseline] (232.16 ms) : 0, 232160
GlobalTracer [candidate] (232.14 ms) : 0, 232140
IAST [baseline] (27.615 ms) : 0, 27615
IAST [candidate] (25.945 ms) : 0, 25945
AppSec [baseline] (51.767 ms) : 0, 51767
AppSec [candidate] (52.947 ms) : 0, 52947
Debugger [baseline] (5.976 ms) : 0, 5976
Debugger [candidate] (5.924 ms) : 0, 5924
Remote Config [baseline] (613.033 µs) : 0, 613
Remote Config [candidate] (608.207 µs) : 0, 608
Telemetry [baseline] (8.024 ms) : 0, 8024
Telemetry [candidate] (7.946 ms) : 0, 7946
section profiling
BytebuddyAgent [baseline] (680.248 ms) : 0, 680248
BytebuddyAgent [candidate] (690.731 ms) : 0, 690731
GlobalTracer [baseline] (362.479 ms) : 0, 362479
GlobalTracer [candidate] (366.686 ms) : 0, 366686
AppSec [baseline] (62.289 ms) : 0, 62289
AppSec [candidate] (63.126 ms) : 0, 63126
Debugger [baseline] (6.113 ms) : 0, 6113
Debugger [candidate] (6.282 ms) : 0, 6282
Remote Config [baseline] (688.915 µs) : 0, 689
Remote Config [candidate] (733.527 µs) : 0, 734
Telemetry [baseline] (8.06 ms) : 0, 8060
Telemetry [candidate] (8.295 ms) : 0, 8295
ProfilingAgent [baseline] (106.284 ms) : 0, 106284
ProfilingAgent [candidate] (107.473 ms) : 0, 107473
Profiling [baseline] (106.308 ms) : 0, 106308
Profiling [candidate] (107.497 ms) : 0, 107497
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~ecbe34cef8, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section baseline
no_agent (4.272 ms) : 4225, 4320
. : milestone, 4272,
iast (9.543 ms) : 9389, 9697
. : milestone, 9543,
iast_FULL (13.36 ms) : 13102, 13618
. : milestone, 13360,
iast_GLOBAL (9.718 ms) : 9544, 9892
. : milestone, 9718,
profiling (8.452 ms) : 8318, 8586
. : milestone, 8452,
tracing (7.703 ms) : 7585, 7821
. : milestone, 7703,
section candidate
no_agent (4.375 ms) : 4326, 4424
. : milestone, 4375,
iast (9.096 ms) : 8939, 9252
. : milestone, 9096,
iast_FULL (13.848 ms) : 13571, 14125
. : milestone, 13848,
iast_GLOBAL (10.155 ms) : 9971, 10340
. : milestone, 10155,
profiling (9.091 ms) : 8943, 9240
. : milestone, 9091,
tracing (7.739 ms) : 7627, 7851
. : milestone, 7739,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~ecbe34cef8, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section baseline
no_agent (37.077 ms) : 36781, 37373
. : milestone, 37077,
appsec (45.751 ms) : 45346, 46157
. : milestone, 45751,
code_origins (45.152 ms) : 44778, 45527
. : milestone, 45152,
iast (42.762 ms) : 42393, 43130
. : milestone, 42762,
profiling (49.798 ms) : 49307, 50290
. : milestone, 49798,
tracing (43.334 ms) : 42989, 43679
. : milestone, 43334,
section candidate
no_agent (36.912 ms) : 36622, 37201
. : milestone, 36912,
appsec (45.541 ms) : 45137, 45945
. : milestone, 45541,
code_origins (44.772 ms) : 44415, 45130
. : milestone, 44772,
iast (42.691 ms) : 42312, 43071
. : milestone, 42691,
profiling (49.746 ms) : 49254, 50238
. : milestone, 49746,
tracing (43.962 ms) : 43607, 44316
. : milestone, 43962,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~ecbe34cef8, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section baseline
no_agent (15.075 s) : 15075000, 15075000
. : milestone, 15075000,
appsec (14.737 s) : 14737000, 14737000
. : milestone, 14737000,
iast (18.872 s) : 18872000, 18872000
. : milestone, 18872000,
iast_GLOBAL (17.934 s) : 17934000, 17934000
. : milestone, 17934000,
profiling (15.305 s) : 15305000, 15305000
. : milestone, 15305000,
tracing (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
section candidate
no_agent (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
appsec (14.794 s) : 14794000, 14794000
. : milestone, 14794000,
iast (18.988 s) : 18988000, 18988000
. : milestone, 18988000,
iast_GLOBAL (17.898 s) : 17898000, 17898000
. : milestone, 17898000,
profiling (15.165 s) : 15165000, 15165000
. : milestone, 15165000,
tracing (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~ecbe34cef8, baseline=1.51.0-SNAPSHOT~aa9dd27535
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (2.405 ms) : 2357, 2454
. : milestone, 2405,
iast (2.202 ms) : 2140, 2264
. : milestone, 2202,
iast_GLOBAL (2.249 ms) : 2188, 2311
. : milestone, 2249,
profiling (2.051 ms) : 2002, 2100
. : milestone, 2051,
tracing (2.007 ms) : 1959, 2054
. : milestone, 2007,
section candidate
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (2.406 ms) : 2357, 2454
. : milestone, 2406,
iast (2.194 ms) : 2132, 2255
. : milestone, 2194,
iast_GLOBAL (2.232 ms) : 2171, 2294
. : milestone, 2232,
profiling (2.066 ms) : 2016, 2116
. : milestone, 2066,
tracing (2.002 ms) : 1955, 2049
. : milestone, 2002,
|
…-agent/agent-iast
…-agent/agent-iast
…-agent/agent-iast
Summary
Testing
./gradlew :dd-java-agent:agent-iast:test
This was an OpenAI Codex trial run, with prompt:
https://chatgpt.com/codex/tasks/task_b_684c29513b90832ea66f4215df35a943