chore: tweak gradle daemon jvm settings #8844
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
mcculls
approved these changes
May 19, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 14 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.50.0-SNAPSHOT~a333678115, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019934
Total [baseline] (8.646 s) : 0, 8646037
Agent [candidate] (1.023 s) : 0, 1023059
Total [candidate] (8.68 s) : 0, 8680332
section iast
Agent [baseline] (1.149 s) : 0, 1148675
Total [baseline] (9.217 s) : 0, 9217458
Agent [candidate] (1.149 s) : 0, 1149081
Total [candidate] (9.238 s) : 0, 9238056
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.148 s) : 0, 1148289
Total [baseline] (9.191 s) : 0, 9191301
Agent [candidate] (1.156 s) : 0, 1155793
Total [candidate] (9.192 s) : 0, 9191860
section iast_TELEMETRY_OFF
Agent [baseline] (1.15 s) : 0, 1150234
Total [baseline] (9.192 s) : 0, 9192068
Agent [candidate] (1.151 s) : 0, 1151160
Total [candidate] (9.252 s) : 0, 9251907
gantt
title insecure-bank - break down per module: candidate=1.50.0-SNAPSHOT~a333678115, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (681.064 ms) : 0, 681064
BytebuddyAgent [candidate] (684.834 ms) : 0, 684834
GlobalTracer [baseline] (240.015 ms) : 0, 240015
GlobalTracer [candidate] (240.516 ms) : 0, 240516
AppSec [baseline] (54.484 ms) : 0, 54484
AppSec [candidate] (54.445 ms) : 0, 54445
Debugger [baseline] (9.591 ms) : 0, 9591
Debugger [candidate] (8.97 ms) : 0, 8970
Remote Config [baseline] (698.377 µs) : 0, 698
Remote Config [candidate] (709.59 µs) : 0, 710
Telemetry [baseline] (10.469 ms) : 0, 10469
Telemetry [candidate] (9.888 ms) : 0, 9888
section iast
BytebuddyAgent [baseline] (801.9 ms) : 0, 801900
BytebuddyAgent [candidate] (801.447 ms) : 0, 801447
GlobalTracer [baseline] (230.426 ms) : 0, 230426
GlobalTracer [candidate] (230.485 ms) : 0, 230485
IAST [baseline] (26.725 ms) : 0, 26725
IAST [candidate] (26.113 ms) : 0, 26113
AppSec [baseline] (50.944 ms) : 0, 50944
AppSec [candidate] (53.036 ms) : 0, 53036
Debugger [baseline] (5.937 ms) : 0, 5937
Debugger [candidate] (5.842 ms) : 0, 5842
Remote Config [baseline] (588.427 µs) : 0, 588
Remote Config [candidate] (583.933 µs) : 0, 584
Telemetry [baseline] (7.882 ms) : 0, 7882
Telemetry [candidate] (7.867 ms) : 0, 7867
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (800.702 ms) : 0, 800702
BytebuddyAgent [candidate] (807.728 ms) : 0, 807728
GlobalTracer [baseline] (230.724 ms) : 0, 230724
GlobalTracer [candidate] (231.907 ms) : 0, 231907
IAST [baseline] (26.798 ms) : 0, 26798
IAST [candidate] (30.058 ms) : 0, 30058
AppSec [baseline] (51.243 ms) : 0, 51243
AppSec [candidate] (48.188 ms) : 0, 48188
Debugger [baseline] (5.949 ms) : 0, 5949
Debugger [candidate] (5.853 ms) : 0, 5853
Remote Config [baseline] (599.529 µs) : 0, 600
Remote Config [candidate] (588.294 µs) : 0, 588
Telemetry [baseline] (7.995 ms) : 0, 7995
Telemetry [candidate] (7.873 ms) : 0, 7873
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (802.463 ms) : 0, 802463
BytebuddyAgent [candidate] (803.228 ms) : 0, 803228
GlobalTracer [baseline] (231.312 ms) : 0, 231312
GlobalTracer [candidate] (231.449 ms) : 0, 231449
IAST [baseline] (23.284 ms) : 0, 23284
IAST [candidate] (23.302 ms) : 0, 23302
AppSec [baseline] (55.151 ms) : 0, 55151
AppSec [candidate] (54.292 ms) : 0, 54292
Debugger [baseline] (5.99 ms) : 0, 5990
Debugger [candidate] (5.98 ms) : 0, 5980
Remote Config [baseline] (601.496 µs) : 0, 601
Remote Config [candidate] (611.908 µs) : 0, 612
Telemetry [baseline] (7.813 ms) : 0, 7813
Telemetry [candidate] (7.81 ms) : 0, 7810
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.50.0-SNAPSHOT~a333678115, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019324
Total [baseline] (10.555 s) : 0, 10554707
Agent [candidate] (1.02 s) : 0, 1019502
Total [candidate] (10.431 s) : 0, 10431327
section appsec
Agent [baseline] (1.169 s) : 0, 1169010
Total [baseline] (10.79 s) : 0, 10789701
Agent [candidate] (1.17 s) : 0, 1169548
Total [candidate] (10.721 s) : 0, 10720935
section iast
Agent [baseline] (1.15 s) : 0, 1149798
Total [baseline] (10.887 s) : 0, 10886870
Agent [candidate] (1.156 s) : 0, 1156111
Total [candidate] (10.905 s) : 0, 10905407
section profiling
Agent [baseline] (1.278 s) : 0, 1278053
Total [baseline] (10.854 s) : 0, 10853543
Agent [candidate] (1.285 s) : 0, 1284891
Total [candidate] (10.822 s) : 0, 10822499
gantt
title petclinic - break down per module: candidate=1.50.0-SNAPSHOT~a333678115, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (682.615 ms) : 0, 682615
BytebuddyAgent [candidate] (682.44 ms) : 0, 682440
GlobalTracer [baseline] (239.883 ms) : 0, 239883
GlobalTracer [candidate] (240.109 ms) : 0, 240109
AppSec [baseline] (54.242 ms) : 0, 54242
AppSec [candidate] (55.08 ms) : 0, 55080
Debugger [baseline] (6.929 ms) : 0, 6929
Debugger [candidate] (6.881 ms) : 0, 6881
Remote Config [baseline] (703.885 µs) : 0, 704
Remote Config [candidate] (712.391 µs) : 0, 712
Telemetry [baseline] (11.363 ms) : 0, 11363
Telemetry [candidate] (10.624 ms) : 0, 10624
section appsec
BytebuddyAgent [baseline] (705.338 ms) : 0, 705338
BytebuddyAgent [candidate] (706.472 ms) : 0, 706472
GlobalTracer [baseline] (238.402 ms) : 0, 238402
GlobalTracer [candidate] (238.584 ms) : 0, 238584
AppSec [baseline] (176.592 ms) : 0, 176592
AppSec [candidate] (175.753 ms) : 0, 175753
Debugger [baseline] (5.978 ms) : 0, 5978
Debugger [candidate] (5.907 ms) : 0, 5907
Remote Config [baseline] (634.445 µs) : 0, 634
Remote Config [candidate] (618.644 µs) : 0, 619
Telemetry [baseline] (7.435 ms) : 0, 7435
Telemetry [candidate] (7.363 ms) : 0, 7363
IAST [baseline] (21.77 ms) : 0, 21770
IAST [candidate] (22.27 ms) : 0, 22270
section iast
BytebuddyAgent [baseline] (801.99 ms) : 0, 801990
BytebuddyAgent [candidate] (806.7 ms) : 0, 806700
GlobalTracer [baseline] (230.804 ms) : 0, 230804
GlobalTracer [candidate] (231.839 ms) : 0, 231839
AppSec [baseline] (52.329 ms) : 0, 52329
AppSec [candidate] (51.638 ms) : 0, 51638
Debugger [baseline] (5.875 ms) : 0, 5875
Debugger [candidate] (5.966 ms) : 0, 5966
Remote Config [baseline] (578.581 µs) : 0, 579
Remote Config [candidate] (587.808 µs) : 0, 588
Telemetry [baseline] (7.823 ms) : 0, 7823
Telemetry [candidate] (8.026 ms) : 0, 8026
IAST [baseline] (25.936 ms) : 0, 25936
IAST [candidate] (27.797 ms) : 0, 27797
section profiling
BytebuddyAgent [baseline] (673.141 ms) : 0, 673141
BytebuddyAgent [candidate] (677.277 ms) : 0, 677277
GlobalTracer [baseline] (374.748 ms) : 0, 374748
GlobalTracer [candidate] (375.751 ms) : 0, 375751
AppSec [baseline] (61.673 ms) : 0, 61673
AppSec [candidate] (61.997 ms) : 0, 61997
Debugger [baseline] (6.257 ms) : 0, 6257
Debugger [candidate] (6.32 ms) : 0, 6320
Remote Config [baseline] (654.743 µs) : 0, 655
Remote Config [candidate] (663.161 µs) : 0, 663
Telemetry [baseline] (8.21 ms) : 0, 8210
Telemetry [candidate] (8.296 ms) : 0, 8296
ProfilingAgent [baseline] (102.517 ms) : 0, 102517
ProfilingAgent [candidate] (103.546 ms) : 0, 103546
Profiling [baseline] (102.541 ms) : 0, 102541
Profiling [candidate] (103.57 ms) : 0, 103570
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~a333678115, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section baseline
no_agent (1.374 ms) : 1355, 1392
. : milestone, 1374,
appsec (1.757 ms) : 1734, 1780
. : milestone, 1757,
appsec_no_iast (1.743 ms) : 1720, 1766
. : milestone, 1743,
code_origins (1.676 ms) : 1648, 1704
. : milestone, 1676,
iast (1.533 ms) : 1509, 1557
. : milestone, 1533,
profiling (1.526 ms) : 1503, 1549
. : milestone, 1526,
tracing (1.52 ms) : 1495, 1545
. : milestone, 1520,
section candidate
no_agent (1.374 ms) : 1355, 1394
. : milestone, 1374,
appsec (1.752 ms) : 1729, 1776
. : milestone, 1752,
appsec_no_iast (1.752 ms) : 1728, 1776
. : milestone, 1752,
code_origins (1.702 ms) : 1673, 1730
. : milestone, 1702,
iast (1.525 ms) : 1500, 1549
. : milestone, 1525,
profiling (1.518 ms) : 1495, 1540
. : milestone, 1518,
tracing (1.497 ms) : 1474, 1520
. : milestone, 1497,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.50.0-SNAPSHOT~a333678115, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section baseline
no_agent (390.495 µs) : 371, 410
. : milestone, 390,
iast (526.207 µs) : 502, 550
. : milestone, 526,
iast_FULL (739.678 µs) : 718, 762
. : milestone, 740,
iast_GLOBAL (571.122 µs) : 549, 594
. : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (520.696 µs) : 498, 543
. : milestone, 521,
iast_INACTIVE (477.254 µs) : 454, 500
. : milestone, 477,
iast_TELEMETRY_OFF (520.703 µs) : 497, 544
. : milestone, 521,
tracing (469.367 µs) : 448, 491
. : milestone, 469,
section candidate
no_agent (383.468 µs) : 364, 403
. : milestone, 383,
iast (516.099 µs) : 494, 538
. : milestone, 516,
iast_FULL (751.05 µs) : 729, 773
. : milestone, 751,
iast_GLOBAL (578.508 µs) : 556, 601
. : milestone, 579,
iast_HARDCODED_SECRET_DISABLED (539.741 µs) : 517, 563
. : milestone, 540,
iast_INACTIVE (474.846 µs) : 452, 498
. : milestone, 475,
iast_TELEMETRY_OFF (517.735 µs) : 496, 540
. : milestone, 518,
tracing (470.089 µs) : 448, 492
. : milestone, 470,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~a333678115, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section baseline
no_agent (15.603 s) : 15603000, 15603000
. : milestone, 15603000,
appsec (14.819 s) : 14819000, 14819000
. : milestone, 14819000,
iast (18.95 s) : 18950000, 18950000
. : milestone, 18950000,
iast_GLOBAL (18.104 s) : 18104000, 18104000
. : milestone, 18104000,
profiling (15.749 s) : 15749000, 15749000
. : milestone, 15749000,
tracing (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
section candidate
no_agent (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
appsec (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
iast (19.0 s) : 19000000, 19000000
. : milestone, 19000000,
iast_GLOBAL (18.046 s) : 18046000, 18046000
. : milestone, 18046000,
profiling (15.605 s) : 15605000, 15605000
. : milestone, 15605000,
tracing (15.188 s) : 15188000, 15188000
. : milestone, 15188000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.50.0-SNAPSHOT~a333678115, baseline=1.50.0-SNAPSHOT~45c7667bff
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1501
. : milestone, 1489,
appsec (2.427 ms) : 2377, 2477
. : milestone, 2427,
iast (2.218 ms) : 2156, 2281
. : milestone, 2218,
iast_GLOBAL (2.246 ms) : 2183, 2308
. : milestone, 2246,
profiling (2.036 ms) : 1986, 2085
. : milestone, 2036,
tracing (2.027 ms) : 1979, 2076
. : milestone, 2027,
section candidate
no_agent (1.488 ms) : 1476, 1499
. : milestone, 1488,
appsec (2.433 ms) : 2383, 2483
. : milestone, 2433,
iast (2.215 ms) : 2152, 2278
. : milestone, 2215,
iast_GLOBAL (2.256 ms) : 2193, 2319
. : milestone, 2256,
profiling (2.085 ms) : 2033, 2137
. : milestone, 2085,
tracing (2.036 ms) : 1987, 2084
. : milestone, 2036,
|
|
Unlikely to have positive effect. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Tweak Gradle Daemon JVM parameters.
Motivation
Default daemon parameters:
When setting the
org.gradle.jvmargsthe default Daemon JVM parameters (that explicitly sets the MaxMetasapceSize) are clobbered.The rationals is that this memory area is unbounded by default. And this area may contain other thing than classes, so the idea is to put a sanity check on this area.
Note getting stats on the metaspace on CI is limited because the JDK 8 doesn't have
VM.metspacediagnostic command.Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]