8000 Extend JPS re-implementation to J9 family by MattAlp · Pull Request #8813 · DataDog/dd-trace-java · GitHub
[go: up one dir, main page]
Skip to content

Extend JPS re-implementation to J9 family #8813

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 13, 2025
Merged

Extend JPS re-implementation to J9 family #8813

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2691513
Read hsperfdata for Java PIDs if jvmstat is unavailable
MattAlp May 9, 2025
1dfd54f
Add equivalent to JDK os::get_temp_directory() for clean-room jvmstat…
MattAlp May 9, 2025
44ea4e6
Add a comment documenting how JVM processes are enumerated
MattAlp May 12, 2025
6e7e380
Remove unnecessary defensive path separator
MattAlp May 12, 2025
d7886c6
Spotless
MattAlp May 12, 2025
2c8d7ca
Add support for J9 equivalent of JPS
MattAlp May 13, 2025
362cedb
Merge branch 'master' into mattalp/support-jps-for-j9
MattAlp May 13, 2025
38f6879
Filter for PID files when emulating jps + nit changes
MattAlp May 13, 2025
440c832
Filter for PID files and directories, minor bugfix
MattAlp May 13, 2025
419bb40
Filter for PID files and directories, minor bugfix
MattAlp May 13, 2025
b69c69d
Replace Integer.parseInt with character-check scan
MattAlp May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a comment documenting how JVM processes are enumerated 
Co-authored-by: Jaroslav Bachorik <jaroslav.bachorik@datadoghq.com>
  • Loading branch information
@MattAlp @jbachorik
MattAlp and jbachorik authored May 12, 2025
commit 44ea4e64c997ced60e75fa6db5bbb8b6936762dd
2 changes: 2 additions & 0 deletions internal-api/src/main/java/datadog/trace/util/PidHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ public static Set<String> getJavaPids() {
// Some JDKs don't have jvmstat available as a module, attempt to read from the hsperfdata
// directory instead
try (Stream<Path> stream =
// Emulating the hotspot way to enumerate the JVM processes using the perfdata file
// https://github.com/openjdk/jdk/blob/d7cb933b89839b692f5562aeeb92076cd25a99f6/src/hotspot/share/runtime/perfMemory.cpp#L244
Files.list(Paths.get(getOSTempDir() + "/hsperfdata_" + System.getProperty("user.name")))) {
return stream
.filter(file -> !Files.isDirectory(file))
Expand Down
Loading
0