-
Notifications
You must be signed in to change notification settings - Fork 306
Revert "Use OpenLineage root parent information to generate trace id" #8737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Use OpenLineage root parent information to generate trace id" #8737
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~5baa904874, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.008 s) : 0, 1007868
Total [baseline] (8.662 s) : 0, 8662288
Agent [candidate] (1.006 s) : 0, 1006372
Total [candidate] (8.638 s) : 0, 8638338
section iast
Agent [baseline] (1.134 s) : 0, 1134469
Total [baseline] (9.204 s) : 0, 9203789
Agent [candidate] (1.137 s) : 0, 1137438
Total [candidate] (9.186 s) : 0, 9185749
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.148 s) : 0, 1147736
Total [baseline] (9.175 s) : 0, 9175434
Agent [candidate] (1.136 s) : 0, 1136160
Total [candidate] (9.177 s) : 0, 9176856
section iast_TELEMETRY_OFF
Agent [baseline] (1.133 s) : 0, 1133298
Total [baseline] (9.184 s) : 0, 9183674
Agent [candidate] (1.141 s) : 0, 1140591
Total [candidate] (9.217 s) : 0, 9216675
gantt
title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~5baa904874, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (670.059 ms) : 0, 670059
BytebuddyAgent [candidate] (669.503 ms) : 0, 669503
GlobalTracer [baseline] (239.984 ms) : 0, 239984
GlobalTracer [candidate] (239.927 ms) : 0, 239927
AppSec [baseline] (54.612 ms) : 0, 54612
AppSec [candidate] (54.584 ms) : 0, 54584
Debugger [baseline] (6.127 ms) : 0, 6127
Debugger [candidate] (6.149 ms) : 0, 6149
Remote Config [baseline] (705.936 µs) : 0, 706
Remote Config [candidate] (706.712 µs) : 0, 707
Telemetry [baseline] (12.994 ms) : 0, 12994
Telemetry [candidate] (12.23 ms) : 0, 12230
section iast
BytebuddyAgent [baseline] (788.366 ms) : 0, 788366
BytebuddyAgent [candidate] (789.062 ms) : 0, 789062
GlobalTracer [baseline] (229.734 ms) : 0, 229734
GlobalTracer [candidate] (231.311 ms) : 0, 231311
IAST [bas
8000
eline] (22.564 ms) : 0, 22564
IAST [candidate] (22.988 ms) : 0, 22988
AppSec [baseline] (56.302 ms) : 0, 56302
AppSec [candidate] (56.263 ms) : 0, 56263
Debugger [baseline] (5.825 ms) : 0, 5825
Debugger [candidate] (5.885 ms) : 0, 5885
Remote Config [baseline] (590.385 µs) : 0, 590
Remote Config [candidate] (609.839 µs) : 0, 610
Telemetry [baseline] (7.799 ms) : 0, 7799
Telemetry [candidate] (7.939 ms) : 0, 7939
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (799.217 ms) : 0, 799217
BytebuddyAgent [candidate] (788.619 ms) : 0, 788619
GlobalTracer [baseline] (231.532 ms) : 0, 231532
GlobalTracer [candidate] (230.304 ms) : 0, 230304
IAST [baseline] (22.993 ms) : 0, 22993
IAST [candidate] (22.887 ms) : 0, 22887
AppSec [baseline] (56.003 ms) : 0, 56003
AppSec [candidate] (56.418 ms) : 0, 56418
Debugger [baseline] (5.849 ms) : 0, 5849
Debugger [candidate] (5.933 ms) : 0, 5933
Remote Config [baseline] (589.327 µs) : 0, 589
Remote Config [candidate] (582.442 µs) : 0, 582
Telemetry [baseline] (7.871 ms) : 0, 7871
Telemetry [candidate] (7.903 ms) : 0, 7903
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (786.92 ms) : 0, 786920
BytebuddyAgent [candidate] (791.868 ms) : 0, 791868
GlobalTracer [baseline] (230.018 ms) : 0, 230018
GlobalTracer [candidate] (231.75 ms) : 0, 231750
IAST [baseline] (22.336 ms) : 0, 22336
IAST [candidate] (22.6 ms) : 0, 22600
AppSec [baseline] (56.608 ms) : 0, 56608
AppSec [candidate] (56.607 ms) : 0, 56607
Debugger [baseline] (5.847 ms) : 0, 5847
Debugger [candidate] (5.981 ms) : 0, 5981
Remote Config [baseline] (611.349 µs) : 0, 611
Remote Config [candidate] (609.216 µs) : 0, 609
Telemetry [baseline] (7.666 ms) : 0, 7666
Telemetry [candidate] (7.786 ms) : 0, 7786
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~5baa904874, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.007 s) : 0, 1007140
Total [baseline] (10.505 s) : 0, 10505443
Agent [candidate] (1.007 s) : 0, 1007263
Total [candidate] (10.479 s) : 0, 10478645
section appsec
Agent [baseline] (1.145 s) : 0, 1145361
Total [baseline] (10.655 s) : 0, 10654513
Agent [candidate] (1.149 s) : 0, 1148650
Total [candidate] (10.647 s) : 0, 10647086
section iast
Agent [baseline] (1.138 s) : 0, 1137587
Total [baseline] (10.867 s) : 0, 10867431
Agent [candidate] (1.145 s) : 0, 1144689
Total [candidate] (10.89 s) : 0, 10890016
section profiling
Agent [baseline] (1.257 s) : 0, 1257268
Total [baseline] (10.807 s) : 0, 10806904
Agent [candidate] (1.258 s) : 0, 1258359
Total [candidate] (10.797 s) : 0, 10797379
gantt
title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~5baa904874, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.265 ms) : 0, 669265
BytebuddyAgent [candidate] (670.755 ms) : 0, 670755
GlobalTracer [baseline] (240.664 ms) : 0, 240664
GlobalTracer [candidate] (240.629 ms) : 0, 240629
AppSec [baseline] (54.787 ms) : 0, 54787
AppSec [candidate] (54.73 ms) : 0, 54730
Debugger [baseline] (6.143 ms) : 0, 6143
Debugger [candidate] (6.155 ms) : 0, 6155
Remote Config [baseline] (697.635 µs) : 0, 698
Remote Config [candidate] (719.009 µs) : 0, 719
Telemetry [baseline] (12.087 ms) : 0, 12087
Telemetry [candidate] (10.805 ms) : 0, 10805
section appsec
BytebuddyAgent [baseline] (685.918 ms) : 0, 685918
BytebuddyAgent [candidate] (687.97 ms) : 0, 687970
GlobalTracer [baseline] (235.768 ms) : 0, 235768
GlobalTracer [candidate] (236.84 ms) : 0, 236840
AppSec [baseline] (174.865 ms) : 0, 174865
AppSec [candidate] (174.955 ms) : 0, 174955
Debugger [baseline] (5.858 ms) : 0, 5858
Debugger [candidate] (5.889 ms) : 0, 5889
Remote Config [baseline] (646.951 µs) : 0, 647
Remote Config [candidate] (640.036 µs) : 0, 640
Telemetry [baseline] (8.127 ms) : 0, 8127
Telemetry [candidate] (8.127 ms) : 0, 8127
IAST [baseline] (21.728 ms) : 0, 21728
IAST [candidate] (21.744 ms) : 0, 21744
section iast
BytebuddyAgent [baseline] (790.723 ms) : 0, 790723
BytebuddyAgent [candidate] (795.409 ms) : 0, 795409
GlobalTracer [baseline] (230.145 ms) : 0, 230145
GlobalTracer [candidate] (231.689 ms) : 0, 231689
AppSec [baseline] (56.329 ms) : 0, 56329
AppSec [candidate] (56.601 ms) : 0, 56601
Debugger [baseline] (5.881 ms) : 0, 5881
Debugger [candidate] (5.964 ms) : 0, 5964
Remote Config [baseline] (588.464 µs) : 0, 588
Remote Config [candidate] (608.098 µs) : 0, 608
Telemetry [baseline] (7.877 ms) : 0, 7877
Telemetry [candidate] (7.966 ms) : 0, 7966
IAST [baseline] (22.669 ms) : 0, 22669
IAST [candidate] (22.964 ms) : 0, 22964
section profiling
BytebuddyAgent [baseline] (664.683 ms) : 0, 664683
BytebuddyAgent [candidate] (665.852 ms) : 0, 665852
GlobalTracer [baseline] (375.196 ms) : 0, 375196
GlobalTracer [candidate] (376.649 ms) : 0, 376649
AppSec [baseline] (54.616 ms) : 0, 54616
AppSec [candidate] (53.508 ms) : 0, 53508
Debugger [baseline] (6.166 ms) : 0, 6166
Debugger [candidate] (6.134 ms) : 0, 6134
Remote Config [baseline] (652.353 µs) : 0, 652
Remote Config [candidate] (648.943 µs) : 0, 649
Telemetry [baseline] (8.233 ms) : 0, 8233
Telemetry [candidate] (8.117 ms) : 0, 8117
ProfilingAgent [baseline] (97.499 ms) : 0, 97499
ProfilingAgent [candidate] (97.222 ms) : 0, 97222
Profiling [baseline] (97.524 ms) : 0, 97524
Profiling [candidate] (97.246 ms) : 0, 97246
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~5baa904874, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section baseline
no_agent (1.366 ms) : 1347, 1386
. : milestone, 1366,
appsec (1.736 ms) : 1713, 1759
. : milestone, 1736,
appsec_no_iast (1.732 ms) : 1708, 1756
. : milestone, 1732,
code_origins (1.685 ms) : 1658, 1711
. : milestone, 1685,
iast (1.516 ms) : 1492, 1540
. : milestone, 1516,
profiling (1.543 ms) : 1518, 1567
. : milestone, 1543,
tracing (1.495 ms) : 1471, 1520
. : milestone, 1495,
section candidate
no_agent (1.368 ms) : 1347, 1388
. : milestone, 1368,
appsec (1.747 ms) : 1724, 1770
. : milestone, 1747,
appsec_no_iast (1.731 ms) : 1707, 1754
. : milestone, 1731,
code_origins (1.676 ms) : 1649, 1703
. : milestone, 1676,
iast (1.518 ms) : 1493, 1542
. : milestone, 1518,
profiling (1.516 ms) : 1492, 1540
. : milestone, 1516,
tracing (1.486 ms) : 1460, 1511
. : milestone, 1486,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~5baa904874, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section baseline
no_agent (379.811 µs) : 360, 400
. : milestone, 380,
iast (518.815 µs) : 495, 542
. : milestone, 519,
iast_FULL (735.945 µs) : 713, 759
. : milestone, 736,
iast_GLOBAL (580.911 µs) : 557, 605
. : milestone, 581,
iast_HARDCODED_SECRET_DISABLED (513.785 µs) : 491, 537
. : milestone, 514,
iast_INACTIVE (473.457 µs) : 451, 496
. : milestone, 473,
iast_TELEMETRY_OFF (505.66 µs) : 483, 528
. : milestone, 506,
tracing (461.104 µs) : 439, 483
. : milestone, 461,
section candidate
no_agent (386.683 µs) : 367, 406
. : milestone, 387,
iast (519.133 µs) : 496, 543
. : milestone, 519,
iast_FULL (735.502 µs) : 712, 759
. : milestone, 736,
iast_GLOBAL (578.096 µs) : 555, 602
. : milestone, 578,
iast_HARDCODED_SECRET_DISABLED (523.152 µs) : 500, 546
. : milestone, 523,
iast_INACTIVE (468.396 µs) : 446, 491
. : milestone, 468,
iast_TELEMETRY_OFF (517.084 µs) : 494, 540
. : milestone, 517,
tracing (463.083 µs) : 440, 486
. : milestone, 463,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~5baa904874, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section baseline
no_agent (15.493 s) : 15493000, 15493000
. : milestone, 15493000,
appsec (14.975 s) : 14975000, 14975000
. : milestone, 14975000,
iast (18.137 s) : 18137000, 18137000
. : milestone, 18137000,
iast_GLOBAL (18.246 s) : 18246000, 18246000
. : milestone, 18246000,
profiling (15.126 s) : 15126000, 15126000
. : milestone, 15126000,
tracing (15.092 s) : 15092000, 15092000
. : milestone, 15092000,
section candidate
no_agent (15.234 s) : 15234000, 15234000
. : milestone, 15234000,
appsec (14.85 s) : 14850000, 14850000
. : milestone, 14850000,
iast (18.55 s) : 18550000, 18550000
. : milestone, 18550000,
iast_GLOBAL (18.09 s) : 18090000, 18090000
. : milestone, 18090000,
profiling (15.532 s) : 15532000, 15532000
. : milestone, 15532000,
tracing (15.217 s) : 15217000, 15217000
. : milestone, 15217000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~5baa904874, baseline=1.49.0-SNAPSHOT~75634fe423
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.373 ms) : 2326, 2420
. : milestone, 2373,
iast (2.152 ms) : 2093, 2211
. : milestone, 2152,
iast_GLOBAL (2.189 ms) : 2130, 2248
. : milestone, 2189,
profiling (1.996 ms) : 1950, 2043
. : milestone, 1996,
tracing (1.985 ms) : 1940, 2030
. : milestone, 1985,
section candidate
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (2.373 ms) : 2326, 2419
. : milestone, 2373,
iast (2.16 ms) : 2101, 2220
. : milestone, 2160,
iast_GLOBAL (2.197 ms) : 2138, 2256
. : milestone, 2197,
profiling (1.997 ms) : 1950, 2044
. : milestone, 1997,
tracing (1.967 ms) : 1923, 2012
. : milestone, 1967,
|
Closing because changes in #8731 resolve the test breaking |
Reverts #8726
It seems to break master: https://app.circleci.com/pipelines/github/DataDog/dd-trace-java/48191/workflows/b9565ed9-48d0-4641-bc30-a1fbc891e248/jobs/1885561/tests#failed-test-0