8000 Fix In-Product when config is empty by jpbempel · Pull Request #8679 · DataDog/dd-trace-java · GitHub
[go: up one dir, main page]
Skip to content

Fix In-Product when config is empty #8679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Fix In-Product when config is empty #8679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix In-Product when config is empty 
should not stop the product with empty config
  • Loading branch information
@jpbempel
jpbempel committed Apr 7, 2025
commit 96fb92f868332671ae13d5f3282b12b7f74f098f
10 changes: 6 additions & 4 deletions .../agent-debugger/src/main/java/com/datadog/debugger/agent/DefaultProductConfigUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,12 @@ private static void startOrStopFeature(
LOGGER.debug("Feature {} is explicitly disabled", booleanKey);
return;
}
if (currentStatus != null && currentStatus) {
start.run();
} else {
stop.run();
if (currentStatus != null) {
if (currentStatus) {
start.run();
} else {
stop.run();
}
}
}
}
5 changes: 5 additions & 0 deletions ...nt-debugger/src/test/java/com/datadog/debugger/agent/DefaultProductConfigUpdaterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ public void enableDisable() {
assertTrue(productConfigUpdater.isExceptionReplayEnabled());
assertTrue(productConfigUpdater.isCodeOriginEnabled());
assertTrue(productConfigUpdater.isDistributedDebuggerEnabled());
productConfigUpdater.updateConfig(null, null, null, null);
assertTrue(productConfigUpdater.isDynamicInstrumentationEnabled());
assertTrue(productConfigUpdater.isExceptionReplayEnabled());
assertTrue(productConfigUpdater.isCodeOriginEnabled());
assertTrue(productConfigUpdater.isDistributedDebuggerEnabled());
productConfigUpdater.updateConfig(false, false, false, false);
assertFalse(productConfigUpdater.isDynamicInstrumentationEnabled());
assertFalse(productConfigUpdater.isExceptionReplayEnabled());
Expand Down
Loading
0