8000 Remove AttachableWrapper aspect from scopes by mcculls · Pull Request #8570 · DataDog/dd-trace-java · GitHub
[go: up one dir, main page]
Skip to content

Remove AttachableWrapper aspect from scopes #8570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove AttachableWrapper aspect from scopes #8570

wants to merge 1 commit into from

Conversation

mcculls
Copy link
Contributor
@mcculls mcculls commented Mar 15, 2025 •
edited by jira bot
Loading

Motivation

In the majority of cases the scope wrapper will only be accessed once when activating a span or context. The other cases are deprecated calls to check the active scope, where the returned scope wrapper is short-lived and cheap to recreate.

Additional Notes

This brings #8534 over to the master branch

Contributor Checklist

Jira ticket: APMAPI-960

@mcculls
Remove AttachableWrapper aspect from scopes
8462
1e0b228 
In the majority of cases the scope wrapper will only be accessed once when
activating a span or context. The other cases are deprecated calls to check
the active scope, where the returned scope wrapper is short-lived and cheap
to recreate.
@mcculls mcculls added comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring labels Mar 15, 2025
@mcculls mcculls closed this Mar 15, 2025
@mcculls mcculls deleted the mcculls/remove-attachable-wrapper-from-scopes branch March 15, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comp: core Tracer core tag: no release notes Changes to exclude from release notes type: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mcculls
0