Remove unused activeScope method #8531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
637ba61 to
141d4d5
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.48.0-SNAPSHOT~daa69f42ed, baseline=1.48.0-SNAPSHOT~a464b9bfb9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1039964
Total [baseline] (10.497 s) : 0, 10496745
Agent [candidate] (1.048 s) : 0, 1048254
Total [candidate] (10.548 s) : 0, 10548061
section appsec
Agent [baseline] (1.186 s) : 0, 1185620
Total [baseline] (10.768 s) : 0, 10767886
Agent [candidate] (1.181 s) : 0, 1181473
Total [candidate] (10.758 s) : 0, 10758369
section iast
Agent [baseline] (1.177 s) : 0, 1176616
Total [baseline] (11.025 s) : 0, 11024786
Agent [candidate] (1.169 s) : 0, 1168763
Total [candidate] (10.95 s) : 0, 10950337
section profiling
Agent [baseline] (1.271 s) : 0, 1270857
Total [baseline] (10.842 s) : 0, 10841612
Agent [candidate] (1.256 s) : 0, 1256010
Total [candidate] (10.896 s) : 0, 10895508
gantt
title petclinic - break down per module: candidate=1.48.0-SNAPSHOT~daa69f42ed, baseline=1.48.0-SNAPSHOT~a464b9bfb9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.117 ms) : 0, 718117
BytebuddyAgent [candidate] (721.42 ms) : 0, 721420
GlobalTracer [baseline] (239.424 ms) : 0, 239424
GlobalTracer [candidate] (240.503 ms) : 0, 240503
AppSec [baseline] (55.33 ms) : 0, 55330
AppSec [candidate] (55.581 ms) : 0, 55581
Remote Config [baseline] (687.118 µs) : 0, 687
Remote Config [candidate] (693.971 µs) : 0, 694
Telemetry [baseline] (11.603 ms) : 0, 11603
Telemetry [candidate] (15.014 ms) : 0, 15014
section appsec
BytebuddyAgent [baseline] (738.103 ms) : 0, 738103
BytebuddyAgent [candidate] (734.151 ms) : 0, 734151
GlobalTracer [baseline] (236.636 ms) : 0, 236636
GlobalTracer [candidate] (236.215 ms) : 0, 236215
AppSec [baseline] (176.372 ms) : 0, 176372
AppSec [candidate] (176.561 ms) : 0, 176561
Remote Config [baseline] (659.384 µs) : 0, 659
Remote Config [candidate] (659.135 µs) : 0, 659
Telemetry [baseline] (8.302 ms) : 0, 8302
Telemetry [candidate] (8.31 ms) : 0, 8310
IAST [baseline] (21.236 ms) : 0, 21236
IAST [candidate] (21.457 ms) : 0, 21457
section iast
BytebuddyAgent [baseline] (841.281 ms) : 0, 841281
BytebuddyAgent [candidate] (834.59 ms) : 0, 834590
GlobalTracer [baseline] (230.673 ms) : 0, 230673
GlobalTracer [candidate] (229.769 ms) : 0, 229769
AppSec [baseline] (57.131 ms) : 0, 57131
AppSec [candidate] (57.079 ms) : 0, 57079
Remote Config [baseline] (626.105 µs) : 0, 626
Remote Config [candidate] (610.465 µs) : 0, 610
Telemetry [baseline] (8.863 ms) : 0, 8863
Telemetry [candidate] (8.754 ms) : 0, 8754
IAST [baseline] (23.052 ms) : 0, 23052
IAST [candidate] (23.014 ms) : 0, 23014
section profiling
ProfilingAgent [baseline] (97.394 ms) : 0, 97394
ProfilingAgent [candidate] (95.34 ms) : 0, 95340
BytebuddyAgent [baseline] (714.947 ms) : 0, 714947
BytebuddyAgent [candidate] (707.448 ms) : 0, 707448
GlobalTracer [baseline] (352.41 ms) : 0, 352410
GlobalTracer [candidate] (349.528 ms) : 0, 349528
AppSec [baseline] (55.678 ms) : 0, 55678
AppSec [candidate] (53.742 ms) : 0, 53742
Remote Config [baseline] (681.495 µs) : 0, 681
Remote Config [candidate] (669.481 µs) : 0, 669
Telemetry [baseline] (9.053 ms) : 0, 9053
Telemetry [candidate] (9.034 ms) : 0, 9034
Profiling [baseline] (97.419 ms) : 0, 97419
Profiling [candidate] (95.364 ms) : 0, 95364
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.48.0-SNAPSHOT~daa69f42ed, baseline=1.48.0-SNAPSHOT~a464b9bfb9
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1044417
Total [baseline] (8.665 s) : 0, 8664732
Agent [candidate] (1.038 s) : 0, 1037933
Total [candidate] (8.663 s) : 0, 8663165
section iast
Agent [baseline] (1.175 s) : 0, 1174725
Total [baseline] (9.211 s) : 0, 9211170
Agent [candidate] (1.173 s) : 0, 1172937
Total [candidate] (9.259 s) : 0, 9258629
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.17 s) : 0, 1169571
Total [baseline] (9.184 s) : 0, 9184282
Agent [candidate] (1.172 s) : 0, 1172163
Total [candidate] (9.22 s) : 0, 9220329
section iast_TELEMETRY_OFF
Agent [baseline] (1.168 s) : 0, 1167645
Total [baseline] (9.24 s) : 0, 9239641
Agent [candidate] (1.166 s) : 0, 1166248
Total [candidate] (9.184 s) : 0, 9183959
gantt
title insecure-bank - break down per module: candidate=1.48.0-SNAPSHOT~daa69f42ed, baseline=1.48.0-SNAPSHOT~a464b9bfb9
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.363 ms) : 0, 719363
BytebuddyAgent [candidate] (717.05 ms) : 0, 717050
GlobalTracer [baseline] (239.997 ms) : 0, 239997
GlobalTracer [candidate] (238.845 ms) : 0, 238845
AppSec [baseline] (55.294 ms) : 0, 55294
AppSec [candidate] (55.058 ms) : 0, 55058
Remote Config [baseline] (685.669 µs) : 0, 686
Remote Config [candidate] (690.041 µs) : 0, 690
Telemetry [baseline] (14.223 ms) : 0, 14223
Telemetry [candidate] (11.454 ms) : 0, 11454
section iast
BytebuddyAgent [baseline] (840.405 ms) : 0, 840405
BytebuddyAgent [candidate] (837.327 ms) : 0, 837327
GlobalTracer [baseline] (230.392 ms) : 0, 230392
GlobalTracer [candidate] (231.276 ms) : 0, 231276
IAST [baseline] (22.941 ms) : 0, 22941
IAST [candidate] (23.187 ms) : 0, 23187
AppSec [baseline] (56.734 ms) : 0, 56734
AppSec [candidate] (56.864 ms) : 0, 56864
Remote Config [baseline] (621.568 µs) : 0, 622
Remote Config [candidate] (615.149 µs) : 0, 615
Telemetry [baseline] (8.737 ms) : 0, 8737
Telemetry [candidate] (8.792 ms) : 0, 8792
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.346 ms) : 0, 835346
BytebuddyAgent [candidate] (837.564 ms) : 0, 837564
GlobalTracer [baseline] (230.516 ms) : 0, 230516
GlobalTracer [candidate] (230.619 ms) : 0, 230619
IAST [baseline] (22.866 ms) : 0, 22866
IAST [candidate] (22.884 ms) : 0, 22884
AppSec [baseline] (56.712 ms) : 0, 56712
AppSec [candidate] (56.791 ms) : 0, 56791
Remote Config [baseline] (598.444 µs) : 0, 598
Remote Config [candidate] (611.61 µs) : 0, 612
Telemetry [baseline] (8.696 ms) : 0, 8696
Telemetry [candidate] (8.715 ms) : 0, 8715
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.652 ms) : 0, 834652
BytebuddyAgent [candidate] (832.677 ms) : 0, 832677
GlobalTracer [baseline] (230.02 ms) : 0, 230020
GlobalTracer [candidate] (230.045 ms) : 0, 230045
IAST [baseline] (22.329 ms) : 0, 22329
IAST [candidate] (22.324 ms) : 0, 22324
AppSec [baseline] (56.617 ms) : 0, 56617
AppSec [candidate] (56.993 ms) : 0, 56993
Remote Config [baseline] (607.305 µs) : 0, 607
Remote Config [candidate] (610.818 µs) : 0, 611
Telemetry [baseline] (8.612 ms) : 0, 8612
Telemetry [candidate] (8.685 ms) : 0, 8685
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 12 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~daa69f42ed, baseline=1.48.0-SNAPSHOT~a464b9bfb9
dateFormat X
axisFormat %s
section baseline
no_agent (378.377 µs) : 358, 399
. : milestone, 378,
iast (508.097 µs) : 486, 530
. : milestone, 508,
iast_FULL (726.508 µs) : 705, 748
. : milestone, 727,
iast_GLOBAL (557.286 µs) : 535, 579
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (507.556 µs) : 486, 529
. : milestone, 508,
iast_INACTIVE (462.384 µs) : 441, 484
. : milestone, 462,
iast_TELEMETRY_OFF (499.853 µs) : 478, 522
. : milestone, 500,
tracing (460.073 µs) : 439, 481
. : milestone, 460,
section candidate
no_agent (374.489 µs) : 354, 395
. : milestone, 374,
iast (504.971 µs) : 483, 527
. : milestone, 505,
iast_FULL (725.432 µs) : 703, 747
. : milestone, 725,
iast_GLOBAL (557.331 µs) : 536, 579
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (510.31 µs) : 488, 533
. : milestone, 510,
iast_INACTIVE (465.418 µs) : 444, 487
. : milestone, 465,
iast_TELEMETRY_OFF (490.445 µs) : 469, 512
. : milestone, 490,
tracing (458.227 µs) : 436, 480
. : milestone, 458,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.48.0-SNAPSHOT~daa69f42ed, baseline=1.48.0-SNAPSHOT~a464b9bfb9
dateFormat X
axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1374
. : milestone, 1354,
appsec (1.722 ms) : 1698, 1745
. : milestone, 1722,
appsec_no_iast (1.742 ms) : 1717, 1766
. : milestone, 1742,
code_origins (1.669 ms) : 1636, 1701
. : milestone, 1669,
iast (1.511 ms) : 1488, 1535
. : milestone, 1511,
profiling (1.517 ms) : 1492, 1542
. : milestone, 1517,
tracing (1.49 ms) : 1466, 1515
. : milestone, 1490,
section candidate
no_agent (1.361 ms) : 1342, 1381
. : milestone, 1361,
appsec (1.745 ms) : 1721, 1768
. : milestone, 1745,
appsec_no_iast (1.745 ms) : 1721, 1768
. : milestone, 1745,
code_origins (1.685 ms) : 1652, 1717
. : milestone, 1685,
iast (1.483 ms) : 1460, 1507
. : milestone, 1483,
profiling (1.577 ms) : 1553, 1602
. : milestone, 1577,
tracing (1.493 ms) : 1468, 1517
. : milestone, 1493,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~daa69f42ed, baseline=1.48.0-SNAPSHOT~a464b9bfb9
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.335 ms) : 2291, 2379
. : milestone, 2335,
iast (2.112 ms) : 2055, 2168
. : milestone, 2112,
iast_GLOBAL (2.148 ms) : 2092, 2204
. : milestone, 2148,
profiling (1.98 ms) : 1934, 2025
. : milestone, 1980,
tracing (1.941 ms) : 1899, 1984
. : milestone, 1941,
section candidate
no_agent (1.471 ms) : 1459, 1482
. : milestone, 1471,
appsec (2.329 ms) : 2285, 2372
. : milestone, 2329,
iast (2.11 ms) : 2055, 2165
. : milestone, 2110,
iast_GLOBAL (2.147 ms) : 2092, 2203
. : milestone, 2147,
profiling (2.433 ms) : 2250, 2616
. : milestone, 2433,
tracing (1.948 ms) : 1905, 1991
. : milestone, 1948,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.48.0-SNAPSHOT~daa69f42ed, baseline=1.48.0-SNAPSHOT~a464b9bfb9
dateFormat X
axisFormat %s
section baseline
no_agent (15.317 s) : 15317000, 15317000
. : milestone, 15317000,
appsec (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
iast (18.777 s) : 18777000, 18777000
. : milestone, 18777000,
iast_GLOBAL (17.958 s) : 17958000, 17958000
. : milestone, 17958000,
profiling (15.068 s) : 15068000, 15068000
. : milestone, 15068000,
tracing (14.7 s) : 14700000, 14700000
. : milestone, 14700000,
section candidate
no_agent (14.754 s) : 14754000, 14754000
. : milestone, 14754000,
appsec (15.032 s) : 15032000, 15032000
. : milestone, 15032000,
iast (18.259 s) : 18259000, 18259000
. : milestone, 18259000,
iast_GLOBAL (18.184 s) : 18184000, 18184000
. : milestone, 18184000,
profiling (15.264 s) : 15264000, 15264000
. : milestone, 15264000,
tracing (14.863 s) : 14863000, 14863000
. : milestone, 14863000,
|
PerfectSlayer
approved these changes
Mar 10, 2025
5c793f8 to
591efc8
Compare
41bde60 to
daa69f4
Compare
Base automatically changed from
mcculls/use-context-for-otel-shim
to
project/context
March 10, 2025 16:06
daa69f4 to
2e3f57f
Compare
mcculls
added a commit
that referenced
this pull request
Mar 15, 2025
mcculls
added a commit
that referenced
this pull request
Mar 17, 2025
mcculls
added a commit
that referenced
this pull request
Mar 18, 2025
mcculls
added a commit
that referenced
this pull request
Mar 18, 2025
mcculls
added a commit
that referenced
this pull request
Mar 18, 2025
mcculls
added a commit
that referenced
this pull request
Mar 19, 2025
mcculls
added a commit
that referenced
this pull request
Mar 21, 2025
mcculls
added a commit
that referenced
this pull request
Mar 26, 2025
mcculls
added a commit
that referenced
this pull request
Mar 31, 2025
mcculls
added a commit
that referenced
this pull request
Apr 1, 2025
mcculls
added a commit
that referenced
this pull request
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Notes
Tests are expected to fail while the scope manager has not yet been replaced.
That's why the final target of this stacked PR is the
project/contextfeature branch.Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APMAPI-956