-
Notifications
You must be signed in to change notification settings - Fork 305
Move ClassName filtering initialization #8507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
move the the classname filtering when actual feature are enabled because it adds some overhead at startup to read and parse the third-party list
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
Debugger benchmarksParameters
See matching parameters
SummaryFound 5 performance improvements and 0 performance regressions! Performance is the same for 5 metrics, 5 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (317.164 µs) : 278, 357
. : milestone, 317,
basic (315.057 µs) : 303, 327
. : milestone, 315,
loop (10.73 ms) : 10675, 10785
. : milestone, 10730,
section candidate
noprobe (311.36 µs) : 280, 343
. : milestone, 311,
basic (304.692 µs) : 298, 311
. : milestone, 305,
loop (10.199 ms) : 10164, 10234
. : milestone, 10199,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 11 performance improvements and 1 performance regressions! Performance is the same for 54 metrics, 5 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~184a2e10dd, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.137 s) : 0, 1137480
Total [baseline] (9.266 s) : 0, 9266382
Agent [candidate] (1.13 s) : 0, 1129601
Total [candidate] (9.224 s) : 0, 9224351
section iast
Agent [baseline] (1.266 s) : 0, 1266458
Total [baseline] (9.879 s) : 0, 9879376
Agent [candidate] (1.255 s) : 0, 1254746
Total [candidate] (9.848 s) : 0, 9847555
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.258 s) : 0, 1258356
Total [baseline] (9.835 s) : 0, 9835351
Agent [candidate] (1.259 s) : 0, 1259150
Total [candidate] (9.815 s) : 0, 9815201
section iast_TELEMETRY_OFF
Agent [baseline] (1.252 s) : 0, 1252096
Total [baseline] (9.851 s) : 0, 9851287
Agent [candidate] (1.239 s) : 0, 1239440
Total [candidate] (9.804 s) : 0, 9803519
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~184a2e10dd, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.52 ms) : 0, 718520
BytebuddyAgent [candidate] (722.115 ms) : 0, 722115
GlobalTracer [baseline] (240.45 ms) : 0, 240450
GlobalTracer [candidate] (241.823 ms) : 0, 241823
AppSec [baseline] (55.492 ms) : 0, 55492
AppSec [candidate] (56.346 ms) : 0, 56346
Debugger [baseline] (95.099 ms) : 0, 95099
Debugger [candidate] (81.643 ms) : 0, 81643
Remote Config [baseline] (595.673 µs) : 0, 596
Remote Config [candidate] (592.286 µs) : 0, 592
Telemetry [baseline] (12.371 ms) : 0, 12371
Telemetry [candidate] (11.971 ms) : 0, 11971
section iast
BytebuddyAgent [baseline] (838.467 ms) : 0, 838467
BytebuddyAgent [candidate] (844.449 ms) : 0, 844449
GlobalTracer [baseline] (230.322 ms) : 0, 230322
GlobalTracer [candidate] (232.157 ms) : 0, 232157
AppSec [baseline] (57.119 ms) : 0, 57119
AppSec [candidate] (57.371 ms) : 0, 57371
Debugger [baseline] (83.638 ms) : 0, 83638
Debugger [candidate] (70.148 ms) : 0, 70148
Remote Config [baseline] (520.245 µs) : 0, 520
Remote Config [candidate] (499.642 µs) : 0, 500
Telemetry [baseline] (18.286 ms) : 0, 18286
Telemetry [candidate] (12.064 ms) : 0, 12064
IAST [baseline] (23.117 ms) : 0, 23117
IAST [candidate] (23.013 ms) : 0, 23013
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (835.103 ms) : 0, 835103
BytebuddyAgent [candidate] (847.055 ms) : 0, 847055
GlobalTracer [baseline] (230.399 ms) : 0, 230399
GlobalTracer [candidate] (232.726 ms) : 0, 232726
AppSec [baseline] (57.399 ms) : 0, 57399
AppSec [candidate] (57.788 ms) : 0, 57788
Debugger [baseline] (83.546 ms) : 0, 83546
Debugger [candidate] (70.509 ms) : 0, 70509
Remote Config [baseline] (520.916 µs) : 0, 521
Remote Config [candidate] (492.57 µs) : 0, 493
Telemetry [baseline] (13.516 ms) : 0, 13516
Telemetry [candidate] (12.045 ms) : 0, 12045
IAST [baseline] (22.943 ms) : 0, 22943
IAST [candidate] (23.433 ms) : 0, 23433
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (832.945 ms) : 0, 832945
BytebuddyAgent [candidate] (832.624 ms) : 0, 832624
GlobalTracer [baseline] (229.544 ms) : 0, 229544
GlobalTracer [candidate] (230.174 ms) : 0, 230174
AppSec [baseline] (55.85 ms) : 0, 55850
AppSec [candidate] (57.094 ms) : 0, 57094
Debugger [baseline] (83.058 ms) : 0, 83058
Debugger [candidate] (69.856 ms) : 0, 69856
Remote Config [baseline] (528.621 µs) : 0, 529
Remote Config [candidate] (500.075 µs) : 0, 500
Telemetry [baseline] (12.012 ms) : 0, 12012
Telemetry [candidate] (11.821 ms) : 0, 11821
IAST [baseline] (23.157 ms) : 0, 23157
IAST [candidate] (22.385 ms) : 0, 22385
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~184a2e10dd, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.136 s) : 0, 1135780
Total [baseline] (11.475 s) : 0, 11475144
Agent [candidate] (1.12 s) : 0, 1120022
Total [candidate] (11.372 s) : 0, 11371967
section appsec
Agent [baseline] (1.276 s) : 0, 1276340
Total [baseline] (11.656 s) : 0, 11656161
Agent [candidate] (1.258 s) : 0, 1258291
Total [candidate] (11.676 s) : 0, 11676030
section iast
Agent [baseline] (1.262 s) : 0, 1262357
Total [baseline] (11.959 s) : 0, 11959435
Agent [candidate] (1.244 s) : 0, 1244106
Total [candidate] (12.03 s) : 0, 12030424
section profiling
Agent [baseline] (1.376 s) : 0, 1376034
Total [baseline] (11.769 s) : 0, 11769086
Agent [candidate] (1.366 s) : 0, 1366470
Total [candidate] (11.844 s) : 0, 11844059
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~184a2e10dd, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.546 ms) : 0, 717546
BytebuddyAgent [candidate] (716.203 ms) : 0, 716203
GlobalTracer [baseline] (240.012 ms) : 0, 240012
GlobalTracer [candidate] (239.271 ms) : 0, 239271
AppSec [baseline] (55.661 ms) : 0, 55661
AppSec [candidate] (55.64 ms) : 0, 55640
Debugger [baseline] (94.666 ms) : 0, 94666
Debugger [candidate] (81.256 ms) : 0, 81256
Remote Config [baseline] (572.89 µs) : 0, 573
Remote Config [candidate] (608.469 µs) : 0, 608
Telemetry [baseline] (12.385 ms) : 0, 12385
Telemetry [candidate] (12.013 ms) : 0, 12013
section appsec
BytebuddyAgent [baseline] (738.811 ms) : 0, 738811
BytebuddyAgent [candidate] (736.762 ms) : 0, 736762
GlobalTracer [baseline] (237.073 ms) : 0, 237073
GlobalTracer [candidate] (236.346 ms) : 0, 236346
AppSec [baseline] (177.619 ms) : 0, 177619
AppSec [candidate] (176.825 ms) : 0, 176825
Debugger [baseline] (84.103 ms) : 0, 84103
Debugger [candidate] (70.483 ms) : 0, 70483
Remote Config [baseline] (633.318 µs) : 0, 633
Remote Config [candidate] (567.246 µs) : 0, 567
Telemetry [baseline] (12.305 ms) : 0, 12305
Telemetry [candidate] (11.606 ms) : 0, 11606
IAST [baseline] (21.446 ms) : 0, 21446
IAST [candidate] (21.333 ms) : 0, 21333
section iast
BytebuddyAgent [baseline] (837.14 ms) : 0, 837140
BytebuddyAgent [candidate] (836.079 ms) : 0, 836079
GlobalTracer [baseline] (230.894 ms) : 0, 230894
GlobalTracer [candidate] (231.068 ms) : 0, 231068
AppSec [baseline] (57.109 ms) : 0, 57109
AppSec [candidate] (57.139 ms) : 0, 57139
Debugger [baseline] (83.896 ms) : 0, 83896
Debugger [candidate] (69.558 ms) : 0, 69558
Remote Config [baseline] (512.155 µs) : 0, 512
Remote Config [candidate] (506.693 µs) : 0, 507
Telemetry [baseline] (14.847 ms) : 0, 14847
Telemetry [candidate] (11.951 ms) : 0, 11951
IAST [baseline] (22.976 ms) : 0, 22976
IAST [candidate] (22.849 ms) : 0, 22849
section profiling
BytebuddyAgent [baseline] (708.067 ms) : 0, 708067
BytebuddyAgent [candidate] (709.741 ms) : 0, 709741
GlobalTracer [baseline] (348.915 ms) : 0, 348915
GlobalTracer [candidate] (351.302 ms) : 0, 351302
AppSec [baseline] (54.92 ms) : 0, 54920
AppSec [candidate] (54.978 ms) : 0, 54978
Debugger [baseline] (87.772 ms) : 0, 87772
Debugger [candidate] (74.661 ms) : 0, 74661
Remote Config [baseline] (612.992 µs) : 0, 613
Remote Config [candidate] (610.941 µs) : 0, 611
Telemetry [baseline] (12.488 ms) : 0, 12488
Telemetry [candidate] (12.257 ms) : 0, 12257
ProfilingAgent [baseline] (122.888 ms) : 0, 122888
ProfilingAgent [candidate] (122.63 ms) : 0, 122630
Profiling [baseline] (122.91 ms) : 0, 122910
Profiling [candidate] (122.653 ms) : 0, 122653
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~184a2e10dd, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1375
. : milestone, 1355,
appsec (1.737 ms) : 1713, 1761
. : milestone, 1737,
appsec_no_iast (1.731 ms) : 1707, 1754
. : milestone, 1731,
code_origins (1.672 ms) : 1638, 1707
. : milestone, 1672,
iast (1.516 ms) : 1492, 1541
. : milestone, 1516,
profiling (1.518 ms) : 1493, 1543
. : milestone, 1518,
tracing (1.492 ms) : 1468, 1516
. : milestone, 1492,
section candidate
no_agent (1.373 ms) : 1354, 1393
. : milestone, 1373,
appsec (1.734 ms) : 1710, 1758
. : milestone, 1734,
appsec_no_iast (1.711 ms) : 1686, 1736
. : milestone, 1711,
code_origins (1.692 ms) : 1659, 1726
. : milestone, 1692,
iast (1.508 ms) : 1483, 1533
. : milestone, 1508,
profiling (1.527 ms) : 1503, 1551
. : milestone, 1527,
tracing (1.499 ms) : 1475, 1523
. : milestone, 1499,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~184a2e10dd, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section baseline
no_agent (384.345 µs) : 364, 405
. : milestone, 384,
iast (528.6 µs) : 506, 551
. : milestone, 529,
iast_FULL (734.963 µs) : 713, 757
. : milestone, 735,
iast_GLOBAL (570.649 µs) : 547, 594
. : milestone, 571,
iast_HARDCODED_SECRET_DISABLED (519.534 µs) : 496, 543
. : milestone, 520,
iast_INACTIVE (472.46 µs) : 451, 494
. : milestone, 472,
iast_TELEMETRY_OFF (507.961 µs) : 485, 531
. : milestone, 508,
tracing (459.71 µs) : 439, 480
. : milestone, 460,
section candidate
no_agent (380.404 µs) : 361, 400
. : milestone, 380,
iast (514.876 µs) : 493, 537
. : milestone, 515,
iast_FULL (731.907 µs) : 710, 754
. : milestone, 732,
iast_GLOBAL (558.716 µs) : 537, 580
. : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (514.328 µs) : 493, 536
. : milestone, 514,
iast_INACTIVE (464.372 µs) : 443, 486
. : milestone, 464,
iast_TELEMETRY_OFF (502.732 µs) : 481, 525
. : milestone, 503,
tracing (460.22 µs) : 439, 481
. : milestone, 460,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~184a2e10dd, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.342 ms) : 2299, 2386
. : milestone, 2342,
iast (2.114 ms) : 2059, 2169
. : milestone, 2114,
iast_GLOBAL (2.177 ms) : 2121, 2234
. : milestone, 2177,
profiling (1.969 ms) : 1925, 2012
. : milestone, 1969,
tracing (1.942 ms) : 1900, 1984
. : milestone, 1942,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.348 ms) : 2304, 2391
. : milestone, 2348,
iast (2.12 ms) : 2065, 2175
. : milestone, 2120,
iast_GLOBAL (2.161 ms) : 2106, 2217
. : milestone, 2161,
profiling (1.97 ms) : 1927, 2013
. : milestone, 1970,
tracing (1.935 ms) : 1893, 1977
. : milestone, 1935,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~184a2e10dd, baseline=1.47.0-SNAPSHOT~9966995dd4
dateFormat X
axisFormat %s
section baseline
no_agent (15.414 s) : 15414000, 15414000
. : milestone, 15414000,
appsec (14.894 s) : 14894000, 14894000
. : milestone, 14894000,
iast (18.562 s) : 18562000, 18562000
. : milestone, 18562000,
iast_GLOBAL (17.983 s) : 17983000, 17983000
. : milestone, 17983000,
profiling (15.432 s) : 15432000, 15432000
. : milestone, 15432000,
tracing (15.061 s) : 15061000, 15061000
. : milestone, 15061000,
section candidate
no_agent (15.517 s) : 15517000, 15517000
. : milestone, 15517000,
appsec (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
iast (18.13 s) : 18130000, 18130000
. : milestone, 18130000,
iast_GLOBAL (17.829 s) : 17829000, 17829000
. : milestone, 17829000,
profiling (15.016 s) : 15016000, 15016000
. : milestone, 15016000,
tracing (14.78 s) : 14780000, 14780000
. : milestone, 14780000,
|
supersede by #8587 |
What Does This Do
move the the classname filtering when actual feature are enabled because it adds some overhead at startup to read and parse the third-party list
Motivation
startup perf
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]