8000 Gary/add llmobs svc functionalities traceid by gary-huang · Pull Request #8505 · DataDog/dd-trace-java · GitHub
[go: up one dir, main page]
Skip to content

Gary/add llmobs svc functionalities traceid #8505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Gary/add llmobs svc functionalities traceid #8505

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e2f347c
add APIs for llm obs
gary-huang Sep 19, 2024
d16b87d
add llm message class to support llm spans
gary-huang Mar 6, 2025
ec0066e
add llm message class to support llm spans
gary-huang Mar 6, 2025
6e3ea48
impl llmobs agent and llmobs apis
gary-huang Jan 27, 2025
8ae12e9
support llm messages with tool calls
gary-huang Mar 6, 2025
a090459
handle default model name and provider
gary-huang Mar 26, 2025
768f4e6
impl llmobs agent
gary-huang Jan 27, 2025
3def304
working writer
gary-huang Feb 7, 2025
f858e30
add support for llm message and tool calls
gary-huang Mar 6, 2025
5743fe3
working writer
gary-huang Feb 7, 2025
11a0421
working writer
gary-huang Feb 7, 2025
c90915b
working writer
gary-huang Feb 7, 2025
d2b33d9
working writer
gary-huang Feb 7, 2025
63275f6
use trace ID to map to individual stacks of active contexts
gary-huang Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add support for llm message and tool calls
  • Loading branch information
@gary-huang
gary-huang committed Mar 26, 2025
commit f858e30d3189018115e25c51ca42f3f2016d467a
65 changes: 60 additions & 5 deletions dd-trace-core/src/main/java/datadog/trace/llmobs/writer/ddintake/LLMObsSpanMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import datadog.communication.serialization.Writable;
import datadog.trace.api.DDTags;
import datadog.trace.api.intake.TrackType;
import datadog.trace.api.llmobs.LLMObs;
import datadog.trace.api.llmobs.LLMObsTags;
import datadog.trace.bootstrap.instrumentation.api.InternalSpanTypes;
import datadog.trace.bootstrap.instrumentation.api.Tags;
Expand Down Expand Up @@ -63,6 +64,17 @@ public class LLMObsSpanMapper implements RemoteMapper {
private static final byte[] METRICS = "metrics".getBytes(StandardCharsets.UTF_8);
private static final byte[] TAGS = "tags".getBytes(StandardCharsets.UTF_8);

private static final byte[] LLM_MESSAGE_ROLE = "role".getBytes(StandardCharsets.UTF_8);
private static final byte[] LLM_MESSAGE_CONTENT = "content".getBytes(StandardCharsets.UTF_8);
private static final byte[] LLM_MESSAGE_TOOL_CALLS =
"tool_calls".getBytes(StandardCharsets.UTF_8);

private static final byte[] LLM_TOOL_CALL_NAME = "name".getBytes(StandardCharsets.UTF_8);
private static final byte[] LLM_TOOL_CALL_TYPE = "type".getBytes(StandardCharsets.UTF_8);
private static final byte[] LLM_TOOL_CALL_TOOL_ID = "tool_id".getBytes(StandardCharsets.UTF_8);
private static final byte[] LLM_TOOL_CALL_ARGUMENTS =
"arguments".getBytes(StandardCharsets.UTF_8);

private final LLMObsSpanMapper.MetaWriter metaWriter = new MetaWriter();
private final int size;

Expand Down Expand Up @@ -242,8 +254,7 @@ public void accept(Metadata metadata) {
for (Map.Entry<String, Object> tag : metadata.getTags().entrySet()) {
String key = tag.getKey();
Object value = tag.getValue();
if (!tagsToRemapToMeta.containsKey(key)
&& key.startsWith(LLMOBS_TAG_PREFIX)) {
if (!tagsToRemapToMeta.containsKey(key) && key.startsWith(LLMOBS_TAG_PREFIX)) {
writable.writeObject(key.substring(LLMOBS_TAG_PREFIX.length()) + ":" + value, null);
}
}
Expand All @@ -266,8 +277,52 @@ public void accept(Metadata metadata) {
if (key.equals(INPUT) || key.equals(OUTPUT)) {
if (!spanKind.equals(Tags.LLMOBS_LLM_SPAN_KIND)) {
key += ".value";
writable.writeString(key, null);
writable.writeObject(val, null);
} else {
if (!(val instanceof List)) {
LOGGER.warn(
"unexpectedly found incorrect type for LLM span IO {}, expecting list",
val.getClass().getName());
continue;
}
// llm span kind must have llm objects
List<LLMObs.LLMMessage> messages = (List<LLMObs.LLMMessage>) val;
key += ".messages";
writable.writeString(key, null);
writable.startArray(messages.size());
for (LLMObs.LLMMessage message : messages) {
List<LLMObs.ToolCall> toolCalls = message.getToolCalls();
boolean hasToolCalls = null != toolCalls && !toolCalls.isEmpty();
writable.startMap(hasToolCalls ? 3 : 2);
writable.writeUTF8(LLM_MESSAGE_ROLE);
writable.writeString(message.getRole(), null);
writable.writeUTF8(LLM_MESSAGE_CONTENT);
writable.writeString(message.getContent(), null);
if (hasToolCalls) {
writable.writeUTF8(LLM_MESSAGE_TOOL_CALLS);
writable.startArray(toolCalls.size());
for (LLMObs.ToolCall toolCall : toolCalls) {
Map<String, Object> arguments = toolCall.getArguments();
boolean hasArguments = null != arguments && !arguments.isEmpty();
writable.startMap(hasArguments ? 4 : 3);
writable.writeUTF8(LLM_TOOL_CALL_NAME);
writable.writeString(toolCall.getName(), null);
writable.writeUTF8(LLM_TOOL_CALL_TYPE);
writable.writeString(toolCall.getType(), null);
writable.writeUTF8(LLM_TOOL_CALL_TOOL_ID);
writable.writeString(toolCall.getToolID(), null);
if (hasArguments) {
writable.writeUTF8(LLM_TOOL_CALL_ARGUMENTS);
writable.startMap(arguments.size());
for (Map.Entry<String, Object> argument : arguments.entrySet()) {
writable.writeString(argument.getKey(), null);
writable.writeObject(argument.getValue(), null);
}
}
}
}
}
}
} else if (key.equals(LLMObsTags.METADATA) && val instanceof Map) {
Map<String, Object> metadataMap = (Map) val;
Expand All @@ -277,10 +332,10 @@ public void accept(Metadata metadata) {
writable.writeString(entry.getKey(), null);
writable.writeObject(entry.getValue(), null);
}
continue;
} else {
writable.writeString(key, null);
writable.writeObject(val, null);
}
writable.writeString(key, null);
writable.writeObject(val, null);
}
}
}
Expand Down
0