-
Notifications
You must be signed in to change notification settings - Fork 310
Add capabilities tagging #8499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
daniel-mohedano
merged 44 commits into
master
from
daniel.mohedano/library-capabilities-tagging
Mar 7, 2025
Merged
Add capabilities tagging #8499
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
8e9bb96
introduce seperate test events handlers in junit5 instrumentations
daniel-mohedano 7ab85a0
clear junit5 handler map on close
daniel-mohedano b8c748f
introduce separate test events handlers in junit4 instrumentations
daniel-mohedano 45735e6
junit4 instrumentation fixes
daniel-mohedano ee63fa7
fix muzzle checks for junit5 instrumentation
daniel-mohedano 8ec555d
fix double close of default handler in junit5 instrumentation
daniel-mohedano 04a8084
pr fixes
daniel-mohedano 408a7d3
fix code quality violation
daniel-mohedano 7d28e5a
use framework as component in junit4 and junit5 instrumentations
daniel-mohedano cfd4fda
update test fixtures with new component string
daniel-mohedano 7877125
update smoke test fixtures with new component string
daniel-mohedano 5a796b9
update selenium test fixtures and fix fixture generation
daniel-mohedano 9a320be
fix codenarc issue
daniel-mohedano 02c6bcc
Merge branch 'master' into daniel.mohedano/instrumentation-test-handl…
daniel-mohedano 568f709
implements capabilities tagging logic
daniel-mohedano 2b25ea8
update weaver instrumentation
daniel-mohedano ef2664d
update karate instrumentation
daniel-mohedano 3538287
unify karate version in KarateUtils
daniel-mohedano a52cc21
update testng instrumentation
daniel-mohedano bc0d0b3
add testng ordering to capabilities
daniel-mohedano c9a0114
backport ComparableVersion from maven artifact to avoid packaging it
daniel-mohedano 8129852
update junit5 instrumentations
daniel-mohedano 103a089
update junit4 instrumentations
daniel-mohedano 6685a5b
extend headless test session to ensure all capabilities are propagated
daniel-mohedano 79df146
update scalatest instrumentation
daniel-mohedano 063b82a
tag ignoring in span assertion and update smoke test fixtures
daniel-mohedano c0cf509
jacoco test coverage excludes
daniel-mohedano e12b7c8
Merge branch 'master' into daniel.mohedano/library-capabilities-tagging
daniel-mohedano 6792874
fix code quality violations
daniel-mohedano 2bee4c2
remove leftover maven dependency for karate
daniel-mohedano bc8ab0c
bugs and spotless fix
daniel-mohedano bf6d237
ignore tags with JsonPaths instead of custom implementation
daniel-mohedano b073736
clean up arePresent and areNotPresent in TagsAssert
daniel-mohedano 0de9f87
add check for null framework versions
daniel-mohedano 877fc63
remove capabilites propagation
daniel-mohedano 8f6e0d7
remove unused test name for execution strategy
daniel-mohedano 2e9d18c
PR changes
daniel-mohedano 4238c3b
fix execution settings tests with sys config injection
daniel-mohedano 0dcea22
fix TestImplTest
daniel-mohedano c31a7d7
Merge branch 'master' into daniel.mohedano/library-capabilities-tagging
daniel-mohedano f7aa755
fix master merge
daniel-mohedano 28c2310
remove library capability utils
daniel-mohedano bd09eef
spotless !
daniel-mohedano 02fa357
change empty map call
daniel-mohedano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use framework as component in junit4 and junit5 instrumentations
- Loading branch information
commit 7d28e5afeae0c8fe85157edecc722ef2835092d8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say let's make the
start
method accept the list of capabilities. And then locate the hardcoded lists in the utility classes for each corresponding framework (JUnit, MUnit, Cucumber). Having MUnit and Cucumber capabilities hard-coded in JUnit utils feels offThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same goes for JUnit5