8000 Consider any custom security provider as potentially loading JUL by mcculls · Pull Request #8291 · DataDog/dd-trace-java · GitHub
[go: up one dir, main page]
Skip to content

Consider any custom security provider as potentially loading JUL #8291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

Consider any custom security provider as potentially loading JUL #8291

merged 1 commit into from
Jan 28, 2025

Conversation

mcculls
Copy link
Contributor
@mcculls mcculls commented Jan 27, 2025 •
edited by jira bot
Loading

follow-up to #8276

Jira ticket: APMS-14233

@mcculls mcculls added type: enhancement Enhancements and improvements comp: core Tracer core run-tests: ibm8 Run tests using IBM 8 JDK labels Jan 27, 2025
@mcculls mcculls marked this pull request as ready for review January 27, 2025 22:58
@mcculls mcculls requested a review from a team as a code owner January 27, 2025 22:58
@mcculls mcculls requested review from ygree, dougqh and bm1549 January 27, 2025 22:58
@mcculls mcculls enabled auto-merge (squash) January 27, 2025 23:15
@pr-commenter
Copy link
pr-commenter bot commented Jan 27, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/consider-custom-security-provider-as-loading-jul
git_commit_date 1738071038 1738071092
git_commit_sha 95f2490 5abbcde
release_version 1.46.0-SNAPSHOT~95f2490e06 1.46.0-SNAPSHOT~5abbcdeb5c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738073656 1738073656
ci_job_id 783400109 783400109
ci_pipeline_id 54184482 54184482
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-4p1cqabb-project-304-concurrent-1-zjor26dz 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-4p1cqabb-project-304-concurrent-1-zjor26dz 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 52 metrics, 10 unstable metrics.

scenario Δ mean execution_time candidate mean execution_time baseline mean execution_time
scenario:startup:insecure-bank:iast_HARDCODED_SECRET_DISABLED:Remote Config worse
[+28.013µs; +47.006µs] or [+4.771%; +8.006%]		 624.655µs 587.145µs
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~5abbcdeb5c, baseline=1.46.0-SNAPSHOT~95f2490e06

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039197
Total [baseline] (8.64 s) : 0, 8640275
Agent [candidate] (1.048 s) : 0, 1048041
Total [candidate] (8.655 s) : 0, 8655098
section iast
Agent [baseline] (1.175 s) : 0, 1175057
Total [baseline] (9.272 s) : 0, 9272376
Agent [candidate] (1.169 s) : 0, 1169398
Total [candidate] (9.229 s) : 0, 9228652
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1171085
Total [baseline] (9.203 s) : 0, 9202634
Agent [candidate] (1.169 s) : 0, 1169468
Total [candidate] (9.186 s) : 0, 9186352
section iast_TELEMETRY_OFF
Agent [baseline] (1.174 s) : 0, 1173583
Total [baseline] (9.248 s) : 0, 9248014
Agent [candidate] (1.163 s) : 0, 1163459
Total [candidate] (9.228 s) : 0, 9228046
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.039 s -
Agent iast 1.175 s 135.859 ms (13.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.171 s 131.888 ms (12.7%)
Agent iast_TELEMETRY_OFF 1.174 s 134.386 ms (12.9%)
Total tracing 8.64 s -
Total iast 9.272 s 632.102 ms (7.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.203 s 562.36 ms (6.5%)
Total iast_TELEMETRY_OFF 9.248 s 607.74 ms (7.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.048 s -
Agent iast 1.169 s 121.356 ms (11.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.169 s 121.427 ms (11.6%)
Agent iast_TELEMETRY_OFF 1.163 s 115.418 ms (11.0%)
Total tracing 8.655 s -
Total iast 9.229 s 573.555 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.186 s 531.254 ms (6.1%)
Total iast_TELEMETRY_OFF 9.228 s 572.948 ms (6.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~5abbcdeb5c, baseline=1.46.0-SNAPSHOT~95f2490e06

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.108 ms) : 0, 714108
BytebuddyAgent [candidate] (719.668 ms) : 0, 719668
GlobalTracer [baseline] (239.543 ms) : 0, 239543
GlobalTracer [candidate] (241.314 ms) : 0, 241314
AppSec [baseline] (55.87 ms) : 0, 55870
AppSec [candidate] (55.913 ms) : 0, 55913
Remote Config [baseline] (708.313 µs) : 0, 708
Remote Config [candidate] (713.342 µs) : 0, 713
Telemetry [baseline] (13.803 ms) : 0, 13803
Telemetry [candidate] (15.164 ms) : 0, 15164
section iast
BytebuddyAgent [baseline] (839.052 ms) : 0, 839052
BytebuddyAgent [candidate] (833.895 ms) : 0, 833895
GlobalTracer [baseline] (231.723 ms) : 0, 231723
GlobalTracer [candidate] (230.518 ms) : 0, 230518
IAST [baseline] (25.891 ms) : 0, 25891
IAST [candidate] (25.901 ms) : 0, 25901
AppSec [baseline] (53.634 ms) : 0, 53634
AppSec [candidate] (54.366 ms) : 0, 54366
Remote Config [baseline] (620.064 µs) : 0, 620
Remote Config [candidate] (611.899 µs) : 0, 612
Telemetry [baseline] (8.716 ms) : 0, 8716
Telemetry [candidate] (8.751 ms) : 0, 8751
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.573 ms) : 0, 836573
BytebuddyAgent [candidate] (833.88 ms) : 0, 833880
GlobalTracer [baseline] (231.021 ms) : 0, 231021
GlobalTracer [candidate] (230.791 ms) : 0, 230791
IAST [baseline] (26.237 ms) : 0, 26237
IAST [candidate] (25.973 ms) : 0, 25973
AppSec [baseline] (52.604 ms) : 0, 52604
AppSec [candidate] (54.026 ms) : 0, 54026
Remote Config [baseline] (587.145 µs) : 0, 587
Remote Config [candidate] (624.655 µs) : 0, 625
Telemetry [baseline] (8.619 ms) : 0, 8619
Telemetry [candidate] (8.805 ms) : 0, 8805
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (837.515 ms) : 0, 837515
BytebuddyAgent [candidate] (829.804 ms) : 0, 829804
GlobalTracer [baseline] (231.675 ms) : 0, 231675
GlobalTracer [candidate] (230.193 ms) : 0, 230193
IAST [baseline] (24.592 ms) : 0, 24592
IAST [candidate] (24.358 ms) : 0, 24358
AppSec [baseline] (55.007 ms) : 0, 55007
AppSec [candidate] (54.569 ms) : 0, 54569
Remote Config [baseline] (615.745 µs) : 0, 616
Remote Config [candidate] (609.738 µs) : 0, 610
Telemetry [baseline] (8.653 ms) : 0, 8653
Telemetry [candidate] (8.682 ms) : 0, 8682
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~5abbcdeb5c, baseline=1.46.0-SNAPSHOT~95f2490e06

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1035612
Total [baseline] (10.421 s) : 0, 10420973
Agent [candidate] (1.038 s) : 0, 1037749
Total [candidate] (10.43 s) : 0, 10430001
section appsec
Agent [baseline] (1.178 s) : 0, 1178125
Total [baseline] (10.733 s) : 0, 10733347
Agent [candidate] (1.179 s) : 0, 1178960
Total [candidate] (10.75 s) : 0, 10749518
section iast
Agent [baseline] (1.167 s) : 0, 1167012
Total [baseline] (10.976 s) : 0, 10976318
Agent [candidate] (1.167 s) : 0, 1167031
Total [candidate] (10.962 s) : 0, 10961589
section profiling
Agent [baseline] (1.255 s) : 0, 1254782
Total [baseline] (10.823 s) : 0, 10823111
Agent [candidate] (1.259 s) : 0, 1258693
Total [candidate] (10.872 s) : 0, 10871870
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.036 s -
Agent appsec 1.178 s 142.513 ms (13.8%)
Agent iast 1.167 s 131.4 ms (12.7%)
Agent profiling 1.255 s 219.17 ms (21.2%)
Total tracing 10.421 s -
Total appsec 10.733 s 312.374 ms (3.0%)
Total iast 10.976 s 555.345 ms (5.3%)
Total profiling 10.823 s 402.138 ms (3.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.038 s -
Agent appsec 1.179 s 141.21 ms (13.6%)
Agent iast 1.167 s 129.282 ms (12.5%)
Agent profiling 1.259 s 220.944 ms (21.3%)
Total tracing 10.43 s -
Total appsec 10.75 s 319.517 ms (3.1%)
Total iast 10.962 s 531.588 ms (5.1%)
Total profiling 10.872 s 441.868 ms (4.2%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~5abbcdeb5c, baseline=1.46.0-SNAPSHOT~95f2490e06

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.563 ms) : 0, 712563
BytebuddyAgent [candidate] (713.47 ms) : 0, 713470
GlobalTracer [baseline] (238.767 ms) : 0, 238767
GlobalTracer [candidate] (239.122 ms) : 0, 239122
AppSec [baseline] (55.487 ms) : 0, 55487
AppSec [candidate] (55.353 ms) : 0, 55353
Remote Config [baseline] (712.849 µs) : 0, 713
Remote Config [candidate] (710.793 µs) : 0, 711
Telemetry [baseline] (12.869 ms) : 0, 12869
Telemetry [candidate] (13.852 ms) : 0, 13852
section appsec
BytebuddyAgent [baseline] (731.297 ms) : 0, 731297
BytebuddyAgent [candidate] (730.541 ms) : 0, 730541
GlobalTracer [baseline] (236.568 ms) : 0, 236568
GlobalTracer [candidate] (236.997 ms) : 0, 236997
AppSec [baseline] (175.296 ms) : 0, 175296
AppSec [candidate] (176.43 ms) : 0, 176430
Remote Config [baseline] (656.737 µs) : 0, 657
Remote Config [candidate] (654.683 µs) : 0, 655
Telemetry [baseline] (8.282 ms) : 0, 8282
Telemetry [candidate] (8.315 ms) : 0, 8315
IAST [baseline] (21.535 ms) : 0, 21535
IAST [candidate] (21.649 ms) : 0, 21649
section iast
BytebuddyAgent [baseline] (832.843 ms) : 0, 832843
BytebuddyAgent [candidate] (832.557 ms) : 0, 832557
GlobalTracer [baseline] (230.07 ms) : 0, 230070
GlobalTracer [candidate] (230.88 ms) : 0, 230880
AppSec [baseline] (54.691 ms) : 0, 54691
AppSec [candidate] (54.215 ms) : 0, 54215
Remote Config [baseline] (624.566 µs) : 0, 625
Remote Config [candidate] (607.676 µs) : 0, 608
Telemetry [baseline] (8.734 ms) : 0, 8734
Telemetry [candidate] (8.689 ms) : 0, 8689
IAST [baseline] (24.852 ms) : 0, 24852
IAST [candidate] (24.773 ms) : 0, 24773
section profiling
BytebuddyAgent [baseline] (703.393 ms) : 0, 703393
BytebuddyAgent [candidate] (706.535 ms) : 0, 706535
GlobalTracer [baseline] (349.397 ms) : 0, 349397
GlobalTracer [candidate] (350.926 ms) : 0, 350926
AppSec [baseline] (54.903 ms) : 0, 54903
AppSec [candidate] (54.303 ms) : 0, 54303
Remote Config [baseline] (705.557 µs) : 0, 706
Remote Config [candidate] (695.817 µs) : 0, 696
Telemetry [baseline] (8.843 ms) : 0, 8843
Telemetry [candidate] (8.871 ms) : 0, 8871
ProfilingAgent [baseline] (95.344 ms) : 0, 95344
ProfilingAgent [candidate] (95.161 ms) : 0, 95161
Profiling [baseline] (95.368 ms) : 0, 95368
Profiling [candidate] (95.185 ms) : 0, 95185
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-28T13:44:15 2025-01-28T13:51:17
git_branch master mcculls/consider-custom-security-provider-as-loading-jul
git_commit_date 1738071038 1738071092
git_commit_sha 95f2490 5abbcde
release_version 1.46.0-SNAPSHOT~95f2490e06 1.46.0-SNAPSHOT~5abbcdeb5c
start_time 2025-01-28T13:44:01 2025-01-28T13:51:03
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1738072635 1738072635
ci_job_id 783400110 783400110
ci_pipeline_id 54184482 54184482
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-hu1gnouc-project-304-concurrent-1-fncwg0p1 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-hu1gnouc-project-304-concurrent-1-fncwg0p1 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~5abbcdeb5c, baseline=1.46.0-SNAPSHOT~95f2490e06
    dateFormat X
    axisFormat %s
section baseline
no_agent (376.358 µs) : 357, 396
.   : milestone, 376,
iast (511.025 µs) : 488, 534
.   : milestone, 511,
iast_FULL (737.665 µs) : 715, 761
.   : milestone, 738,
iast_GLOBAL (558.549 µs) : 535, 582
.   : milestone, 559,
iast_HARDCODED_SECRET_DISABLED (510.819 µs) : 488, 534
.   : milestone, 511,
iast_INACTIVE (458.171 µs) : 436, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (496.641 µs) : 473, 520
.   : milestone, 497,
tracing (457.95 µs) : 436, 480
.   : milestone, 458,
section candidate
no_agent (380.362 µs) : 360, 401
.   : milestone, 380,
iast (506.052 µs) : 483, 529
.   : milestone, 506,
iast_FULL (737.571 µs) : 716, 759
.   : milestone, 738,
iast_GLOBAL (557.41 µs) : 535, 580
.   : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (502.099 µs) : 479, 525
.   : milestone, 502,
iast_INACTIVE (457.986 µs) : 436, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (490.785 µs) : 468, 514
.   : milestone, 491,
tracing (449.227 µs) : 429, 470
.   : milestone, 449,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 376.358 µs [356.786 µs, 395.93 µs] -
iast 511.025 µs [487.709 µs, 534.34 µs] 134.666 µs (35.8%)
iast_FULL 737.665 µs [714.522 µs, 760.808 µs] 361.307 µs (96.0%)
iast_GLOBAL 558.549 µs [534.676 µs, 582.421 µs] 182.19 µs (48.4%)
iast_HARDCODED_SECRET_DISABLED 510.819 µs [487.517 µs, 534.121 µs] 134.461 µs (35.7%)
iast_INACTIVE 458.171 µs [435.949 µs, 480.394 µs] 81.813 µs (21.7%)
iast_TELEMETRY_OFF 496.641 µs [473.012 µs, 520.27 µs] 120.283 µs (32.0%)
tracing 457.95 µs [436.227 µs, 479.673 µs] 81.592 µs (21.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.362 µs [360.15 µs, 400.573 µs] -
iast 506.052 µs [483.106 µs, 528.999 µs] 125.691 µs (33.0%)
iast_FULL 737.571 µs [715.665 µs, 759.477 µs] 357.209 µs (93.9%)
iast_GLOBAL 557.41 µs [534.775 µs, 580.044 µs] 177.048 µs (46.5%)
iast_HARDCODED_SECRET_DISABLED 502.099 µs [478.987 µs, 525.212 µs] 121.738 µs (32.0%)
iast_INACTIVE 457.986 µs [436.154 µs, 479.818 µs] 77.624 µs (20.4%)
iast_TELEMETRY_OFF 490.785 µs [467.807 µs, 513.764 µs] 110.424 µs (29.0%)
tracing 449.227 µs [428.627 µs, 469.826 µs] 68.865 µs (18.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~5abbcdeb5c, baseline=1.46.0-SNAPSHOT~95f2490e06
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.355 ms) : 1335, 1375
.   : milestone, 1355,
appsec (1.743 ms) : 1720, 1767
.   : milestone, 1743,
appsec_no_iast (1.735 ms) : 1709, 1760
.   : milestone, 1735,
iast (1.485 ms) : 1462, 1509
.   : milestone, 1485,
profiling (1.521 ms) : 1497, 1545
.   : milestone, 1521,
tracing (1.484 ms) : 1459, 1509
.   : milestone, 1484,
section candidate
no_agent (1.362 ms) : 1343, 1382
.   : milestone, 1362,
appsec (1.742 ms) : 1719, 1765
.   : milestone, 1742,
appsec_no_iast (1.75 ms) : 1727, 1773
.   : milestone, 1750,
iast (1.514 ms) : 1490, 1538
.   : milestone, 1514,
profiling (1.517 ms) : 1492, 1542
.   : milestone, 1517,
tracing (1.496 ms) : 1471, 1521
.   : milestone, 1496,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.355 ms [1.335 ms, 1.375 ms] -
appsec 1.743 ms [1.72 ms, 1.767 ms] 388.495 µs (28.7%)
appsec_no_iast 1.735 ms [1.709 ms, 1.76 ms] 379.714 µs (28.0%)
iast 1.485 ms [1.462 ms, 1.509 ms] 130.253 µs (9.6%)
profiling 1.521 ms [1.497 ms, 1.545 ms] 166.336 µs (12.3%)
tracing 1.484 ms [1.459 ms, 1.509 ms] 129.24 µs (9.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.362 ms [1.343 ms, 1.382 ms] -
appsec 1.742 ms [1.719 ms, 1.765 ms] 379.527 µs (27.9%)
appsec_no_iast 1.75 ms [1.727 ms, 1.773 ms] 387.627 µs (28.5%)
iast 1.514 ms [1.49 ms, 1.538 ms] 151.439 µs (11.1%)
profiling 1.517 ms [1.492 ms, 1.542 ms] 154.214 µs (11.3%)
tracing 1.496 ms [1.471 ms, 1.521 ms] 133.636 µs (9.8%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master mcculls/consider-custom-security-provider-as-loading-jul
git_commit_date 1738071038 1738071092
git_commit_sha 95f2490 5abbcde
release_version 1.46.0-SNAPSHOT~95f2490e06 1.46.0-SNAPSHOT~5abbcdeb5c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1738073154 1738073154
ci_job_id 783400111 783400111
ci_pipeline_id 54184482 54184482
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-7zfpj7ut-project-304-concurrent-1-4k6h8uil 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-7zfpj7ut-project-304-concurrent-1-4k6h8uil 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~5abbcdeb5c, baseline=1.46.0-SNAPSHOT~95f2490e06
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.348 ms) : 2305, 2391
.   : milestone, 2348,
iast (2.104 ms) : 2050, 2159
.   : milestone, 2104,
iast_GLOBAL (2.152 ms) : 2097, 2207
.   : milestone, 2152,
profiling (1.969 ms) : 1926, 2013
.   : milestone, 1969,
tracing (1.944 ms) : 1902, 1986
.   : milestone, 1944,
section candidate
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (2.355 ms) : 2312, 2398
.   : milestone, 2355,
iast (2.102 ms) : 2047, 2156
.   : milestone, 2102,
iast_GLOBAL (2.146 ms) : 2091, 2201
.   : milestone, 2146,
profiling (1.954 ms) : 1911, 1998
.   : milestone, 1954,
tracing (1.938 ms) : 1896, 1980
.   : milestone, 1938,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.462 ms, 1.485 ms] -
appsec 2.348 ms [2.305 ms, 2.391 ms] 873.891 µs (59.3%)
iast 2.104 ms [2.05 ms, 2.159 ms] 630.279 µs (42.8%)
iast_GLOBAL 2.152 ms [2.097 ms, 2.207 ms] 677.838 µs (46.0%)
profiling 1.969 ms [1.926 ms, 2.013 ms] 495.474 µs (33.6%)
tracing 1.944 ms [1.902 ms, 1.986 ms] 470.044 µs (31.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.468 ms [1.457 ms, 1.48 ms] -
appsec 2.355 ms [2.312 ms, 2.398 ms] 886.12 µs (60.3%)
iast 2.102 ms [2.047 ms, 2.156 ms] 633.15 µs (43.1%)
iast_GLOBAL 2.146 ms [2.091 ms, 2.201 ms] 677.78 µs (46.2%)
profiling 1.954 ms [1.911 ms, 1.998 ms] 485.886 µs (33.1%)
tracing 1.938 ms [1.896 ms, 1.98 ms] 469.735 µs (32.0%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~5abbcdeb5c, baseline=1.46.0-SNAPSHOT~95f2490e06
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.906 s) : 14906000, 14906000
.   : milestone, 14906000,
appsec (15.324 s) : 15324000, 15324000
.   : milestone, 15324000,
iast (18.318 s) : 18318000, 18318000
.   : milestone, 18318000,
iast_GLOBAL (18.095 s) : 18095000, 18095000
.   : milestone, 18095000,
profiling (15.167 s) : 15167000, 15167000
.   : milestone, 15167000,
tracing (15.072 s) : 15072000, 15072000
.   : milestone, 15072000,
section candidate
no_agent (15.045 s) : 15045000, 15045000
.   : milestone, 15045000,
appsec (15.071 s) : 15071000, 15071000
.   : milestone, 15071000,
iast (18.978 s) : 18978000, 18978000
.   : milestone, 18978000,
iast_GLOBAL (18.016 s) : 18016000, 18016000
.   : milestone, 18016000,
profiling (14.969 s) : 14969000, 14969000
.   : milestone, 14969000,
tracing (15.09 s) : 15090000, 15090000
.   : milestone, 15090000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.906 s [14.906 s, 14.906 s] -
appsec 15.324 s [15.324 s, 15.324 s] 418.0 ms (2.8%)
iast 18.318 s [18.318 s, 18.318 s] 3.412 s (22.9%)
iast_GLOBAL 18.095 s [18.095 s, 18.095 s] 3.189 s (21.4%)
profiling 15.167 s [15.167 s, 15.167 s] 261.0 ms (1.8%)
tracing 15.072 s [15.072 s, 15.072 s] 166.0 ms (1.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.045 s [15.045 s, 15.045 s] -
appsec 15.071 s [15.071 s, 15.071 s] 26.0 ms (0.2%)
iast 18.978 s [18.978 s, 18.978 s] 3.933 s (26.1%)
iast_GLOBAL 18.016 s [18.016 s, 18.016 s] 2.971 s (19.7%)
profiling 14.969 s [14.969 s, 14.969 s] -76.0 ms (-0.5%)
tracing 15.09 s [15.09 s, 15.09 s] 45.0 ms (0.3%)

@mcculls mcculls disabled auto-merge January 28, 2025 01:24
bm1549
bm1549 approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor
@bm1549 bm1549 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as I can't see any clear downsides, but I'd appreciate review from @dougqh if he's available

amarziali
amarziali approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor
@amarziali amarziali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcculls mcculls force-pushed the mcculls/consider-custom-security-provider-as-loading-jul branch 2 times, most recently from ccec7a0 to ae11c64 Compare January 28, 2025 10:20
@mcculls mcculls requested a review from a team as a code owner January 28, 2025 10:20
@mcculls mcculls force-pushed the mcculls/consider-custom-security-provider-as-loading-jul branch from ae11c64 to 5abbcde Compare January 28, 2025 13:32
@mcculls mcculls enabled auto-merge (squash) January 28, 2025 13:32
@mcculls mcculls added the tag: no release notes Changes to exclude from release notes label Jan 28, 2025
@mcculls mcculls merged commit d0d1fa4 into master Jan 28, 2025
202 checks passed
@mcculls mcculls deleted the mcculls/consider-custom-security-provider-as-loading-jul branch January 28, 2025 14:48
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarziali amarziali amarziali approved these changes

@bm1549 bm1549 bm1549 approved these changes

@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-java

@dougqh dougqh Awaiting requested review from dougqh

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido was automatically assigned from DataDog/asm-java

@sezen-datadog sezen-datadog Awaiting requested review from sezen-datadog sezen-datadog was automatically assigned from DataDog/asm-java

Assignees
No one assigned
Labels
comp: core Tracer core run-tests: ibm8 Run tests using IBM 8 JDK tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mcculls @amarziali @bm1549
0