Capture values at entry for method probe #8169

jpbempel · 2025-01-08T12:45:15Z

What Does This Do

method probe when evaluateAt is EXIT and no condition should capture entry values. When there is a condition, entry values are not captured instrumentation check the presence of the condition to generate the entry instrumentation or not. therefore, the dummy definition used when duplicate probes need to merge the probe conditions if at least one probe has one condition.

Motivation

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: DEBUG-3307

method probe when evaluateAt is Exit and no condition should capture entry values. When there is a condition, entry values are not captured instrumentation check the presence of the condition to generate the entry instrumentation or not. therefore, the dummy definition used when duplicate probes need to merge the probe conditions if at least one probe has one condition.

We are delegating the decision to capture through a new field in CapturedContextInstrumentor

pr-commenter · 2025-01-14T17:18:01Z

Debugger benchmarks

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
ci_job_date	1736880525	1736880908
end_time	2025-01-14T18:50:03	2025-01-14T18:56:24
git_branch	master	jpbempel/fix-evaluate-at-exit-capture-entry
git_commit_sha	`07e5d63`	`9b1534a`
start_time	2025-01-14T18:48:46	2025-01-14T18:55:09

See matching parameters

	Baseline	Candidate
ci_job_id	766066561	766066561
ci_pipeline_id	52981162	52981162
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date	1736879913	1736879913

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:loop	better [-647.646µs; -624.294µs] or [-6.159%; -5.937%]	better [-700.102µs; -620.180µs] or [-6.547%; -5.799%]	better [-671.134µs; -560.981µs] or [-6.238%; -5.214%]	better [-800.402µs; -247.514µs] or [-7.220%; -2.233%]	better [+4.265op/s; +6.638op/s] or [+4.606%; +7.169%]

See unchanged results

scenario	Δ mean agg_http_req_duration_min	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p75	Δ mean agg_http_req_duration_p99	Δ mean throughput
scenario:noprobe	unstable [-31.271µs; +18.632µs] or [-11.412%; +6.799%]	unstable [-48.717µs; +27.925µs] or [-15.415%; +8.836%]	unstable [-63.732µs; +38.870µs] or [-19.197%; +11.708%]	unstable [-120.456µs; +87.895µs] or [-19.244%; +14.042%]	same
scenario:basic	same	same	same	unstable [-40.968µs; +50.920µs] or [-7.548%; +9.382%]	unstable [-96.452op/s; +224.657op/s] or [-3.858%; +8.986%]

Request duration reports for reports

gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (316.037 µs) : 277, 355
.   : milestone, 316,
basic (311.298 µs) : 300, 323
.   : milestone, 311,
loop (10.694 ms) : 10662, 10726
.   : milestone, 10694,
section candidate
noprobe (305.641 µs) : 272, 339
.   : milestone, 306,
basic (304.934 µs) : 295, 315
.   : milestone, 305,
loop (10.034 ms) : 9992, 10076
.   : milestone, 10034,

baseline results

Scenario	Request median duration [CI 0.99]
noprobe	316.037 µs [276.933 µs, 355.14 µs]
basic	311.298 µs [300.016 µs, 322.581 µs]
loop	10.694 ms [10.662 ms, 10.726 ms]

candidate results

Scenario	Request median duration [CI 0.99]
noprobe	305.641 µs [271.889 µs, 339.393 µs]
basic	304.934 µs [294.941 µs, 314.926 µs]
loop	10.034 ms [9.992 ms, 10.076 ms]

pr-commenter · 2025-01-14T17:35:41Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-evaluate-at-exit-capture-entry
git_commit_date	1736874148	1736879913
git_commit_sha	`07e5d63`	`9b1534a`
release_version	1.46.0-SNAPSHOT~07e5d634ce	1.46.0-SNAPSHOT~9b1534a6cc

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736882299	1736882299
ci_job_id	766066550	766066550
ci_pipeline_id	52981162	52981162
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 1 performance regressions! Performance is the same for 57 metrics, 5 unstable metrics.

scenario	Δ mean execution_time	candidate mean execution_time	baseline mean execution_time
scenario:startup:petclinic:profiling:GlobalTracer	worse [+16.570ms; +20.681ms] or [+4.716%; +5.886%]	369.984ms	351.358ms

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~9b1534a6cc, baseline=1.46.0-SNAPSHOT~07e5d634ce

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1056870
Total [baseline] (8.619 s) : 0, 8618715
Agent [candidate] (1.063 s) : 0, 1062871
Total [candidate] (8.674 s) : 0, 8673902
section iast
Agent [baseline] (1.187 s) : 0, 1186947
Total [baseline] (9.204 s) : 0, 9204326
Agent [candidate] (1.187 s) : 0, 1186695
Total [candidate] (9.256 s) : 0, 9256485
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.183 s) : 0, 1183114
Total [baseline] (9.18 s) : 0, 9180306
Agent [candidate] (1.185 s) : 0, 1184886
Total [candidate] (9.167 s) : 0, 9166703
section iast_TELEMETRY_OFF
Agent [baseline] (1.2 s) : 0, 1200161
Total [baseline] (9.261 s) : 0, 9261137
Agent [candidate] (1.184 s) : 0, 1183697
Total [candidate] (9.221 s) : 0, 9220916

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.057 s	-
Agent	iast	1.187 s	130.077 ms (12.3%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.183 s	126.244 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.2 s	143.292 ms (13.6%)
Total	tracing	8.619 s	-
Total	iast	9.204 s	585.611 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.18 s	561.591 ms (6.5%)
Total	iast_TELEMETRY_OFF	9.261 s	642.422 ms (7.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.063 s	-
Agent	iast	1.187 s	123.825 ms (11.7%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.185 s	122.015 ms (11.5%)
Agent	iast_TELEMETRY_OFF	1.184 s	120.827 ms (11.4%)
Total	tracing	8.674 s	-
Total	iast	9.256 s	582.583 ms (6.7%)
Total	iast_HARDCODED_SECRET_DISABLED	9.167 s	492.801 ms (5.7%)
Total	iast_TELEMETRY_OFF	9.221 s	547.014 ms (6.3%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~9b1534a6cc, baseline=1.46.0-SNAPSHOT~07e5d634ce

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.996 ms) : 0, 714996
BytebuddyAgent [candidate] (719.668 ms) : 0, 719668
GlobalTracer [baseline] (255.621 ms) : 0, 255621
GlobalTracer [candidate] (259.13 ms) : 0, 259130
AppSec [baseline] (55.218 ms) : 0, 55218
AppSec [candidate] (56.552 ms) : 0, 56552
Remote Config [baseline] (719.533 µs) : 0, 720
Remote Config [candidate] (744.767 µs) : 0, 745
Telemetry [baseline] (15.341 ms) : 0, 15341
Telemetry [candidate] (11.652 ms) : 0, 11652
section iast
BytebuddyAgent [baseline] (834.032 ms) : 0, 834032
BytebuddyAgent [candidate] (833.929 ms) : 0, 833929
GlobalTracer [baseline] (248.343 ms) : 0, 248343
GlobalTracer [candidate] (248.491 ms) : 0, 248491
AppSec [baseline] (58.158 ms) : 0, 58158
AppSec [candidate] (58.251 ms) : 0, 58251
IAST [baseline] (21.789 ms) : 0, 21789
IAST [candidate] (21.474 ms) : 0, 21474
Remote Config [baseline] (674.442 µs) : 0, 674
Remote Config [candidate] (669.77 µs) : 0, 670
Telemetry [baseline] (8.878 ms) : 0, 8878
Telemetry [candidate] (8.815 ms) : 0, 8815
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (831.57 ms) : 0, 831570
BytebuddyAgent [candidate] (833.045 ms) : 0, 833045
GlobalTracer [baseline] (247.11 ms) : 0, 247110
GlobalTracer [candidate] (248.041 ms) : 0, 248041
AppSec [baseline] (58.336 ms) : 0, 58336
AppSec [candidate] (58.203 ms) : 0, 58203
IAST [baseline] (21.597 ms) : 0, 21597
IAST [candidate] (21.161 ms) : 0, 21161
Remote Config [baseline] (685.603 µs) : 0, 686
Remote Config [candidate] (670.028 µs) : 0, 670
Telemetry [baseline] (8.832 ms) : 0, 8832
Telemetry [candidate] (8.711 ms) : 0, 8711
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (842.921 ms) : 0, 842921
BytebuddyAgent [candidate] (831.81 ms) : 0, 831810
GlobalTracer [baseline] (251.849 ms) : 0, 251849
GlobalTracer [candidate] (248.385 ms) : 0, 248385
AppSec [baseline] (58.889 ms) : 0, 58889
AppSec [candidate] (58.283 ms) : 0, 58283
IAST [baseline] (21.56 ms) : 0, 21560
IAST [candidate] (20.935 ms) : 0, 20935
Remote Config [baseline] (681.942 µs) : 0, 682
Remote Config [candidate] (689.685 µs) : 0, 690
Telemetry [baseline] (8.946 ms) : 0, 8946
Telemetry [candidate] (8.547 ms) : 0, 8547

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~9b1534a6cc, baseline=1.46.0-SNAPSHOT~07e5d634ce

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071231
Total [baseline] (10.626 s) : 0, 10625728
Agent [candidate] (1.058 s) : 0, 1058157
Total [candidate] (10.475 s) : 0, 10475319
section appsec
Agent [baseline] (1.195 s) : 0, 1194903
Total [baseline] (10.738 s) : 0, 10737860
Agent [candidate] (1.194 s) : 0, 1194174
Total [candidate] (10.745 s) : 0, 10744642
section iast
Agent [baseline] (1.188 s) : 0, 1187971
Total [baseline] (11.025 s) : 0, 11025434
Agent [candidate] (1.194 s) : 0, 1194370
Total [candidate] (11.066 s) : 0, 11066170
section profiling
Agent [baseline] (1.256 s) : 0, 1256166
Total [baseline] (10.834 s) : 0, 10833769
Agent [candidate] (1.276 s) : 0, 1275546
Total [candidate] (10.865 s) : 0, 10865101

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.071 s	-
Agent	appsec	1.195 s	123.672 ms (11.5%)
Agent	iast	1.188 s	116.74 ms (10.9%)
Agent	profiling	1.256 s	184.936 ms (17.3%)
Total	tracing	10.626 s	-
Total	appsec	10.738 s	112.132 ms (1.1%)
Total	iast	11.025 s	399.706 ms (3.8%)
Total	profiling	10.834 s	208.041 ms (2.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.058 s	-
Agent	appsec	1.194 s	136.017 ms (12.9%)
Agent	iast	1.194 s	136.214 ms (12.9%)
Agent	profiling	1.276 s	217.389 ms (20.5%)
Total	tracing	10.475 s	-
Total	appsec	10.745 s	269.323 ms (2.6%)
Total	iast	11.066 s	590.851 ms (5.6%)
Total	profiling	10.865 s	389.782 ms (3.7%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~9b1534a6cc, baseline=1.46.0-SNAPSHOT~07e5d634ce

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (725.508 ms) : 0, 725508
BytebuddyAgent [candidate] (714.257 ms) : 0, 714257
GlobalTracer [baseline] (260.067 ms) : 0, 260067
GlobalTracer [candidate] (257.212 ms) : 0, 257212
AppSec [baseline] (56.097 ms) : 0, 56097
AppSec [candidate] (55.543 ms) : 0, 55543
Remote Config [baseline] (750.184 µs) : 0, 750
Remote Config [candidate] (728.907 µs) : 0, 729
Telemetry [baseline] (13.718 ms) : 0, 13718
Telemetry [candidate] (15.404 ms) : 0, 15404
section appsec
BytebuddyAgent [baseline] (734.583 ms) : 0, 734583
BytebuddyAgent [candidate] (733.203 ms) : 0, 733203
GlobalTracer [baseline] (254.632 ms) : 0, 254632
GlobalTracer [candidate] (255.0 ms) : 0, 255000
AppSec [baseline] (171.966 ms) : 0, 171966
AppSec [candidate] (172.354 ms) : 0, 172354
IAST [baseline] (19.588 ms) : 0, 19588
IAST [candidate] (19.373 ms) : 0, 19373
Remote Config [baseline] (671.935 µs) : 0, 672
Remote Config [candidate] (672.79 µs) : 0, 673
Telemetry [baseline] (8.262 ms) : 0, 8262
Telemetry [candidate] (8.218 ms) : 0, 8218
section iast
BytebuddyAgent [baseline] (834.04 ms) : 0, 834040
BytebuddyAgent [candidate] (839.511 ms) : 0, 839511
GlobalTracer [baseline] (249.316 ms) : 0, 249316
GlobalTracer [candidate] (249.792 ms) : 0, 249792
AppSec [baseline] (58.44 ms) : 0, 58440
AppSec [candidate] (58.493 ms) : 0, 58493
IAST [baseline] (21.599 ms) : 0, 21599
IAST [candidate] (21.796 ms) : 0, 21796
Remote Config [baseline] (679.01 µs) : 0, 679
Remote Config [candidate] (690.708 µs) : 0, 691
Telemetry [baseline] (8.869 ms) : 0, 8869
Telemetry [candidate] (8.917 ms) : 0, 8917
section profiling
BytebuddyAgent [baseline] (703.462 ms) : 0, 703462
BytebuddyAgent [candidate] (704.202 ms) : 0, 704202
GlobalTracer [baseline] (351.358 ms) : 0, 351358
GlobalTracer [candidate] (369.984 ms) : 0, 369984
AppSec [baseline] (54.607 ms) : 0, 54607
AppSec [candidate] (53.966 ms) : 0, 53966
Remote Config [baseline] (682.116 µs) : 0, 682
Remote Config [candidate] (702.471 µs) : 0, 702
Telemetry [baseline] (8.904 ms) : 0, 8904
Telemetry [candidate] (8.849 ms) : 0, 8849
ProfilingAgent [baseline] (95.224 ms) : 0, 95224
ProfilingAgent [candidate] (95.788 ms) : 0, 95788
Profiling [baseline] (95.25 ms) : 0, 95250
Profiling [candidate] (95.816 ms) : 0, 95816

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-14T18:52:30	2025-01-14T18:59:30
git_branch	master	jpbempel/fix-evaluate-at-exit-capture-entry
git_commit_date	1736874148	1736879913
git_commit_sha	`07e5d63`	`9b1534a`
release_version	1.46.0-SNAPSHOT~07e5d634ce	1.46.0-SNAPSHOT~9b1534a6cc
start_time	2025-01-14T18:52:17	2025-01-14T18:59:16

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1736881522	1736881522
ci_job_id	766066553	766066553
ci_pipeline_id	52981162	52981162
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~9b1534a6cc, baseline=1.46.0-SNAPSHOT~07e5d634ce
    dateFormat X
    axisFormat %s
section baseline
no_agent (374.509 µs) : 353, 396
.   : milestone, 375,
iast (494.251 µs) : 473, 516
.   : milestone, 494,
iast_FULL (649.979 µs) : 628, 672
.   : milestone, 650,
iast_GLOBAL (515.006 µs) : 494, 536
.   : milestone, 515,
iast_HARDCODED_SECRET_DISABLED (490.267 µs) : 469, 512
.   : milestone, 490,
iast_INACTIVE (447.873 µs) : 427, 469
.   : milestone, 448,
iast_TELEMETRY_OFF (482.51 µs) : 461, 504
.   : milestone, 483,
tracing (449.467 µs) : 428, 471
.   : milestone, 449,
section candidate
no_agent (372.822 µs) : 353, 392
.   : milestone, 373,
iast (487.697 µs) : 466, 509
.   : milestone, 488,
iast_FULL (654.294 µs) : 632, 677
.   : milestone, 654,
iast_GLOBAL (525.216 µs) : 503, 548
.   : milestone, 525,
iast_HARDCODED_SECRET_DISABLED (491.402 µs) : 470, 513
.   : milestone, 491,
iast_INACTIVE (462.739 µs) : 440, 485
.   : milestone, 463,
iast_TELEMETRY_OFF (480.096 µs) : 458, 502
.   : milestone, 480,
tracing (449.477 µs) : 428, 471
.   : milestone, 449,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	374.509 µs [352.908 µs, 396.111 µs]	-
iast	494.251 µs [472.597 µs, 515.905 µs]	119.741 µs (32.0%)
iast_FULL	649.979 µs [628.196 µs, 671.763 µs]	275.47 µs (73.6%)
iast_GLOBAL	515.006 µs [493.54 µs, 536.472 µs]	140.497 µs (37.5%)
iast_HARDCODED_SECRET_DISABLED	490.267 µs [468.725 µs, 511.808 µs]	115.757 µs (30.9%)
iast_INACTIVE	447.873 µs [426.61 µs, 469.136 µs]	73.364 µs (19.6%)
iast_TELEMETRY_OFF	482.51 µs [461.165 µs, 503.854 µs]	108.0 µs (28.8%)
tracing	449.467 µs [428.352 µs, 470.582 µs]	74.957 µs (20.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	372.822 µs [353.266 µs, 392.378 µs]	-
iast	487.697 µs [466.333 µs, 509.062 µs]	114.875 µs (30.8%)
iast_FULL	654.294 µs [631.859 µs, 676.729 µs]	281.472 µs (75.5%)
iast_GLOBAL	525.216 µs [502.565 µs, 547.868 µs]	152.394 µs (40.9%)
iast_HARDCODED_SECRET_DISABLED	491.402 µs [469.85 µs, 512.955 µs]	118.58 µs (31.8%)
iast_INACTIVE	462.739 µs [440.346 µs, 485.132 µs]	89.917 µs (24.1%)
iast_TELEMETRY_OFF	480.096 µs [458.42 µs, 501.772 µs]	107.274 µs (28.8%)
tracing	449.477 µs [428.239 µs, 470.716 µs]	76.655 µs (20.6%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~9b1534a6cc, baseline=1.46.0-SNAPSHOT~07e5d634ce
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.335 ms) : 1316, 1355
.   : milestone, 1335,
appsec (1.755 ms) : 1732, 1778
.   : milestone, 1755,
appsec_no_iast (1.756 ms) : 1733, 1779
.   : milestone, 1756,
iast (1.502 ms) : 1479, 1525
.   : milestone, 1502,
profiling (1.542 ms) : 1517, 1566
.   : milestone, 1542,
tracing (1.494 ms) : 1470, 1518
.   : milestone, 1494,
section candidate
no_agent (1.329 ms) : 1309, 1349
.   : milestone, 1329,
appsec (1.742 ms) : 1718, 1766
.   : milestone, 1742,
appsec_no_iast (1.734 ms) : 1710, 1757
.   : milestone, 1734,
iast (1.506 ms) : 1483, 1528
.   : milestone, 1506,
profiling (1.548 ms) : 1523, 1573
.   : milestone, 1548,
tracing (1.483 ms) : 1458, 1508
.   : milestone, 1483,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.335 ms [1.316 ms, 1.355 ms]	-
appsec	1.755 ms [1.732 ms, 1.778 ms]	419.632 µs (31.4%)
appsec_no_iast	1.756 ms [1.733 ms, 1.779 ms]	420.71 µs (31.5%)
iast	1.502 ms [1.479 ms, 1.525 ms]	166.391 µs (12.5%)
profiling	1.542 ms [1.517 ms, 1.566 ms]	206.081 µs (15.4%)
tracing	1.494 ms [1.47 ms, 1.518 ms]	158.277 µs (11.9%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.329 ms [1.309 ms, 1.349 ms]	-
appsec	1.742 ms [1.718 ms, 1.766 ms]	413.252 µs (31.1%)
appsec_no_iast	1.734 ms [1.71 ms, 1.757 ms]	404.616 µs (30.4%)
iast	1.506 ms [1.483 ms, 1.528 ms]	176.904 µs (13.3%)
profiling	1.548 ms [1.523 ms, 1.573 ms]	218.819 µs (16.5%)
tracing	1.483 ms [1.458 ms, 1.508 ms]	153.965 µs (11.6%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	jpbempel/fix-evaluate-at-exit-capture-entry
git_commit_date	1736874148	1736879913
git_commit_sha	`07e5d63`	`9b1534a`
release_version	1.46.0-SNAPSHOT~07e5d634ce	1.46.0-SNAPSHOT~9b1534a6cc

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1736882140	1736882140
ci_job_id	766066555	766066555
ci_pipeline_id	52981162	52981162
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~9b1534a6cc, baseline=1.46.0-SNAPSHOT~07e5d634ce
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.971 s) : 14971000, 14971000
.   : milestone, 14971000,
appsec (15.264 s) : 15264000, 15264000
.   : milestone, 15264000,
iast (18.271 s) : 18271000, 18271000
.   : milestone, 18271000,
iast_GLOBAL (17.977 s) : 17977000, 17977000
.   : milestone, 17977000,
profiling (15.334 s) : 15334000, 15334000
.   : milestone, 15334000,
tracing (14.875 s) : 14875000, 14875000
.   : milestone, 14875000,
section candidate
no_agent (15.602 s) : 15602000, 15602000
.   : milestone, 15602000,
appsec (15.036 s) : 15036000, 15036000
.   : milestone, 15036000,
iast (18.86 s) : 18860000, 18860000
.   : milestone, 18860000,
iast_GLOBAL (18.219 s) : 18219000, 18219000
.   : milestone, 18219000,
profiling (15.053 s) : 15053000, 15053000
.   : milestone, 15053000,
tracing (14.949 s) : 14949000, 14949000
.   : milestone, 14949000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.971 s [14.971 s, 14.971 s]	-
appsec	15.264 s [15.264 s, 15.264 s]	293.0 ms (2.0%)
iast	18.271 s [18.271 s, 18.271 s]	3.3 s (22.0%)
iast_GLOBAL	17.977 s [17.977 s, 17.977 s]	3.006 s (20.1%)
profiling	15.334 s [15.334 s, 15.334 s]	363.0 ms (2.4%)
tracing	14.875 s [14.875 s, 14.875 s]	-96.0 ms (-0.6%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.602 s [15.602 s, 15.602 s]	-
appsec	15.036 s [15.036 s, 15.036 s]	-566.0 ms (-3.6%)
iast	18.86 s [18.86 s, 18.86 s]	3.258 s (20.9%)
iast_GLOBAL	18.219 s [18.219 s, 18.219 s]	2.617 s (16.8%)
profiling	15.053 s [15.053 s, 15.053 s]	-549.0 ms (-3.5%)
tracing	14.949 s [14.949 s, 14.949 s]	-653.0 ms (-4.2%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~9b1534a6cc, baseline=1.46.0-SNAPSHOT~07e5d634ce
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (2.353 ms) : 2311, 2396
.   : milestone, 2353,
iast (2.097 ms) : 2043, 2151
.   : milestone, 2097,
iast_GLOBAL (2.146 ms) : 2092, 2201
.   : milestone, 2146,
profiling (1.96 ms) : 1917, 2003
.   : milestone, 1960,
tracing (1.944 ms) : 1903, 1986
.   : milestone, 1944,
section candidate
no_agent (1.469 ms) : 1457, 1480
.   : milestone, 1469,
appsec (2.361 ms) : 2318, 2404
.   : milestone, 2361,
iast (2.111 ms) : 2057, 2165
.   : milestone, 2111,
iast_GLOBAL (2.139 ms) : 2084, 2194
.   : milestone, 2139,
profiling (1.984 ms) : 1940, 2029
.   : milestone, 1984,
tracing (1.942 ms) : 1900, 1984
.   : milestone, 1942,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	2.353 ms [2.311 ms, 2.396 ms]	882.976 µs (60.0%)
iast	2.097 ms [2.043 ms, 2.151 ms]	626.696 µs (42.6%)
iast_GLOBAL	2.146 ms [2.092 ms, 2.201 ms]	676.051 µs (46.0%)
profiling	1.96 ms [1.917 ms, 2.003 ms]	489.507 µs (33.3%)
tracing	1.944 ms [1.903 ms, 1.986 ms]	473.813 µs (32.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.469 ms [1.457 ms, 1.48 ms]	-
appsec	2.361 ms [2.318 ms, 2.404 ms]	892.266 µs (60.8%)
iast	2.111 ms [2.057 ms, 2.165 ms]	642.23 µs (43.7%)
iast_GLOBAL	2.139 ms [2.084 ms, 2.194 ms]	670.213 µs (45.6%)
profiling	1.984 ms [1.94 ms, 2.029 ms]	515.399 µs (35.1%)
tracing	1.942 ms [1.9 ms, 1.984 ms]	473.222 µs (32.2%)

evanchooly · 2025-01-08T13:57:02Z

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/DebuggerTransformer.java

@@ -702,6 +704,10 @@ private ProbeDefinition selectReferenceDefinition(
        LogProbe logProbe = (LogProbe) definition;
        captureSnapshot = captureSnapshot | logProbe.isCaptureSnapshot();
        capture = mergeCapture(capture, logProbe.getCapture());
+        probeCondition =


this would be simpler as:

if (probeCondition == null) probeCondition = logProbe.getCondition();

Much simpler to parse mentally.

right good call, thanks

github-actions · 2025-01-14T21:33:46Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@& 8000 #8203;nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

jpbempel added type: bug comp: debugger Dynamic Instrumentation labels Jan 8, 2025

jpbempel requested a review from a team as a code owner January 8, 2025 12:45

jpbempel requested review from evanchooly and removed request for a team January 8, 2025 12:45

jpbempel added 2 commits January 14, 2025 10:42

fix unit tests

06de71b

We are delegating the decision to capture through a new field in CapturedContextInstrumentor

jpbempel force-pushed the jpbempel/fix-evaluate-at-exit-capture-entry branch from 839399b to 06de71b Compare January 14, 2025 16:55

evanchooly approved these changes Jan 14, 2025

View reviewed changes

simplify condition

9b1534a

jpbempel added comp: debugger Dynamic Instrumentation and removed comp: debugger Dynamic Instrumentation labels Jan 14, 2025

jpbempel merged commit 8b63e5a into master Jan 14, 2025
177 of 178 checks passed

jpbempel deleted the jpbempel/fix-evaluate-at-exit-capture-entry branch January 14, 2025 21:34

github-actions bot added this to the 1.46.0 milestone Jan 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Capture values at entry for method probe #8169

Capture values at entry for method probe #8169

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Capture values at entry for method probe #8169

Capture values at entry for method probe #8169

Uh oh!

Conversation

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

Uh oh!

Debugger benchmarks

Parameters

Summary

Uh oh!

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!