E539 Add DD_TAGS colon edge case test by jybp · Pull Request #248 · DataDog/dd-opentracing-cpp · GitHub
[go: up one dir, main page]
Skip to content

Add DD_TAGS colon edge case test #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 4, 2022
Merged

Add DD_TAGS colon edge case test #248

merged 4 commits into from
Oct 4, 2022

Conversation

jybp
Copy link
Contributor
@jybp jybp commented Oct 4, 2022

Colons are allowed in Datadog tags. This adds a test case ensuring support.

https://docs.datadoghq.com/getting_started/tagging/#define-tags

@jybp jybp force-pushed the jb.pinalie/update-tracer-env-var-test branch 2 times, most recently from a917e19 to c47a12d Compare October 4, 2022 09:25
@dgoffredo dgoffredo force-pushed the jb.pinalie/update-tracer-env-var-test branch from c47a12d to 14ddcd1 Compare October 4, 2022 15:59
@dgoffredo dgoffredo marked this pull request as ready for review October 4, 2022 15:59
@dgoffredo dgoffredo self-requested a review October 4, 2022 16:02
dgoffredo
dgoffredo approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor
@dgoffredo dgoffredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

36401672-cfd4f16e-1628-11e8-9c6a-26c0f151997c

@dgoffredo dgoffredo merged commit 515c445 into master Oct 4, 2022
@dgoffredo dgoffredo deleted the jb.pinalie/update-tracer-env-var-test branch October 4, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dgoffredo dgoffredo dgoffredo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jybp @dgoffredo
0