"go install" and other changes #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgoffredo
commented
Apr 26, 2022
|
|
||
| if [[ $# != 1 ]]; then | ||
| echo "Missing parameter for version number" | ||
| echo "Missing parameter for version tag (vM.m.p)" |
There was a problem hiding this comment.
Would this be better stated as v<major>.<minor>.<patch>?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on producing a release, I noticed these improvements that could be made to the release script.
First thing to stick out was the idea that "you should use
go install" is a thing.Then I added some calls to
command -vto better track command line tool dependencies of the script.This revision also updates the library version in
version.cpptov1.3.3, since I just produced releasev1.3.2.