8000 move some things around in anticipation of ActiveTrace/TraceSegment changes by dgoffredo · Pull Request #216 · DataDog/dd-opentracing-cpp · GitHub
[go: up one dir, main page]
Skip to content

move some things around in anticipation of ActiveTrace/TraceSegment changes #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2022
Merged

move some things around in anticipation of ActiveTrace/TraceSegment changes #216

merged 4 commits into from
Feb 9, 2022

Conversation

dgoffredo
Copy link
Contributor

This is some preliminary refactoring as I work towards adapting 7073211 into something we can merge.

These changes do not affect the behavior of the code.

@dgoffredo dgoffredo requested a review from cgilmour February 8, 2022 15:20
cgilmour
cgilmour approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor
@cgilmour cgilmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@dgoffredo
Copy link
Contributor Author

thanks

@dgoffredo dgoffredo merged commit 35ef666 into master Feb 9, 2022
@dgoffredo dgoffredo deleted the david.goffredo/moving-furniture branch February 9, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cgilmour cgilmour cgilmour approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dgoffredo @cgilmour
0