F 8000 ix flushing in Exception Replay #601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In between Lambdas (after END, before START), all threads are frozen, so queued up tasks cannot run until the next invocation.
Currently, in Python, exception replay for one invocation can only works if another invocation happens in the same execution context. This is because
periodic
(which is the tracer's method for making requests to the Exception Replay endpoint) is queued up but frozen on END, and only fires if another START event is received.This change just calls the
periodic()
method at the end of the Lambda but before the threads are frozen. This fixes Exception Replay flushing and no longer requires a separate invocation to work.Motivation
https://datadoghq.atlassian.net/browse/SVLS-6845
Testing Guidelines
Manually - exception replay now works after only one invocation.
Additional Notes
Types of Changes
Check all that apply