8000 Make layer publishing idempotent by tianchu · Pull Request #118 · DataDog/datadog-lambda-python · GitHub
[go: up one dir, main page]
Skip to content

Make layer publishing idempotent #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2021
Merged

Make layer publishing idempotent #118

merged 1 commit into from
Mar 19, 2021

Conversation

tianchu
Copy link
Collaborator
@tianchu tianchu commented Mar 19, 2021 •
edited
Loading

What does this PR do?

Make layer publishing idempotent and safe to be retried. If the specified version already exists then skip, otherwise publish layers until the latest version matches the specified version.

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@tianchu tianchu requested a review from a team as a code owner March 19, 2021 03:41
hghotra
hghotra reviewed Mar 19, 2021
View reviewed changes
scripts/publish_layers.sh
Comment on lines +129 to +131
# This shouldn't happen unless someone manually deleted the latest version, say 28
# and then try to republish it again. The published version is actually be 29, because
# Lambda layers are immutable and AWS will skip deleted version and use the next number.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I guess if this ever does happen, the script can just be rerun with the higher layer version to catch the rest of the regions up.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's right

@tianchu tianchu merged commit 85d4fa7 into main Mar 19, 2021
@tianchu tianchu deleted the tian.chu/idempotent-layer-publishing branch March 19, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hghotra hghotra hghotra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianchu @hghotra
0