8000 fix: `http.url` tag to include protocol by duncanista · Pull Request #656 · DataDog/datadog-lambda-js · GitHub
[go: up one dir, main page]
Skip to content

fix: http.url tag to include protocol #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2025
Merged

fix: http.url tag to include protocol #656

merged 4 commits into from
May 23, 2025

Conversation

duncanista
Copy link
Contributor

What does this PR do?

Adds protocol to http.url tag in inferred spans and trigger tags

Motivation

#654

Testing Guidelines

Unit tests and integration tests

Additional Notes

The Next Gen Lambda Extension uses a crate to obfuscate span tags, this doesnt play nicely when http.url doesn't have a protocol, causing it to be set as ?, this will be modified there, but this is something also needed to be updated here.

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@duncanista duncanista requested a review from a team as a code owner May 22, 2025 14:00
@duncanista duncanista requested a review from a team as a code owner May 22, 2025 14:52
joeyzhao2018
joeyzhao2018 approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor
@joeyzhao2018 joeyzhao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duncanista duncanista merged commit 47fc07a into main May 23, 2025
25 checks passed
@duncanista duncanista deleted the jordan.gonzalez/inferred-spans/fix-http-url branch May 23, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purple4reina purple4reina purple4reina approved these changes

@joeyzhao2018 joeyzhao2018 joeyzhao2018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duncanista @purple4reina @joeyzhao2018
0