Extract status code when returned as string #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astuyve
reviewed
Mar 19, 2025
astuyve
reviewed
Mar 19, 2025
There was a problem hiding this comment.
in this case it's already a string, so you can just return the status code itself.
There was a problem hiding this comment.
let's just always return resultStatusCode.toString(); if it exists
src/trace/trigger.ts
Outdated
Comment on lines
396
to
398
| if (typeof resultStatusCode === "number") { | ||
| return resultStatusCode.toString(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (typeof resultStatusCode === "number") { | |
| return resultStatusCode.toString(); | |
| } |
There was a problem hiding this comment.
remove it as it doesn't do anything special for numbers
There was a problem hiding this comment.
oh yeah that's the simplest solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handles case where the status code is a string instead of a number.
We extract this status code in
extractHTTPStatusCodeTag()Motivation
#641
Testing Guidelines
Manual+unit
Additional Notes
Types of Changes
Check all that apply