8000 Use FIPs endpoint for KMS when in Govcloud region by nhulston · Pull Request #635 · DataDog/datadog-lambda-js · GitHub
[go: up one dir, main page]
Skip to content

Use FIPs endpoint for KMS when in Govcloud region #635

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 12, 2025
Merged

Use FIPs endpoint for KMS when in Govcloud region #635

merged 5 commits into from
Mar 12, 2025

Conversation

nhulston
Copy link
Contributor

What does this PR do?

When creating the kmsClient, set useFipsEndpoint to true if in a govcloud region.

Motivation

Making our products FIPs compliant.

Testing Guidelines

Manually. Works in both Govcloud and commercial regions.

Additional Notes

Related PR: #634

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@nhulston nhulston requested a review from a team as a code owner March 11, 2025 15:18
datadog-datadog-prod-us1[bot]
datadog-datadog-prod-us1 bot reviewed Mar 11, 2025
View reviewed changes
duncanista
duncanista reviewed Mar 11, 2025
View reviewed changes
@nhulston nhulston requested a review from duncanista March 11, 2025 15:43
@nhulston nhulston merged commit 579407e into main Mar 12, 2025
25 checks passed
@nhulston nhulston deleted the nicholas.hulston/use-fips-endpoint-in-kms branch March 12, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments

@duncanista duncanista duncanista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhulston @duncanista
0