10BC0 Fix: Refactored test marker logic to rely on tracked position by abhayiscoding · Pull Request #5741 · Dart-Code/Dart-Code · GitHub
[go: up one dir, main page]
Skip to content

Fix: Refactored test marker logic to rely on tracked position #5741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Refactored test marker logic to rely on tracked position #5741

wants to merge 1 commit into from

Conversation

abhayiscoding
Copy link

Fixed #5739

  • Modified the logic of removeAllPotentiallyDeletedNodes() to skip cleanup when using new tracking.
  • Alternatively modified flagSuiteStart() to not mark nodes as potentially deleted when using experimental tracking.
  • File: src\shared\test\test_model.ts

@abhayiscoding
Copy link
Author

Submitted a PR to address this: #5741
Let me know if any changes are needed!

@DanTup
Copy link
Member
DanTup commented Oct 7, 2025

Thanks! I think we need to ensure there are good tests for this though. There are existing tests that will cover some of this once this behaviour is default, but I think we'll need to expand the tests that use test_reflective_loader to ensure we tests are deleted correctly if you do delete them (and not if you just ran a solo test).

We could add those tests now and just also guard them with this check, but once the new tracking is always enabled, it would (should) allow us to delete a bunch of code related to this tracking of potentially-deleted nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reconsider removing "potentially deleted" tests once using new test tracking by default

2 participants

@abhayiscoding @DanTup
0