10000 Refactor `Question.save_condition` by aaronskiba · Pull Request #3501 · DMPRoadmap/roadmap · GitHub
[go: up one dir, main page]
Skip to content

Refactor Question.save_condition #3501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 7, 2025
Merged

Refactor Question.save_condition #3501

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
739aad0
Refactor mapping of `remove_data` & `option_list`
aaronskiba Apr 4, 2025
f6a232b
Refactor webhook_data validation and construction
aaronskiba Apr 4, 2025
82984e2
Refactor handling of `c.option_list.empty?`
aaronskiba Apr 4, 2025
49b9f7d
Refactor option_list and remove_data handling
aaronskiba Apr 4, 2025
115ea70
Put back `# rubocop:disable Metrics/MethodLength`
aaronskiba Apr 4, 2025
0fde253
Update CHANGELOG.md
aaronskiba Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Put back # rubocop:disable Metrics/MethodLength
  • Loading branch information
@aaronskiba
aaronskiba committed Apr 4, 2025
commit 115ea702768a1470aad964dfe3d0773e56410076
4 changes: 2 additions & 2 deletions app/models/question.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def update_conditions(param_conditions, old_to_new_opts, question_id_map)
end
end

# rubocop:disable Metrics/AbcSize
# rubocop:disable Metrics/AbcSize, Metrics/MethodLength
def save_condition(value, opt_map, question_id_map)
c = conditions.build
c.action_type = value['action_type']
Expand Down Expand Up @@ -244,7 +244,7 @@ def save_condition(value, opt_map, question_id_map)
end
c.save
end
# rubocop:enable Metrics/AbcSize
# rubocop:enable Metrics/AbcSize, Metrics/MethodLength

private

Expand Down
Loading
0